Openembedded Devel Discussions
 help / color / mirror / Atom feed
From: Jack Mitchell <ml@communistcode.co.uk>
To: Jack Mitchell <ml@communistcode.co.uk>
Cc: openembedded-devel@lists.openembedded.org
Subject: Re: [meta-oe][PATCH v5] php: add sqlite3 and mysql PACKAGECONFIG options
Date: Tue, 23 Apr 2013 10:20:48 +0100	[thread overview]
Message-ID: <51765270.1090105@communistcode.co.uk> (raw)
In-Reply-To: <1366708708-24878-1-git-send-email-ml@communistcode.co.uk>

On 23/04/13 10:18, Jack Mitchell wrote:
> From: Jack Mitchell <jack.mitchell@dbbroadcast.co.uk>
>
> Signed-off-by: Jack Mitchell <jack.mitchell@dbbroadcast.co.uk>
> ---
>   meta-oe/recipes-devtools/php/php.inc | 38 +++++++++++++++++++++++-------------
>   1 file changed, 24 insertions(+), 14 deletions(-)
>
> diff --git a/meta-oe/recipes-devtools/php/php.inc b/meta-oe/recipes-devtools/php/php.inc
> index 225c3d7..749f51c 100644
> --- a/meta-oe/recipes-devtools/php/php.inc
> +++ b/meta-oe/recipes-devtools/php/php.inc
> @@ -3,11 +3,11 @@ HOMEPAGE = "http://www.php.net"
>   SECTION = "console/network"
>   LICENSE = "PHP-3.0"
>   BBCLASSEXTEND = "native"
> -DEPENDS = "zlib libxml2 virtual/libiconv php-native lemon-native mysql5 \
> -           libc-client openssl sqlite3"
> +DEPENDS = "zlib libxml2 virtual/libiconv php-native lemon-native \
> +           libc-client openssl"
>   DEPENDS_virtclass-native = "zlib-native libxml2-native"
>   
> -INC_PR = "r4"
> +INC_PR = "r5"
>   
>   SRC_URI = "http://www.php.net/distributions/php-${PV}.tar.bz2"
>   
> @@ -19,27 +19,37 @@ SSTATE_SCAN_FILES += "build-defs.h"
>   
>   # Common EXTRA_OECONF
>   COMMON_EXTRA_OECONF = "--enable-sockets --enable-pcntl --enable-shared"
> -EXTRA_OECONF = "--enable-mbstring --enable-discard-path --enable-wddx \
> -                --enable-magic-quotes --enable-fastcgi --enable-fpm \
> +EXTRA_OECONF = "--enable-mbstring \
> +                --enable-wddx \
> +                --enable-fpm \
>                   --with-imap=${STAGING_DIR_HOST} \
>                   --with-gettext=${STAGING_LIBDIR}/.. \
>                   --with-imap-ssl=${STAGING_DIR_HOST} \
> -                --with-zlib --with-zlib-dir=${STAGING_LIBDIR}/.. \
> +                --with-zlib=${STAGING_LIBDIR}/.. \
>                   --with-iconv=${STAGING_LIBDIR}/.. \
>                   --with-libxml-dir=${STAGING_BINDIR_CROSS} \
> -                --disable-embedded-mysqli \
> -                --with-mysql="${STAGING_DIR_TARGET}${prefix}" \
> -                --with-mysqli="${STAGING_BINDIR_CROSS}/mysql_config" \
> -        --with-sqlite3=${STAGING_LIBDIR}/.. --enable-sqlite-utf8 \
> -                --with-pdo-mysql="${STAGING_BINDIR_CROSS}/mysql_config" \
> -                --with-pdo-sqlite=${STAGING_LIBDIR}/.. ${COMMON_EXTRA_OECONF} \
> +                ${COMMON_EXTRA_OECONF} \
>   "
> -EXTRA_OECONF_virtclass-native = "--with-cgi --without-libpng --without-libjpeg \
> -                --with-zlib --with-zlib-dir=${STAGING_LIBDIR_NATIVE}/.. \
> +EXTRA_OECONF_virtclass-native = " \
> +                --with-zlib=${STAGING_LIBDIR_NATIVE}/.. \
>                   --with-libxml-dir=${STAGING_BINDIR_NATIVE} \
>                   ${COMMON_EXTRA_OECONF} \
>   "
>   
> +PACKAGECONFIG ??= "mysql sqlite3"
> +PACKAGECONFIG_class-native = ""
> +
> +PACKAGECONFIG[mysql] = "--with-mysql=${STAGING_DIR_TARGET}${prefix} \
> +                        --with-mysqli=${STAGING_BINDIR_CROSS}/mysql_config \
> +                        --with-pdo-mysql=${STAGING_BINDIR_CROSS}/mysql_config \
> +                        , \
> +                        ,mysql5"
> +
> +PACKAGECONFIG[sqlite3] = "--with-sqlite3=${STAGING_LIBDIR}/.. \
> +                          --with-pdo-sqlite=${STAGING_LIBDIR}/.. \
> +                          , \
> +                          ,sqlite3"
> +
>   LIBS_virtclass-native = " -lxml2 "
>   LIBS_pn-php =" -lpthread "
>   export LIBS

The patch in my repo has somehow become munged, this is the exact 
changes I have which is building correctly as above. I don't know how 
they got joined, but they did. This negates the need for 2/2 of this 
patchset, it's all rolled in.

Sorry for the saga this is becoming!

-- 

   Jack Mitchell (jack@embed.me.uk)
   Embedded Systems Engineer
   http://www.embed.me.uk

--




  reply	other threads:[~2013-04-23  9:38 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-19 10:07 [PATCH 0/2 v4] php: add PACKAGECONFIG options Jack Mitchell
2013-04-19 10:07 ` [PATCH 1/2] php: add sqlite3 and mysql " Jack Mitchell
2013-04-22 16:53   ` Martin Jansa
2013-04-23  9:07     ` Jack Mitchell
2013-04-23  9:18     ` [meta-oe][PATCH v5] " Jack Mitchell
2013-04-23  9:20       ` Jack Mitchell [this message]
2013-04-19 10:07 ` [PATCH 2/2] php: remove non-existant configure flags and improve current ones Jack Mitchell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51765270.1090105@communistcode.co.uk \
    --to=ml@communistcode.co.uk \
    --cc=openembedded-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox