[meta-qt5][PATCH] qtbase: typo about virtual/egl depends

[meta-qt5][PATCH] qtbase: typo about virtual/egl depends

[Nicolas Dechesne]

The proper 'virtual' name for EGL is virtual/egl, not virtual/libegl,
as per meta/recipes-graphics/mesa/mesa-common.inc.

Signed-off-by: Nicolas Dechesne <nicolas.dechesne@linaro.org>
---
 recipes-qt/qt5/qtbase.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/recipes-qt/qt5/qtbase.inc b/recipes-qt/qt5/qtbase.inc
index 569332e..ee4094b 100644
--- a/recipes-qt/qt5/qtbase.inc
+++ b/recipes-qt/qt5/qtbase.inc
@@ -41,7 +41,7 @@ QT_DISTRO_FLAGS_linuxstdbase = "-sm"
 QT_SQL_DRIVER_FLAGS ?= "-no-sql-ibase -no-sql-mysql -no-sql-psql -no-sql-odbc -plugin-sql-sqlite"
 
 # if you want to enable egl/gles2 in your .bbappend, don't forget to add right dependencies, e.g.
-# GL_DEPENDS = "virtual/libgles2 virtual/libegl"
+# GL_DEPENDS = "virtual/libgles2 virtual/egl"
 # QT_GLFLAGS = "-opengl es2 -eglfs"
 GL_DEPENDS ?= "virtual/libgl"
 QT_GLFLAGS ?= "-opengl"
-- 
1.8.1.2

Re: [meta-qt5][PATCH] qtbase: typo about virtual/egl depends

[Carlos Rafael Giani]

On 2013-06-20 05:54, Nicolas Dechesne wrote:
> The proper 'virtual' name for EGL is virtual/egl, not virtual/libegl,
> as per meta/recipes-graphics/mesa/mesa-common.inc.
>
> Signed-off-by: Nicolas Dechesne <nicolas.dechesne@linaro.org>
> ---
>   recipes-qt/qt5/qtbase.inc | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/recipes-qt/qt5/qtbase.inc b/recipes-qt/qt5/qtbase.inc
> index 569332e..ee4094b 100644
> --- a/recipes-qt/qt5/qtbase.inc
> +++ b/recipes-qt/qt5/qtbase.inc
> @@ -41,7 +41,7 @@ QT_DISTRO_FLAGS_linuxstdbase = "-sm"
>   QT_SQL_DRIVER_FLAGS ?= "-no-sql-ibase -no-sql-mysql -no-sql-psql -no-sql-odbc -plugin-sql-sqlite"
>   
>   # if you want to enable egl/gles2 in your .bbappend, don't forget to add right dependencies, e.g.
> -# GL_DEPENDS = "virtual/libgles2 virtual/libegl"
> +# GL_DEPENDS = "virtual/libgles2 virtual/egl"
>   # QT_GLFLAGS = "-opengl es2 -eglfs"
>   GL_DEPENDS ?= "virtual/libgl"
>   QT_GLFLAGS ?= "-opengl"

This highlights a problem I've noticed in the past. A directory of 
officially defined virtual names would be helpful. Also, since many BSPs 
offer hardware-accelerated OpenVG, a virtual/openvg name would be 
useful. ("vg" and "libvg" are very uncommon, so I'd pick "openvg".)