[meta-oe][PATCH 0/3] liblockfile updates for SOBBW

[meta-oe][PATCH 0/3] liblockfile updates for SOBBW

[Trevor Woerner]

This series implements a bunch of fixups to remove QA configure warnings. The
first patch gets rid of a warning which is logged, the remaining patches get
rid of warnings which are suppressed.

Trevor Woerner (3):
  liblockfile: remove configure warning
  liblockfile: remove dependency tracking option
  liblockfile: remove silent rules option

 .../liblockfile/liblockfile-1.09/configure.patch       | 18 ++++++++++++++----
 .../recipes-extended/liblockfile/liblockfile_1.09.bb   |  6 ++++++
 2 files changed, 20 insertions(+), 4 deletions(-)

-- 
1.9.0

[meta-oe][PATCH 1/3] liblockfile: remove configure warning

[Trevor Woerner]

This fix gets rid of the following warning:

    configure: WARNING: unrecognized options: ... --with-libtool-sysroot

Signed-off-by: Trevor Woerner <trevor.woerner@linaro.org>
---
 .../liblockfile/liblockfile-1.09/configure.patch       | 18 ++++++++++++++----
 .../recipes-extended/liblockfile/liblockfile_1.09.bb   |  4 ++++
 2 files changed, 18 insertions(+), 4 deletions(-)

diff --git a/meta-oe/recipes-extended/liblockfile/liblockfile-1.09/configure.patch b/meta-oe/recipes-extended/liblockfile/liblockfile-1.09/configure.patch
index ea13e11..12413cf 100644
--- a/meta-oe/recipes-extended/liblockfile/liblockfile-1.09/configure.patch
+++ b/meta-oe/recipes-extended/liblockfile/liblockfile-1.09/configure.patch
@@ -3,16 +3,26 @@
 # Patch managed by http://www.mn-logistik.de/unsupported/pxa250/patcher
 #
 
---- liblockfile-1.05/./configure.in~configure
-+++ liblockfile-1.05/./configure.in
-@@ -1,4 +1,5 @@
+Index: liblockfile-1.09/configure.in
+===================================================================
+--- liblockfile-1.09.orig/configure.in
++++ liblockfile-1.09/configure.in
+@@ -1,10 +1,13 @@
 -AC_INIT(lockfile.c)
 +AC_INIT
 +AC_CONFIG_SRCDIR([lockfile.c])
  AC_CONFIG_HEADER(autoconf.h)
  AC_REVISION($Revision: 1.0 $)dnl
  
-@@ -111,7 +112,8 @@
+ dnl Check for GNU cc
+ AC_PROG_CC
+ 
++AC_PROG_LIBTOOL
++
+ dnl Set Default CFLAGS
+ if test "$GCC" = "yes"; then
+     CFLAGS="$CFLAGS -Wall -D_GNU_SOURCE"
+@@ -111,7 +114,8 @@ AC_SUBST(TARGETS)
  AC_SUBST(INSTALL_TARGETS)
  AC_SUBST(nfslockdir)
  
diff --git a/meta-oe/recipes-extended/liblockfile/liblockfile_1.09.bb b/meta-oe/recipes-extended/liblockfile/liblockfile_1.09.bb
index 88ebfd8..67d2221 100644
--- a/meta-oe/recipes-extended/liblockfile/liblockfile_1.09.bb
+++ b/meta-oe/recipes-extended/liblockfile/liblockfile_1.09.bb
@@ -16,6 +16,10 @@ inherit autotools
 
 EXTRA_OECONF = "--enable-shared"
 
+do_configure_prepend () {
+    touch install-sh
+}
+
 do_install () {
     oe_runmake 'ROOT=${D}' INSTGRP='' install
 }
-- 
1.9.0

[meta-oe][PATCH 2/3] liblockfile: remove dependency tracking option

[Trevor Woerner]

--disable-dependency-tracking is only available where automake is used.
liblockfile doesn't use automake, therefore remove this option to avoid a
configure warning.

Signed-off-by: Trevor Woerner <trevor.woerner@linaro.org>
---
 meta-oe/recipes-extended/liblockfile/liblockfile_1.09.bb | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meta-oe/recipes-extended/liblockfile/liblockfile_1.09.bb b/meta-oe/recipes-extended/liblockfile/liblockfile_1.09.bb
index 67d2221..f59c783 100644
--- a/meta-oe/recipes-extended/liblockfile/liblockfile_1.09.bb
+++ b/meta-oe/recipes-extended/liblockfile/liblockfile_1.09.bb
@@ -15,6 +15,7 @@ SRC_URI[sha256sum] = "16979eba05396365e1d6af7100431ae9d32f9bc063930d1de66298a069
 inherit autotools
 
 EXTRA_OECONF = "--enable-shared"
+CONFIGUREOPT_DEPTRACK = ""
 
 do_configure_prepend () {
     touch install-sh
-- 
1.9.0

[meta-oe][PATCH 3/3] liblockfile: remove silent rules option

[Trevor Woerner]

--disable-silent-rules is only available when automake is used. liblockfile
doesn't use automake, therefore remove this option to avoid a configure
warning.

Signed-off-by: Trevor Woerner <trevor.woerner@linaro.org>
---
 meta-oe/recipes-extended/liblockfile/liblockfile_1.09.bb | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meta-oe/recipes-extended/liblockfile/liblockfile_1.09.bb b/meta-oe/recipes-extended/liblockfile/liblockfile_1.09.bb
index f59c783..286eb3b 100644
--- a/meta-oe/recipes-extended/liblockfile/liblockfile_1.09.bb
+++ b/meta-oe/recipes-extended/liblockfile/liblockfile_1.09.bb
@@ -16,6 +16,7 @@ inherit autotools
 
 EXTRA_OECONF = "--enable-shared"
 CONFIGUREOPT_DEPTRACK = ""
+CONFIGUREOPTS_remove = "--disable-silent-rules"
 
 do_configure_prepend () {
     touch install-sh
-- 
1.9.0

Re: [meta-oe][PATCH 1/3] liblockfile: remove configure warning

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 2745 bytes --]

On Sat, Apr 05, 2014 at 08:39:40AM -0400, Trevor Woerner wrote:
> This fix gets rid of the following warning:
> 
>     configure: WARNING: unrecognized options: ... --with-libtool-sysroot
> 
> Signed-off-by: Trevor Woerner <trevor.woerner@linaro.org>
> ---
>  .../liblockfile/liblockfile-1.09/configure.patch       | 18 ++++++++++++++----
>  .../recipes-extended/liblockfile/liblockfile_1.09.bb   |  4 ++++
>  2 files changed, 18 insertions(+), 4 deletions(-)
> 
> diff --git a/meta-oe/recipes-extended/liblockfile/liblockfile-1.09/configure.patch b/meta-oe/recipes-extended/liblockfile/liblockfile-1.09/configure.patch
> index ea13e11..12413cf 100644
> --- a/meta-oe/recipes-extended/liblockfile/liblockfile-1.09/configure.patch
> +++ b/meta-oe/recipes-extended/liblockfile/liblockfile-1.09/configure.patch
> @@ -3,16 +3,26 @@
>  # Patch managed by http://www.mn-logistik.de/unsupported/pxa250/patcher
>  #
>  
> ---- liblockfile-1.05/./configure.in~configure
> -+++ liblockfile-1.05/./configure.in
> -@@ -1,4 +1,5 @@
> +Index: liblockfile-1.09/configure.in
> +===================================================================
> +--- liblockfile-1.09.orig/configure.in
> ++++ liblockfile-1.09/configure.in
> +@@ -1,10 +1,13 @@
>  -AC_INIT(lockfile.c)
>  +AC_INIT
>  +AC_CONFIG_SRCDIR([lockfile.c])
>   AC_CONFIG_HEADER(autoconf.h)
>   AC_REVISION($Revision: 1.0 $)dnl
>   
> -@@ -111,7 +112,8 @@
> + dnl Check for GNU cc
> + AC_PROG_CC
> + 
> ++AC_PROG_LIBTOOL
> ++
> + dnl Set Default CFLAGS
> + if test "$GCC" = "yes"; then
> +     CFLAGS="$CFLAGS -Wall -D_GNU_SOURCE"
> +@@ -111,7 +114,8 @@ AC_SUBST(TARGETS)
>   AC_SUBST(INSTALL_TARGETS)
>   AC_SUBST(nfslockdir)
>   
> diff --git a/meta-oe/recipes-extended/liblockfile/liblockfile_1.09.bb b/meta-oe/recipes-extended/liblockfile/liblockfile_1.09.bb
> index 88ebfd8..67d2221 100644
> --- a/meta-oe/recipes-extended/liblockfile/liblockfile_1.09.bb
> +++ b/meta-oe/recipes-extended/liblockfile/liblockfile_1.09.bb
> @@ -16,6 +16,10 @@ inherit autotools
>  
>  EXTRA_OECONF = "--enable-shared"

Can you please rebase on current master (maybe you have one more patch
which you haven't sent), because in master there is:

EXTRA_OECONF = "--enable-shared --enable-static"

so this doesn't apply.

>  
> +do_configure_prepend () {
> +    touch install-sh
> +}
> +
>  do_install () {
>      oe_runmake 'ROOT=${D}' INSTGRP='' install
>  }
> -- 
> 1.9.0
> 
> -- 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

Re: [meta-oe][PATCH 1/3] liblockfile: remove configure warning

[Trevor Woerner]

On 04/12/14 06:44, Martin Jansa wrote:
> Can you please rebase on current master (maybe you have one more patch
> which you haven't sent), because in master there is:
>
> EXTRA_OECONF = "--enable-shared --enable-static"
>
> so this doesn't apply.

Okay, I'll send a v2.