Openembedded Devel Discussions
 help / color / mirror / Atom feed
From: Gary Thomas <gary@mlbassoc.com>
To: Martin Jansa <martin.jansa@gmail.com>,
	 openembedded-devel <openembedded-devel@lists.openembedded.org>
Subject: Re: [meta-oe][PATCH v3] mplayer2: Remove blacklist
Date: Thu, 12 Feb 2015 19:01:17 -0700	[thread overview]
Message-ID: <54DD5AED.9050707@mlbassoc.com> (raw)
In-Reply-To: <CA+chaQdfVy4bdE+-Yq7YakQ9pYnSkDLEGiqxAsVnkq7rP26KrA@mail.gmail.com>

On 2015-02-12 18:08, Martin Jansa wrote:
> Does it have --enable-* options for the new PACKAGECONFIGs? If yes then it should specify them as well (advantage at least in some projects is that when it explicitly asking for
> foo and foo is unusable it will end with fatal error instead of ignoring broken foo dependency.

No, those are auto-discover and only have disable options.

>
> On Fri, Feb 13, 2015 at 1:54 AM, Gary Thomas <gary@mlbassoc.com <mailto:gary@mlbassoc.com>> wrote:
>
>     mplayer2 no longer needs to be blacklisted as OE-core has moved
>     to libav_9.16.
>
>     [v2-v3] Also update build dependencies to quash QA warnings, using
>     PACKAGECONFIG for most optional features.
>
>     Signed-off-by: Gary Thomas <gary@mlbassoc.com <mailto:gary@mlbassoc.com>>
>     ---
>       meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb <http://mplayer2_git.bb> | 9 ++++++---
>       1 file changed, 6 insertions(+), 3 deletions(-)
>
>     diff --git a/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb <http://mplayer2_git.bb> b/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb <http://mplayer2_git.bb>
>     index 7c04ff1..2de26b0 100644
>     --- a/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb <http://mplayer2_git.bb>
>     +++ b/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb <http://mplayer2_git.bb>
>     @@ -3,7 +3,7 @@ SECTION = "multimedia"
>       HOMEPAGE = "http://www.mplayerhq.hu/"
>       DEPENDS = "libvpx libdvdread libtheora virtual/libsdl ffmpeg xsp zlib \
>                  libpng jpeg liba52 freetype fontconfig alsa-lib lzo ncurses \
>     -           libxv virtual/libx11 libass speex faad2"
>     +           libxv virtual/libx11 libass speex faad2 libxscrnsaver"
>
>       RDEPENDS_${PN} = "mplayer-common"
>       PROVIDES = "mplayer"
>     @@ -13,8 +13,6 @@ RCONFLICTS_${PN} = "mplayer"
>       LICENSE = "GPLv3"
>       LIC_FILES_CHKSUM = "file://LICENSE;md5=d32239bcb673463ab874e80d47fae504"
>
>     -PNBLACKLIST[mplayer2] ?= "Requires newer libav which has negative D_P"
>     -
>       SRC_URI = "git://repo.or.cz/mplayer.git <http://repo.or.cz/mplayer.git> \
>           file://0001-configure-don-t-disable-ASS-support-when-explicitly-.patch \
>       "
>     @@ -109,9 +107,14 @@ EXTRA_OECONF = " \
>       EXTRA_OECONF_append_armv6 = " --enable-armv6"
>       EXTRA_OECONF_append_armv7a = " --enable-armv6 --enable-neon"
>
>     +PACKAGECONFIG ??= "vorbis postproc"
>       PACKAGECONFIG[mad] = "--enable-mad,--disable-mad,libmad"
>       PACKAGECONFIG[a52] = "--enable-liba52,--disable-liba52,liba52"
>       PACKAGECONFIG[lame] = ",,lame"
>     +PACKAGECONFIG[postproc] = ",--disable-libpostproc,libpostproc"
>     +PACKAGECONFIG[vorbis] = ",--disable-libvorbis,libvorbis"
>     +PACKAGECONFIG[portaudio] = ",--disable-portaudio,portaudio-v19"
>     +PACKAGECONFIG[mpg123] = ",--disable-mpg123,mpg123"
>
>       FULL_OPTIMIZATION = "-fexpensive-optimizations -fomit-frame-pointer -frename-registers -O4 -ffast-math"
>       BUILD_OPTIMIZATION = "${FULL_OPTIMIZATION}"
>     --
>     1.9.1
>
>     --
>     _______________________________________________
>     Openembedded-devel mailing list
>     Openembedded-devel@lists.openembedded.org <mailto:Openembedded-devel@lists.openembedded.org>
>     http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>
>

-- 
------------------------------------------------------------
Gary Thomas                 |  Consulting for the
MLB Associates              |    Embedded world
------------------------------------------------------------


  reply	other threads:[~2015-02-13  2:01 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-13  0:54 [meta-oe][PATCH v3] mplayer2: Remove blacklist Gary Thomas
2015-02-13  1:08 ` Martin Jansa
2015-02-13  2:01   ` Gary Thomas [this message]
2015-02-20 13:43     ` Martin Jansa
2015-02-20 14:02       ` Gary Thomas
2015-02-20 14:34         ` Martin Jansa
2015-02-20 14:39           ` Gary Thomas
2015-03-05 14:30             ` [meta-oe][PATCH] mplayer2: set REQUIRED_DISTRO_FEATURES and LICENSE_FLAGS Martin Jansa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54DD5AED.9050707@mlbassoc.com \
    --to=gary@mlbassoc.com \
    --cc=martin.jansa@gmail.com \
    --cc=openembedded-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox