rsyslog: buggy systemd/ua handling?

rsyslog: buggy systemd/ua handling?

[Steffen Sledz]

I'm not sure but i believe there's a bug in the systemd/ua-handling in meta-oe/recipes-extended/rsyslog/rsyslog_7.6.1.bb.

In my opinion this code

    if bb.utils.contains('DISTRO_FEATURES', 'systemd', True, False, d):
        pn = d.getVar('PN', True)
        d.appendVar('ALTERNATIVE_%s' % (pn), ' syslog-service')
        d.setVarFlag('ALTERNATIVE_LINK_NAME', 'syslog-service', '%s/systemd/system/syslog.service' % (d.getVar('sysconfdir', True)))
        d.setVarFlag('ALTERNATIVE_TARGET', 'syslog-service', '%s/system/rsyslog.service' % (d.getVar('systemd_unitdir', True)))

registers the systemd service file under the (ua-)name "syslog-service". So it should not be

  SYSTEMD_SERVICE_${PN} = "${BPN}.service"

but

  SYSTEMD_SERVICE_${PN} = "syslog.service"

Right?

-- 
DResearch Fahrzeugelektronik GmbH
Otto-Schmirgal-Str. 3, 10319 Berlin, Germany
Tel: +49 30 515932-237 mailto:sledz@dresearch-fe.de
Fax: +49 30 515932-299
Geschäftsführer: Dr. Michael Weber, Werner Mögle;
Amtsgericht Berlin Charlottenburg; HRB 130120 B;
Ust.-IDNr. DE273952058

Re: rsyslog: buggy systemd/ua handling?

[Steffen Sledz]

On 16.11.2015 12:28, Steffen Sledz wrote:
> I'm not sure but i believe there's a bug in the systemd/ua-handling in meta-oe/recipes-extended/rsyslog/rsyslog_7.6.1.bb.
> 
> In my opinion this code
> 
>     if bb.utils.contains('DISTRO_FEATURES', 'systemd', True, False, d):
>         pn = d.getVar('PN', True)
>         d.appendVar('ALTERNATIVE_%s' % (pn), ' syslog-service')
>         d.setVarFlag('ALTERNATIVE_LINK_NAME', 'syslog-service', '%s/systemd/system/syslog.service' % (d.getVar('sysconfdir', True)))
>         d.setVarFlag('ALTERNATIVE_TARGET', 'syslog-service', '%s/system/rsyslog.service' % (d.getVar('systemd_unitdir', True)))
> 
> registers the systemd service file under the (ua-)name "syslog-service". So it should not be
> 
>   SYSTEMD_SERVICE_${PN} = "${BPN}.service"
> 
> but
> 
>   SYSTEMD_SERVICE_${PN} = "syslog.service"
> 
> Right?

Hi experts! Is my assumption correct? If yes i would prepare patches for master, fido and jethro.

-- 
DResearch Fahrzeugelektronik GmbH
Otto-Schmirgal-Str. 3, 10319 Berlin, Germany
Tel: +49 30 515932-237 mailto:sledz@dresearch-fe.de
Fax: +49 30 515932-299
Geschäftsführer: Dr. Michael Weber, Werner Mögle;
Amtsgericht Berlin Charlottenburg; HRB 130120 B;
Ust.-IDNr. DE273952058