* Problems with current workflow using PatchWork
@ 2009-03-23 8:47 Otavio Salvador
2009-03-24 15:46 ` Cliff Brake
0 siblings, 1 reply; 3+ messages in thread
From: Otavio Salvador @ 2009-03-23 8:47 UTC (permalink / raw)
To: OpenEmbedded Development Mailing List
Hello,
Today I went to take a look if there were anything I could help with at
OE side and went to PatchWork to review pending patches and noticed a
cuple of issues.
- we need to do more review cycles at PatchWork and update the status
according
There're applied patches that were not archived and patches that we
asked for changes that hadn't the status changed to reflect it. This
way PW loses the main feature that is trackability of patch status.
Please commiters, when doing a commit please remember to archive the
patch at PW.
- merges need to be archived on PW
I noticed tha the RPM fixes went finally merged into the
mainline. GREAT! But they were still listed as waiting for
review. Since Marcin has commit, he did the merge but forgot to
archive the whole set of patches at PW.
I suggest we when commiting our own patches take care of archiving
them at PW to make life easier to everyone.
What others think?
--
Otavio Salvador O.S. Systems
E-mail: otavio@ossystems.com.br http://www.ossystems.com.br
Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Problems with current workflow using PatchWork
2009-03-23 8:47 Problems with current workflow using PatchWork Otavio Salvador
@ 2009-03-24 15:46 ` Cliff Brake
2009-03-24 16:29 ` Otavio Salvador
0 siblings, 1 reply; 3+ messages in thread
From: Cliff Brake @ 2009-03-24 15:46 UTC (permalink / raw)
To: openembedded-devel
On Mon, Mar 23, 2009 at 4:47 AM, Otavio Salvador
<otavio@ossystems.com.br> wrote:
> Hello,
>
> Today I went to take a look if there were anything I could help with at
> OE side and went to PatchWork to review pending patches and noticed a
> cuple of issues.
>
> - we need to do more review cycles at PatchWork and update the status
> according
>
> There're applied patches that were not archived and patches that we
> asked for changes that hadn't the status changed to reflect it. This
> way PW loses the main feature that is trackability of patch status.
>
> Please commiters, when doing a commit please remember to archive the
> patch at PW.
>
> - merges need to be archived on PW
>
> I noticed tha the RPM fixes went finally merged into the
> mainline. GREAT! But they were still listed as waiting for
> review. Since Marcin has commit, he did the merge but forgot to
> archive the whole set of patches at PW.
>
> I suggest we when commiting our own patches take care of archiving
> them at PW to make life easier to everyone.
Makes sense to me. I have been archiving patches as I apply them, and
selecting "Accepted".
Thanks,
Cliff
--
=======================
Cliff Brake
http://bec-systems.com
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Problems with current workflow using PatchWork
2009-03-24 15:46 ` Cliff Brake
@ 2009-03-24 16:29 ` Otavio Salvador
0 siblings, 0 replies; 3+ messages in thread
From: Otavio Salvador @ 2009-03-24 16:29 UTC (permalink / raw)
To: openembedded-devel
Cliff Brake <cliff.brake@gmail.com> writes:
> On Mon, Mar 23, 2009 at 4:47 AM, Otavio Salvador
> <otavio@ossystems.com.br> wrote:
>> Hello,
>>
>> Today I went to take a look if there were anything I could help with at
>> OE side and went to PatchWork to review pending patches and noticed a
>> cuple of issues.
>>
>> - we need to do more review cycles at PatchWork and update the status
>> according
>>
>> There're applied patches that were not archived and patches that we
>> asked for changes that hadn't the status changed to reflect it. This
>> way PW loses the main feature that is trackability of patch status.
>>
>> Please commiters, when doing a commit please remember to archive the
>> patch at PW.
>>
>> - merges need to be archived on PW
>>
>> I noticed tha the RPM fixes went finally merged into the
>> mainline. GREAT! But they were still listed as waiting for
>> review. Since Marcin has commit, he did the merge but forgot to
>> archive the whole set of patches at PW.
>>
>> I suggest we when commiting our own patches take care of archiving
>> them at PW to make life easier to everyone.
>
> Makes sense to me. I have been archiving patches as I apply them, and
> selecting "Accepted".
Yes, some people has been doing it. I does it too.
However we _all_ need to do that or we lose time reviewing patches that
has already been applied.
--
Otavio Salvador O.S. Systems
E-mail: otavio@ossystems.com.br http://www.ossystems.com.br
Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-03-24 16:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-03-23 8:47 Problems with current workflow using PatchWork Otavio Salvador
2009-03-24 15:46 ` Cliff Brake
2009-03-24 16:29 ` Otavio Salvador
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox