RFC: [PATCH] /etc/profile: stricter root PATH - require absolute pathname for bins in cwd

RFC: [PATCH] /etc/profile: stricter root PATH - require absolute pathname for bins in cwd

[Denys Dmytriyenko]

Having current directory (either '.' or empty string) in PATH is considered
dangerous for root.

Signed-off-by: Denys Dmytriyenko <denis@denix.org>
---
 recipes/base-files/base-files/profile |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/recipes/base-files/base-files/profile b/recipes/base-files/base-files/profile
index 5797535..b5ce69d 100644
--- a/recipes/base-files/base-files/profile
+++ b/recipes/base-files/base-files/profile
@@ -12,7 +12,7 @@ if [ ! -e /etc/localtime ]; then
 fi
 
 if [ "`id -u`" -eq 0 ]; then
-   PATH=$PATH:/usr/local/sbin:/usr/sbin:/sbin:
+   PATH=$PATH:/usr/local/sbin:/usr/sbin:/sbin
 fi
 if [ "$PS1" ]; then
 # works for bash and ash (no other shells known to be in use here)
-- 
1.6.0.6

Re: RFC: [PATCH] /etc/profile: stricter root PATH - require absolute pathname for bins in cwd

[Phil Blundell]

On Mon, 2009-06-22 at 13:44 -0400, Denys Dmytriyenko wrote:
> Having current directory (either '.' or empty string) in PATH is considered
> dangerous for root.

Agreed, having an empty element in there is a bad idea.  I don't think
any mainstream distribution does that.

FWIW, the equivalent from Debian's /etc/profile is:

 if [ "`id -u`" -eq 0 ]; then
   PATH="/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin"
 else
  PATH="/usr/local/bin:/usr/bin:/bin:/usr/games"
 fi

p.

Re: RFC: [PATCH] /etc/profile: stricter root PATH - require absolute pathname for bins in cwd

[Koen Kooi]

On 22-06-09 19:44, Denys Dmytriyenko wrote:
> Having current directory (either '.' or empty string) in PATH is considered
> dangerous for root.
>
> Signed-off-by: Denys Dmytriyenko<denis@denix.org>

Acked-by: Koen Kooi <koen@openembedded.org>


> ---
>   recipes/base-files/base-files/profile |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/recipes/base-files/base-files/profile b/recipes/base-files/base-files/profile
> index 5797535..b5ce69d 100644
> --- a/recipes/base-files/base-files/profile
> +++ b/recipes/base-files/base-files/profile
> @@ -12,7 +12,7 @@ if [ ! -e /etc/localtime ]; then
>   fi
>
>   if [ "`id -u`" -eq 0 ]; then
> -   PATH=$PATH:/usr/local/sbin:/usr/sbin:/sbin:
> +   PATH=$PATH:/usr/local/sbin:/usr/sbin:/sbin
>   fi
>   if [ "$PS1" ]; then
>   # works for bash and ash (no other shells known to be in use here)

Re: RFC: [PATCH] /etc/profile: stricter root PATH - require absolute pathname for bins in cwd

[Marcin Juszkiewicz]

[-- Attachment #1: Type: text/plain, Size: 492 bytes --]

Dnia poniedziałek, 22 czerwca 2009 o 20:31:58 Koen Kooi napisał(a):
> > Having current directory (either '.' or empty string) in PATH is
> > considered dangerous for root.
> >
> > Signed-off-by: Denys Dmytriyenko<denis@denix.org>
>
> Acked-by: Koen Kooi <koen@openembedded.org>

Acked-by: Marcin Juszkiewicz <marcin@juszkiewicz.com.pl>

Regards, 
-- 
JID:      hrw@jabber.org
Website:  http://marcin.juszkiewicz.com.pl/
LinkedIn: http://www.linkedin.com/in/marcinjuszkiewicz

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 204 bytes --]

Re: RFC: [PATCH] /etc/profile: stricter root PATH -requireabsolute pathname for bins in cwd

[Douglas Royds]

Should this find its way back into Stable?


Denys Dmytriyenko wrote:
> Having current directory (either '.' or empty string) in PATH is considered
> dangerous for root.
>
> Signed-off-by: Denys Dmytriyenko <denis@denix.org>
> ---
>  recipes/base-files/base-files/profile |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/recipes/base-files/base-files/profile b/recipes/base-files/base-files/profile
> index 5797535..b5ce69d 100644
> --- a/recipes/base-files/base-files/profile
> +++ b/recipes/base-files/base-files/profile
> @@ -12,7 +12,7 @@ if [ ! -e /etc/localtime ]; then
>  fi
>  
>  if [ "`id -u`" -eq 0 ]; then
> -   PATH=$PATH:/usr/local/sbin:/usr/sbin:/sbin:
> +   PATH=$PATH:/usr/local/sbin:/usr/sbin:/sbin
>  fi
>  if [ "$PS1" ]; then
>  # works for bash and ash (no other shells known to be in use here)
>   


=======================================================================
This email, including any attachments, is only for the intended
addressee.  It is subject to copyright, is confidential and may be
the subject of legal or other privilege, none of which is waived or
lost by reason of this transmission.
If the receiver is not the intended addressee, please accept our
apologies, notify us by return, delete all copies and perform no
other act on the email.
Unfortunately, we cannot warrant that the email has not been
 altered or corrupted during transmission.
=======================================================================

[STABLE][PATCH] /etc/profile: stricter root PATH - require absolute pathname for bins in cwd

[Denys Dmytriyenko]

Having current directory (either '.' or empty string) in PATH is considered
dangerous for root.

Signed-off-by: Denys Dmytriyenko <denis@denix.org>
Acked-by: Phil Blundell <philb@gnu.org>
Acked-by: Koen Kooi <koen@openembedded.org>
---
 recipes/base-files/base-files/profile |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/recipes/base-files/base-files/profile b/recipes/base-files/base-files/profile
index 5797535..b5ce69d 100644
--- a/recipes/base-files/base-files/profile
+++ b/recipes/base-files/base-files/profile
@@ -12,7 +12,7 @@ if [ ! -e /etc/localtime ]; then
 fi
 
 if [ "`id -u`" -eq 0 ]; then
-   PATH=$PATH:/usr/local/sbin:/usr/sbin:/sbin:
+   PATH=$PATH:/usr/local/sbin:/usr/sbin:/sbin
 fi
 if [ "$PS1" ]; then
 # works for bash and ash (no other shells known to be in use here)
-- 
1.6.0.6

Re: [STABLE][PATCH] /etc/profile: stricter root PATH - require absolute pathname for bins in cwd

[Denys Dmytriyenko]

On Wed, Jun 24, 2009 at 06:23:57PM -0400, Denys Dmytriyenko wrote:
> Having current directory (either '.' or empty string) in PATH is considered
> dangerous for root.
> 
> Signed-off-by: Denys Dmytriyenko <denis@denix.org>
> Acked-by: Phil Blundell <philb@gnu.org>
> Acked-by: Koen Kooi <koen@openembedded.org>
> ---
>  recipes/base-files/base-files/profile |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/recipes/base-files/base-files/profile b/recipes/base-files/base-files/profile
> index 5797535..b5ce69d 100644
> --- a/recipes/base-files/base-files/profile
> +++ b/recipes/base-files/base-files/profile
> @@ -12,7 +12,7 @@ if [ ! -e /etc/localtime ]; then
>  fi
>  
>  if [ "`id -u`" -eq 0 ]; then
> -   PATH=$PATH:/usr/local/sbin:/usr/sbin:/sbin:
> +   PATH=$PATH:/usr/local/sbin:/usr/sbin:/sbin
>  fi
>  if [ "$PS1" ]; then
>  # works for bash and ash (no other shells known to be in use here)
> -- 
> 1.6.0.6
> 

ping?

Re: [STABLE][PATCH] /etc/profile: stricter root PATH - require absolute pathname for bins in cwd

[Koen Kooi]

On 29-06-09 19:44, Denys Dmytriyenko wrote:
> On Wed, Jun 24, 2009 at 06:23:57PM -0400, Denys Dmytriyenko wrote:
>> Having current directory (either '.' or empty string) in PATH is considered
>> dangerous for root.
>>
>> Signed-off-by: Denys Dmytriyenko<denis@denix.org>
>> Acked-by: Phil Blundell<philb@gnu.org>
>> Acked-by: Koen Kooi<koen@openembedded.org>

Acked-by: Koen Kooi <koen@openembedded.org>


>> ---
>>   recipes/base-files/base-files/profile |    2 +-
>>   1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/recipes/base-files/base-files/profile b/recipes/base-files/base-files/profile
>> index 5797535..b5ce69d 100644
>> --- a/recipes/base-files/base-files/profile
>> +++ b/recipes/base-files/base-files/profile
>> @@ -12,7 +12,7 @@ if [ ! -e /etc/localtime ]; then
>>   fi
>>
>>   if [ "`id -u`" -eq 0 ]; then
>> -   PATH=$PATH:/usr/local/sbin:/usr/sbin:/sbin:
>> +   PATH=$PATH:/usr/local/sbin:/usr/sbin:/sbin
>>   fi
>>   if [ "$PS1" ]; then
>>   # works for bash and ash (no other shells known to be in use here)
>> --
>> 1.6.0.6
>>
>
> ping?

Re: [STABLE][PATCH] /etc/profile: stricter root PATH - require absolute pathname for bins in cwd

[Marcin Juszkiewicz]

Dnia wtorek, 30 czerwca 2009 o 20:15:18 Koen Kooi napisał(a):
> On 29-06-09 19:44, Denys Dmytriyenko wrote:
> > On Wed, Jun 24, 2009 at 06:23:57PM -0400, Denys Dmytriyenko wrote:
> >> Having current directory (either '.' or empty string) in PATH is
> >> considered dangerous for root.
> >>
> >> Signed-off-by: Denys Dmytriyenko<denis@denix.org>
> >> Acked-by: Phil Blundell<philb@gnu.org>
> >> Acked-by: Koen Kooi<koen@openembedded.org>
>
> Acked-by: Koen Kooi <koen@openembedded.org>

Acked-by: Marcin Juszkiewicz <marcin@juszkiewicz.com.pl>

Regards, 
-- 
JID:      hrw@jabber.org
Website:  http://marcin.juszkiewicz.com.pl/
LinkedIn: http://www.linkedin.com/in/marcinjuszkiewicz