[PATCH 00/12] motorola-ezx related changes

[PATCH 00/12] motorola-ezx related changes

[Antonio Ospite]

Hi, here's some motorola-ezx related changes, plus a couple of other fixes I
am using here.
Namely, the non ezx related changes are 01 and 02.

Can anyone review and apply, please?

Thanks,
   Antonio Ospite


Antonio Ospite (11):
  fso-image.inc: add an even shorter alias for ls -l
  device_table-minimal.txt: fix input device nodes path
  device_table-ezx.txt: add needed device nodes
  xserver-kdrive-common/Xserver: fix EZX settings
  tslib: Add config file for a780 machine
  motorola-ezx-base.inc: use PREFERRED_PROVIDER_virtual/xserver
  motorola-ezx-base.inc: refresh machine definition
  openezx-kernel_git: update recipe
  ezx-gen-blob: bump SRCREV
  ezx-boot-usb-native: bump SRCREV
  frameworkd_git.bb: bump SRCREV

Ilya Petrov (1):
  motorola-ezx-base.inc: Add support for ubifs

 conf/machine/include/motorola-ezx-base.inc         |   64 +++++++++++++++-----
 files/device_table-ezx.txt                         |   12 ++++-
 files/device_table-minimal.txt                     |    2 +-
 recipes/ezx/ezx-boot-usb-native_svn.bb             |    2 +-
 recipes/ezx/ezx-gen-blob_svn.bb                    |    4 +-
 recipes/freesmartphone/frameworkd_git.bb           |    4 +-
 recipes/images/fso-image.inc                       |    1 +
 recipes/linux/openezx-kernel_git.bb                |   17 ++++-
 recipes/tslib/tslib/a780/tslib.sh                  |    5 ++
 .../xserver-kdrive-common/Xserver                  |    5 +-
 10 files changed, 87 insertions(+), 29 deletions(-)
 create mode 100755 recipes/tslib/tslib/a780/tslib.sh


-- 
Antonio Ospite
http://ao2.it

PGP public key ID: 0x4553B001

A: Because it messes up the order in which people normally read text.
   See http://en.wikipedia.org/wiki/Posting_style
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?

[PATCH 01/12] fso-image.inc: add an even shorter alias, for ls -l

[Antonio Ospite]

'l' is a must have along with 'll'.

Signed-off-by: Antonio Ospite <ospite@studenti.unina.it>
---
 recipes/images/fso-image.inc |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/recipes/images/fso-image.inc b/recipes/images/fso-image.inc
index cc626f3..704d267 100644
--- a/recipes/images/fso-image.inc
+++ b/recipes/images/fso-image.inc
@@ -110,6 +110,7 @@ fso_rootfs_postprocess() {
     echo "alias fso='cd /local/pkg/fso'" >>./etc/profile
     echo "alias ipkg='opkg'" >>./etc/profile
     echo "alias vim=vi" >>./etc/profile
+    echo "alias l='ls -l'" >>./etc/profile
     echo "alias ll='ls -al'" >>./etc/profile
     # nfs
     mkdir -p ./local/pkg
-- 
1.7.1

[PATCH 02/12] device_table-minimal.txt: fix input device nodes path

[Antonio Ospite]

Input event device nodes are usually under /dev/input.

Signed-off-by: Antonio Ospite <ospite@studenti.unina.it>
---
 files/device_table-minimal.txt |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/files/device_table-minimal.txt b/files/device_table-minimal.txt
index a474377..b3a6820 100644
--- a/files/device_table-minimal.txt
+++ b/files/device_table-minimal.txt
@@ -30,7 +30,7 @@
 /dev/urandom	c	644	0	0	1	9	-	-	-
 /dev/ptmx	c	644	0	0	5	2	-	-	-
 
-/dev/event 	c	660	0	0	13	64	0	1	8
+/dev/input/event 	c	660	0	0	13	64	0	1	8
 
 /dev/mmcblk0	b	660	0	6	179	0	-	-	-
 /dev/mmcblk0p	b	660	0	6	179	1	1	1	7
-- 
1.7.1

[PATCH 03/12] device_table-ezx.txt: add needed device nodes

[Antonio Ospite]

* With all the mux nodes we can start playing again with gps on A780
* More fb nodes are needed for pxa fb overlay access
* Audio devices are needed too in the case of static /dev

Signed-off-by: Antonio Ospite <ospite@studenti.unina.it>
---
 files/device_table-ezx.txt |   12 +++++++++++-
 1 files changed, 11 insertions(+), 1 deletions(-)

diff --git a/files/device_table-ezx.txt b/files/device_table-ezx.txt
index 7246bc8..4984de9 100644
--- a/files/device_table-ezx.txt
+++ b/files/device_table-ezx.txt
@@ -8,7 +8,17 @@
 #    b	Block special device file
 #    p	Fifo (named pipe)
 
-/dev/mux	c	660	0	5	234	0	0	1	9
+/dev/mux	c	660	0	5	234	0	0	1	17
 /dev/ttyIPC0	c	660	0	5	251	0	-	-	-
 /dev/input/uinput	c	660 	0	0	10	223	-	-	-
 /dev/video0	c	660	0	44	81	0	-	-	-
+/dev/fb		c	600	0	0	29	0	0	1	4
+# audio
+/dev/dsp        c       660     0       29      14      3       -       -       - 
+/dev/snd/controlC0      c       660     0       29      116      0       -       -       - 
+/dev/snd/pcmC0D0p       c       660     0       29      116      16       -       -       - 
+/dev/snd/pcmC0D1c       c       660     0       29      116      25       -       -       - 
+/dev/snd/pcmC0D1p       c       660     0       29      116      17       -       -       - 
+/dev/snd/pcmC0D2c       c       660     0       29      116      26       -       -       - 
+/dev/snd/pcmC0D2p       c       660     0       29      116      18       -       -       - 
+/dev/snd/timer          c       660     0       29      116      33       -       -       - 
-- 
1.7.1

[PATCH 04/12] xserver-kdrive-common/Xserver: fix EZX settings

[Antonio Ospite]

Support all EZX machines, and set up the mouse as a tslib device.

Signed-off-by: Antonio Ospite <ospite@studenti.unina.it>
---
 .../xserver-kdrive-common/Xserver                  |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/recipes/xserver-kdrive-common/xserver-kdrive-common/Xserver b/recipes/xserver-kdrive-common/xserver-kdrive-common/Xserver
index e2566bb..347b005 100644
--- a/recipes/xserver-kdrive-common/xserver-kdrive-common/Xserver
+++ b/recipes/xserver-kdrive-common/xserver-kdrive-common/Xserver
@@ -144,11 +144,12 @@ case `module_id` in
                      PPM="-root-ppm /usr/share/pixmaps/xsplash-qvga-square.ppm"
                 fi
                 ARGS="$ARGS -dpi 181 -screen 320x320 -mouse tslib -hide-cursor ${PPM}" ;;
-        "Motorola Ezx Platform")
+        "Motorola Ezx Platform" | \
+        "Motorola EZX"*)
                 if [ -f "/usr/share/pixmaps/xsplash-qvga.ppm" ]; then
                      PPM="-root-ppm /usr/share/pixmaps/xsplash-qvga.ppm ${PPM}"
                 fi
-                ARGS="$ARGS -dpi 170 -screen ${SCREEN_SIZE}" ;;
+                ARGS="$ARGS -dpi 170 -mouse tslib -hide-cursor -screen ${SCREEN_SIZE} ${PPM}" ;;
 	"Glofiish M800")
                 if [ -f "/usr/share/pixmaps/xsplash-vga.ppm" ]; then
                      PPM="-root-ppm /usr/share/pixmaps/xsplash-vga.ppm"
-- 
1.7.1

[PATCH 05/12] tslib: Add config file for a780 machine

[Antonio Ospite]

Signed-off-by: Antonio Ospite <ospite@studenti.unina.it>
---
 recipes/tslib/tslib/a780/tslib.sh |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)
 create mode 100755 recipes/tslib/tslib/a780/tslib.sh

diff --git a/recipes/tslib/tslib/a780/tslib.sh b/recipes/tslib/tslib/a780/tslib.sh
new file mode 100755
index 0000000..dd905fb
--- /dev/null
+++ b/recipes/tslib/tslib/a780/tslib.sh
@@ -0,0 +1,5 @@
+#!/bin/sh
+
+TSLIB_TSDEVICE=/dev/input/event2
+
+export TSLIB_TSDEVICE
-- 
1.7.1

[PATCH 06/12] motorola-ezx-base.inc: use PREFERRED_PROVIDER_virtual/xserver

[Antonio Ospite]

This fixes a "multiple recipes provide xserver" warning.

Signed-off-by: Antonio Ospite <ospite@studenti.unina.it>
---
 conf/machine/include/motorola-ezx-base.inc |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/conf/machine/include/motorola-ezx-base.inc b/conf/machine/include/motorola-ezx-base.inc
index 75c0f42..9ad2f14 100644
--- a/conf/machine/include/motorola-ezx-base.inc
+++ b/conf/machine/include/motorola-ezx-base.inc
@@ -1,6 +1,6 @@
 TARGET_ARCH = "arm"
 
-PREFERRED_PROVIDER_xserver = "xserver-kdrive"
+PREFERRED_PROVIDER_virtual/xserver = "xserver-kdrive"
 PREFERRED_PROVIDER_virtual/kernel ?= "openezx-kernel"
 
 #cat /proc/mtd
-- 
1.7.1

[PATCH 07/12] motorola-ezx-base.inc: refresh machine definition

[Antonio Ospite]

Reorder sections to a more logic scheme, following magician.conf, other
cleanups:

 * sort MACHINE_FEATURES alphabetically
 * add ezx-gen-blob to EXTRA_IMAGEDEPENDS
 * use MODUTILS=26
 * Add needed kernel modules for BP
 * get rid of udev

Signed-off-by: Antonio Ospite <ospite@studenti.unina.it>
---
 conf/machine/include/motorola-ezx-base.inc |   47 ++++++++++++++++++---------
 1 files changed, 31 insertions(+), 16 deletions(-)

diff --git a/conf/machine/include/motorola-ezx-base.inc b/conf/machine/include/motorola-ezx-base.inc
index 9ad2f14..792919c 100644
--- a/conf/machine/include/motorola-ezx-base.inc
+++ b/conf/machine/include/motorola-ezx-base.inc
@@ -1,7 +1,16 @@
+# use this for overrides
+MACHINE_CLASS = "motorola-ezx"
+
+#
+# Hardware-based properties
+#
 TARGET_ARCH = "arm"
 
-PREFERRED_PROVIDER_virtual/xserver = "xserver-kdrive"
-PREFERRED_PROVIDER_virtual/kernel ?= "openezx-kernel"
+# Use tune-xscale per default. Machine independent feeds should be built with tune-strongarm.
+require conf/machine/include/tune-xscale.inc
+
+# Uncomment this to use iwmmxt optimizations. Remove the above xscale stuff first
+#require conf/machine/include/tune-iwmmxt.inc
 
 #cat /proc/mtd
 #dev:    size   erasesize  name
@@ -10,34 +19,40 @@ PREFERRED_PROVIDER_virtual/kernel ?= "openezx-kernel"
 #mtd2: 00580000 00020000 "VFM_Filesystem"
 #mtd3: 00020000 00020000 "Logo"
 
-MACHINE_FEATURES = "kernel26 touchscreen apm alsa bluetooth usbgadget usbhost keyboard screen phone"
-MACHINE_FEATURES += " iwmmxt"
-
+ROOT_FLASH_SIZE = "24"
+MACHINE_GUI_CLASS = "smallscreen"
 MACHINE_DISPLAY_WIDTH_PIXELS = "240"
 MACHINE_DISPLAY_HEIGHT_PIXELS = "320"
 MACHINE_DISPLAY_ORIENTATION = "0"
 MACHINE_DISPLAY_PPI = "180"
+MACHINE_FEATURES = "alsa apm bluetooth kernel26 keyboard phone screen touchscreen usbgadget usbhost vfat"
+MACHINE_FEATURES += " iwmmxt"
 
-# use this for overrides
-MACHINE_CLASS = "motorola-ezx"
-
+#
+# Software/packages selection
+#
+PREFERRED_PROVIDER_virtual/kernel ?= "openezx-kernel"
+MODUTILS = "26"	
 XSERVER = "xserver-kdrive-fbdev"
-
-ROOT_FLASH_SIZE = "24"
+PREFERRED_PROVIDER_virtual/xserver = "xserver-kdrive"
 
 IMAGE_FSTYPES ?= "jffs2"
 EXTRA_IMAGECMD_jffs2 = "--pad=14680064 --little-endian --eraseblock=0x20000 -n"
 
-EXTRA_IMAGEDEPENDS += "ezx-boot-usb-native"
+EXTRA_IMAGEDEPENDS += "ezx-boot-usb-native ezx-gen-blob"
+
+IMAGE_INSTALL_append += "\
+  kernel-module-ohci-hcd \
+  kernel-module-moto-usb-ipc \
+  kernel-module-ts27010mux \
+"
 
-# the EZX phones need a userspace daemon to stop the BP from shutting down the phone
-MACHINE_ESSENTIAL_EXTRA_RDEPENDS += "ezxd"
+# We don't want udev, we rely on CONFIG_DEVTMPFS
+IMAGE_DEV_MANAGER = ""
+# TODO: remove ./etc/init.d/devices to actually have devtmpfs working
 
 # Ezxd needs to be started very early so we need the mux devices in static /dev
 IMAGE_DEVICE_TABLES = "files/device_table-minimal.txt \
                        files/device_table-ezx.txt"
 
-# Use tune-xscale per default. Machine independent feeds should be built with tune-strongarm.
-require conf/machine/include/tune-xscale.inc
-
 SERIAL_CONSOLE = "115200 ttyS0"
-- 
1.7.1

[PATCH 08/12] motorola-ezx-base.inc: Add support for ubifs

[Antonio Ospite]

From: Ilya Petrov <ilya.muromec@gmail.com>

Signed-off-by: Ilya Petrov <ilya.muromec@gmail.com>
Signed-off-by: Antonio Ospite <ospite@studenti.unina.it>
---
 conf/machine/include/motorola-ezx-base.inc |   17 +++++++++++++++++
 1 files changed, 17 insertions(+), 0 deletions(-)

diff --git a/conf/machine/include/motorola-ezx-base.inc b/conf/machine/include/motorola-ezx-base.inc
index 792919c..c90b327 100644
--- a/conf/machine/include/motorola-ezx-base.inc
+++ b/conf/machine/include/motorola-ezx-base.inc
@@ -39,6 +39,23 @@ PREFERRED_PROVIDER_virtual/xserver = "xserver-kdrive"
 IMAGE_FSTYPES ?= "jffs2"
 EXTRA_IMAGECMD_jffs2 = "--pad=14680064 --little-endian --eraseblock=0x20000 -n"
 
+# In order to enable UIBIFS add "uibi and ubifs" 
+#IMAGE_FSTYPES += "ubi ubifs"
+
+# From dmesg:
+# UBI: smallest flash I/O unit:    1
+# UBI: logical eraseblock size:    131072 bytes
+# from ubiattach stdout:
+# UBI device number 0, total 1996 LEBs
+MKUBIFS_ARGS = "-m 1 -e 130944 -c 487"
+
+# from dmesg:
+# UBI: smallest flash I/O unit:    1
+# UBI: physical eraseblock size:   131072 bytes (128 KiB)
+# UBI: sub-page size:              512
+UBINIZE_ARGS = "-m 1 -p 128KiB "
+
+
 EXTRA_IMAGEDEPENDS += "ezx-boot-usb-native ezx-gen-blob"
 
 IMAGE_INSTALL_append += "\
-- 
1.7.1

[PATCH 09/12] openezx-kernel_git: update recipe

[Antonio Ospite]

* bump KV
* bump SRCREV: The new version enables CONFIG_DEVTMPFS by default and
  some other stuff, and fixes usblan on gen2 when booting from MMC
* Provide a fallback CMDLINE
* Keep OABI config setting
* Use a -oe LOCALVERSION both in KV and in .config

Signed-off-by: Antonio Ospite <ospite@studenti.unina.it>
---
 recipes/linux/openezx-kernel_git.bb |   17 +++++++++++++----
 1 files changed, 13 insertions(+), 4 deletions(-)

diff --git a/recipes/linux/openezx-kernel_git.bb b/recipes/linux/openezx-kernel_git.bb
index 55461d1..76929e0 100644
--- a/recipes/linux/openezx-kernel_git.bb
+++ b/recipes/linux/openezx-kernel_git.bb
@@ -1,10 +1,10 @@
 DESCRIPTION = "OpenEZX 2.6 Linux Development Kernel for the Motorola EZX GSM phones"
 AUTHOR = "The OpenEZX Team <openezx-devel@lists.openezx.org>"
 HOMEPAGE = "http://www.openezx.org"
-SRCREV = "b390bb1ee708277297fdfd38e26d955b17d81c2e"
-KV = "2.6.33"
+SRCREV = "c485cc5953bbebdab1c52032754accca75031837"
+KV = "2.6.34-oe"
 PV = "${KV}+gitr${SRCREV}"
-PR = "r4"
+PR = "r5"
 
 require linux.inc
 
@@ -25,7 +25,10 @@ S = "${WORKDIR}/git"
 COMPATIBLE_HOST = "arm.*-linux"
 COMPATIBLE_MACHINE = '(a780|e680|a910|a1200|rorkre2|rokre6)'
 
-# The Kernel command line parameters are given via boot_usb or gen-blob
+# Provide a fallback kernel command line, even if parameters should be given
+# via boot_usb or gen-blob
+CMDLINE = "console=tty1 root=/dev/mmcblk0p2 rootfstype=ext2 rootdelay=3 ip=192.168.0.202:192.168.0.200:192.168.0.200:255.255.255.0"
+ARM_KEEP_OABI = "1"
 
 ###############################################################
 # module configs specific to this kernel
@@ -36,3 +39,9 @@ COMPATIBLE_MACHINE = '(a780|e680|a910|a1200|rorkre2|rokre6)'
 do_configure_prepend() {
 	install -m 0644 ${S}/arch/arm/configs/ezx_defconfig ${WORKDIR}/defconfig
 }
+
+# linux.inc overrides LOCAVERSION but we like to have one
+do_compile_prepend() {
+	sed -i -e '/CONFIG_LOCALVERSION=/d' ${S}/.config
+	echo 'CONFIG_LOCALVERSION="-oe"' >>${S}/.config
+}
-- 
1.7.1

[PATCH 10/12] ezx-gen-blob: bump SRCREV

[Antonio Ospite]

The new version can now be compiled with OE with no problems, previously
the size of the binary produced with the toolchain from OE was too big
to be flashed.

Signed-off-by: Antonio Ospite <ospite@studenti.unina.it>
---
 recipes/ezx/ezx-gen-blob_svn.bb |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/recipes/ezx/ezx-gen-blob_svn.bb b/recipes/ezx/ezx-gen-blob_svn.bb
index 9b56c24..39cec89 100644
--- a/recipes/ezx/ezx-gen-blob_svn.bb
+++ b/recipes/ezx/ezx-gen-blob_svn.bb
@@ -5,10 +5,10 @@ HOMEPAGE = "http://people.openezx.org/wyrm/gen-blob"
 LICENSE = "GPL"
 PROVIDES = "virtual/bootloader"
 DEPENDS = "virtual/kernel"
-SRCREV = "2517"
+SRCREV = "2519"
 PV = "1.0.0+svnr${SRCPV}"
 PE = "1"
-PR = "r1"
+PR = "r2"
 
 SRC_URI = "\
   svn://svn.openezx.org/trunk/src/blob/;module=gen-blob;proto=http \
-- 
1.7.1

[PATCH 11/12] ezx-boot-usb-native: bump SRCREV

[Antonio Ospite]

This newer revision fixes flashing to NOR.

Signed-off-by: Antonio Ospite <ospite@studenti.unina.it>
---
 recipes/ezx/ezx-boot-usb-native_svn.bb |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/recipes/ezx/ezx-boot-usb-native_svn.bb b/recipes/ezx/ezx-boot-usb-native_svn.bb
index 3e24c59..280de30 100644
--- a/recipes/ezx/ezx-boot-usb-native_svn.bb
+++ b/recipes/ezx/ezx-boot-usb-native_svn.bb
@@ -3,7 +3,7 @@ DEPENDS = "virtual/libusb0-native virtual/kernel"
 SECTION = "devel"
 AUTHOR = "Team OpenEZX <openezx-devel@lists.openezx.org>"
 LICENSE = "GPL"
-SRCREV = "2512"
+SRCREV = "2522"
 PV = "0.3.0+svnr${SRCPV}"
 
 SRC_URI = "svn://svn.openezx.org/trunk/src/host;module=boot_usb;proto=http" 
-- 
1.7.1

[PATCH 12/12] frameworkd_git.bb: bump SRCREV

[Antonio Ospite]

ogsmd has now some more reliable support for the Freescale Neptune modem
used in Motorola EzX phones.

Signed-off-by: Antonio Ospite <ospite@studenti.unina.it>
---
 recipes/freesmartphone/frameworkd_git.bb |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/recipes/freesmartphone/frameworkd_git.bb b/recipes/freesmartphone/frameworkd_git.bb
index 395a137..3d72d8f 100644
--- a/recipes/freesmartphone/frameworkd_git.bb
+++ b/recipes/freesmartphone/frameworkd_git.bb
@@ -4,9 +4,9 @@ AUTHOR = "FreeSmartphone.Org Development Team"
 SECTION = "console/network"
 DEPENDS = "python-cython-native python-pyrex-native"
 LICENSE = "GPL"
-SRCREV = "93673aa09cafc8fb5cfc3cb4055a73e25e595b70"
+SRCREV = "7ee718456af30a7ab1069c4fad0fd33be319c2c8"
 PV = "0.9.5.9+gitr${SRCPV}"
-PR = "r3"
+PR = "r4"
 PE = "1"
 
 inherit distutils update-rc.d python-dir
-- 
1.7.1

Re: [PATCH 00/12] motorola-ezx related changes

[Stefan Schmidt]

Hello.

On Mon, 2010-05-31 at 11:55, Antonio Ospite wrote:
> Hi, here's some motorola-ezx related changes, plus a couple of other fixes I
> am using here.
> Namely, the non ezx related changes are 01 and 02.
> 
> Can anyone review and apply, please?

I would prefer if you could push it yourself after the review. Therefor I
propose write-access for Antonio.

Over time he already did a lot patches for EZX, but was also willing to dig into
related problems and work on them until a solution was found. He also showed
good reactions on review comments and I think he is ready for write-access now.

regards
Stefan Schmidt

Re: [PATCH 07/12] motorola-ezx-base.inc: refresh machine definition

[Koen Kooi]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 31-05-10 11:55, Antonio Ospite wrote:

>  * get rid of udev

> +# We don't want udev, we rely on CONFIG_DEVTMPFS
> +IMAGE_DEV_MANAGER = ""

I most strongly disapprove of that. That var, as the name implies, is an
*image* var, not a machine var. With this change you are forcing an
image policy onto everyone. I have images that need udev, which
according to you I am not allowed to use on my a780.

If you don't want udev in your image, set IMAGE_DEV_MANAGER = "" in your
image, not in the machine.

rgards,

Koen
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)

iD8DBQFMA5rtMkyGM64RGpERApXlAKCD9mwKSMGztqgE4RSUOJJ/Ot0yKQCfZCPd
N5aXmhtYgT90BM8kEr9FQ1s=
=QeKp
-----END PGP SIGNATURE-----

Re: [PATCH 01/12] fso-image.inc: add an even shorter alias, for ls -l

[Koen Kooi]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 31-05-10 11:55, Antonio Ospite wrote:
> 'l' is a must have along with 'll'.
> 
> Signed-off-by: Antonio Ospite <ospite@studenti.unina.it>
> ---
>  recipes/images/fso-image.inc |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/recipes/images/fso-image.inc b/recipes/images/fso-image.inc
> index cc626f3..704d267 100644
> --- a/recipes/images/fso-image.inc
> +++ b/recipes/images/fso-image.inc
> @@ -110,6 +110,7 @@ fso_rootfs_postprocess() {
>      echo "alias fso='cd /local/pkg/fso'" >>./etc/profile
>      echo "alias ipkg='opkg'" >>./etc/profile
>      echo "alias vim=vi" >>./etc/profile
> +    echo "alias l='ls -l'" >>./etc/profile
>      echo "alias ll='ls -al'" >>./etc/profile
>      # nfs
>      mkdir -p ./local/pkg

And what happens if you opkg upgrade base-files? You suddenly lost all
your tweaks to /etc/profile.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)

iD8DBQFMA5tCMkyGM64RGpERAvTLAKCoiQEUoCu0JGj/uOrp7iyRxAMj6ACglhn0
PHnpQdgGf53SuA5JG1DDIiw=
=ZVr0
-----END PGP SIGNATURE-----

Re: [PATCH 00/12] motorola-ezx related changes

[Holger Freyther]

On 05/31/2010 06:20 PM, Stefan Schmidt wrote:


> Over time he already did a lot patches for EZX, but was also willing to dig into
> related problems and work on them until a solution was found. He also showed
> good reactions on review comments and I think he is ready for write-access now.


+1 for write review, and a little general reminder that review doesn't
remove the need for review.

Re: [PATCH 00/12] motorola-ezx related changes

[Dr. Michael Lauer]

Am 31.05.2010 um 12:20 schrieb Stefan Schmidt:

> Hello.
> 
> On Mon, 2010-05-31 at 11:55, Antonio Ospite wrote:
>> Hi, here's some motorola-ezx related changes, plus a couple of other fixes I
>> am using here.
>> Namely, the non ezx related changes are 01 and 02.
>> 
>> Can anyone review and apply, please?
> 
> I would prefer if you could push it yourself after the review. Therefor I
> propose write-access for Antonio.

+1.

Antonio, please send Cliff and me your SSH key.

:M:

Re: [PATCH 00/12] motorola-ezx related changes

[Antonio Ospite]

[-- Attachment #1: Type: text/plain, Size: 1110 bytes --]

On Mon, 31 May 2010 19:30:48 +0800
Holger Freyther <holger+oe@freyther.de> wrote:

> On 05/31/2010 06:20 PM, Stefan Schmidt wrote:
> 
> 
> > Over time he already did a lot patches for EZX, but was also willing to dig into
> > related problems and work on them until a solution was found. He also showed
> > good reactions on review comments and I think he is ready for write-access now.
> 
> 
> +1 for write review, and a little general reminder that review doesn't
> remove the need for review.
>

"_write access_ doesn't remove the need for review":
I can see that, on trivial motorola-ezx stuff (SRCREV bumps, for
instance) I guess I will commit directly, on anything else I am going to
send patches here some days before pushing, or until I get sufficient
ACKs.

Regards,
   Antonio

-- 
Antonio Ospite
http://ao2.it

PGP public key ID: 0x4553B001

A: Because it messes up the order in which people normally read text.
   See http://en.wikipedia.org/wiki/Posting_style
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?

[-- Attachment #2: Type: application/pgp-signature, Size: 205 bytes --]

Re: [PATCH 00/12] motorola-ezx related changes

[Holger Freyther]

On 05/31/2010 08:07 PM, Antonio Ospite wrote:

> "_write access_ doesn't remove the need for review":
> I can see that, on trivial motorola-ezx stuff (SRCREV bumps, for
> instance) I guess I will commit directly, on anything else I am going to
> send patches here some days before pushing, or until I get sufficient
> ACKs.

Thanks, and thank you for your work and many many patches.

Re: [PATCH 07/12] motorola-ezx-base.inc: refresh machine definition

[Antonio Ospite]

[-- Attachment #1: Type: text/plain, Size: 1243 bytes --]

On Mon, 31 May 2010 13:18:05 +0200
Koen Kooi <k.kooi@student.utwente.nl> wrote:

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> On 31-05-10 11:55, Antonio Ospite wrote:
> 
> >  * get rid of udev
> 
> > +# We don't want udev, we rely on CONFIG_DEVTMPFS
> > +IMAGE_DEV_MANAGER = ""
> 
> I most strongly disapprove of that. That var, as the name implies, is an
> *image* var, not a machine var. With this change you are forcing an
> image policy onto everyone. I have images that need udev, which
> according to you I am not allowed to use on my a780.
>

OK, I see your reasons, I am keeping this bit locally for now
then, and proposing it again as an image setting when I can find
some time to add proper support for different IMAGE_DEV_MANAGERs.

> If you don't want udev in your image, set IMAGE_DEV_MANAGER = "" in your
> image, not in the machine.
>

OK.

Thanks for commenting.

Regards,
   Antonio

-- 
Antonio Ospite
http://ao2.it

PGP public key ID: 0x4553B001

A: Because it messes up the order in which people normally read text.
   See http://en.wikipedia.org/wiki/Posting_style
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?

[-- Attachment #2: Type: application/pgp-signature, Size: 205 bytes --]

Re: [PATCH 00/12] motorola-ezx related changes

[Koen Kooi]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 31-05-10 11:55, Antonio Ospite wrote:
> Hi, here's some motorola-ezx related changes, plus a couple of other fixes I
> am using here.
> Namely, the non ezx related changes are 01 and 02.
> 
> Can anyone review and apply, please?

Feel free to add my ack to 2-6,8-12

regards,

Koen
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)

iD8DBQFMA8OXMkyGM64RGpERArrMAKC0KrYFsKKDV6/Z0Xldjvh5lWWP5QCeIr+u
SichgRR1yRm2FrxsArr6joI=
=vny4
-----END PGP SIGNATURE-----

[PATCH 07/12 v2] motorola-ezx-base.inc: refresh machine definition

[Antonio Ospite]

Reorder sections to a more logic scheme, following magician.conf, other
cleanups:

 * sort MACHINE_FEATURES alphabetically
 * add ezx-gen-blob to EXTRA_IMAGEDEPENDS
 * use MODUTILS=26
 * Add needed kernel modules for BP

Signed-off-by: Antonio Ospite <ospite@studenti.unina.it>
---

Changes since v1:

Drop the IMAGE_DEV_MANAGER = "" bit, as Koen remarked this belongs to
image not machine.

Regards,
   Antonio

 conf/machine/include/motorola-ezx-base.inc |   43 +++++++++++++++++----------
 1 files changed, 27 insertions(+), 16 deletions(-)

diff --git a/conf/machine/include/motorola-ezx-base.inc b/conf/machine/include/motorola-ezx-base.inc
index 9ad2f14..3fb42f4 100644
--- a/conf/machine/include/motorola-ezx-base.inc
+++ b/conf/machine/include/motorola-ezx-base.inc
@@ -1,7 +1,16 @@
+# use this for overrides
+MACHINE_CLASS = "motorola-ezx"
+
+#
+# Hardware-based properties
+#
 TARGET_ARCH = "arm"
 
-PREFERRED_PROVIDER_virtual/xserver = "xserver-kdrive"
-PREFERRED_PROVIDER_virtual/kernel ?= "openezx-kernel"
+# Use tune-xscale per default. Machine independent feeds should be built with tune-strongarm.
+require conf/machine/include/tune-xscale.inc
+
+# Uncomment this to use iwmmxt optimizations. Remove the above xscale stuff first
+#require conf/machine/include/tune-iwmmxt.inc
 
 #cat /proc/mtd
 #dev:    size   erasesize  name
@@ -10,34 +19,36 @@ PREFERRED_PROVIDER_virtual/kernel ?= "openezx-kernel"
 #mtd2: 00580000 00020000 "VFM_Filesystem"
 #mtd3: 00020000 00020000 "Logo"
 
-MACHINE_FEATURES = "kernel26 touchscreen apm alsa bluetooth usbgadget usbhost keyboard screen phone"
-MACHINE_FEATURES += " iwmmxt"
-
+ROOT_FLASH_SIZE = "24"
+MACHINE_GUI_CLASS = "smallscreen"
 MACHINE_DISPLAY_WIDTH_PIXELS = "240"
 MACHINE_DISPLAY_HEIGHT_PIXELS = "320"
 MACHINE_DISPLAY_ORIENTATION = "0"
 MACHINE_DISPLAY_PPI = "180"
+MACHINE_FEATURES = "alsa apm bluetooth kernel26 keyboard phone screen touchscreen usbgadget usbhost vfat"
+MACHINE_FEATURES += " iwmmxt"
 
-# use this for overrides
-MACHINE_CLASS = "motorola-ezx"
-
+#
+# Software/packages selection
+#
+PREFERRED_PROVIDER_virtual/kernel ?= "openezx-kernel"
+MODUTILS = "26"	
 XSERVER = "xserver-kdrive-fbdev"
-
-ROOT_FLASH_SIZE = "24"
+PREFERRED_PROVIDER_virtual/xserver = "xserver-kdrive"
 
 IMAGE_FSTYPES ?= "jffs2"
 EXTRA_IMAGECMD_jffs2 = "--pad=14680064 --little-endian --eraseblock=0x20000 -n"
 
-EXTRA_IMAGEDEPENDS += "ezx-boot-usb-native"
+EXTRA_IMAGEDEPENDS += "ezx-boot-usb-native ezx-gen-blob"
 
-# the EZX phones need a userspace daemon to stop the BP from shutting down the phone
-MACHINE_ESSENTIAL_EXTRA_RDEPENDS += "ezxd"
+IMAGE_INSTALL_append += "\
+  kernel-module-ohci-hcd \
+  kernel-module-moto-usb-ipc \
+  kernel-module-ts27010mux \
+"
 
 # Ezxd needs to be started very early so we need the mux devices in static /dev
 IMAGE_DEVICE_TABLES = "files/device_table-minimal.txt \
                        files/device_table-ezx.txt"
 
-# Use tune-xscale per default. Machine independent feeds should be built with tune-strongarm.
-require conf/machine/include/tune-xscale.inc
-
 SERIAL_CONSOLE = "115200 ttyS0"
-- 
1.7.1

Re: [PATCH 00/12] motorola-ezx related changes

[Antonio Ospite]

[-- Attachment #1: Type: text/plain, Size: 1001 bytes --]

On Mon, 31 May 2010 16:11:36 +0200
Koen Kooi <k.kooi@student.utwente.nl> wrote:

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> On 31-05-10 11:55, Antonio Ospite wrote:
> > Hi, here's some motorola-ezx related changes, plus a couple of other fixes I
> > am using here.
> > Namely, the non ezx related changes are 01 and 02.
> > 
> > Can anyone review and apply, please?
> 
> Feel free to add my ack to 2-6,8-12
> 

Thanks Koen, I sent a v2 for patch 07, which skips the IMAGE_DEV_MANAGER
change.

Let me know if that is acceptable now.

Next time could you please use a ACKed-by line which I can copy and
paste? This will save some seconds.

Thanks a lot,
   Antonio

-- 
Antonio Ospite
http://ao2.it

PGP public key ID: 0x4553B001

A: Because it messes up the order in which people normally read text.
   See http://en.wikipedia.org/wiki/Posting_style
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?

[-- Attachment #2: Type: application/pgp-signature, Size: 205 bytes --]

Re: [PATCH 07/12 v2] motorola-ezx-base.inc: refresh machine definition

[Antonio Ospite]

[-- Attachment #1: Type: text/plain, Size: 1196 bytes --]

On Mon, 31 May 2010 18:32:34 +0200
Koen Kooi <k.kooi@student.utwente.nl> wrote:

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> On 31-05-10 16:28, Antonio Ospite wrote:
> > Reorder sections to a more logic scheme, following magician.conf, other
> > cleanups:
> > 
> >  * sort MACHINE_FEATURES alphabetically
> >  * add ezx-gen-blob to EXTRA_IMAGEDEPENDS
> >  * use MODUTILS=26
> >  * Add needed kernel modules for BP
> > 
> > Signed-off-by: Antonio Ospite <ospite@studenti.unina.it>
> 
> Acked-by: Koen Kooi <koen@openembedded.org>
> 

Thanks Koen, btw, trying "git am" om my own patches before pushing I've
found some whitepsace issues, I'll fix these, no semantic changes, but
I just wanted to point out that the changes I am going to push are not
_exactly_ the same I sent here for review.

Is there anything like checkpatch.pl for OE?

Thanks,
   Antonio

-- 
Antonio Ospite
http://ao2.it

PGP public key ID: 0x4553B001

A: Because it messes up the order in which people normally read text.
   See http://en.wikipedia.org/wiki/Posting_style
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?

[-- Attachment #2: Type: application/pgp-signature, Size: 205 bytes --]

Re: [PATCH 01/12] fso-image.inc: add an even shorter alias, for ls -l

[Antonio Ospite]

[-- Attachment #1: Type: text/plain, Size: 1312 bytes --]

On Mon, 31 May 2010 13:19:30 +0200
Koen Kooi <k.kooi@student.utwente.nl> wrote:

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> On 31-05-10 11:55, Antonio Ospite wrote:
> > 'l' is a must have along with 'll'.
> > 
> > Signed-off-by: Antonio Ospite <ospite@studenti.unina.it>
[...]
> diff --git a/recipes/images/fso-image.inc b/recipes/images/fso-image.inc
[...]
> > +    echo "alias l='ls -l'" >>./etc/profile
> >      echo "alias ll='ls -al'" >>./etc/profile
> >      # nfs
> >      mkdir -p ./local/pkg
> 
> And what happens if you opkg upgrade base-files? You suddenly lost all
> your tweaks to /etc/profile.

Right, /etc/profile would be overwritten, but that's quite independent
from this very patch, it's the whole fso-image.inc approach which
should be revised, so I'd like this one could still make it.

Or if you can point to the right way to do what
recipes/images/fso-image.inc::fso_rootfs_postprocess() is doing I can
try to implement that.

Thanks,
   Antonio

-- 
Antonio Ospite
http://ao2.it

PGP public key ID: 0x4553B001

A: Because it messes up the order in which people normally read text.
   See http://en.wikipedia.org/wiki/Posting_style
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?

[-- Attachment #2: Type: application/pgp-signature, Size: 205 bytes --]

Re: [PATCH 01/12] fso-image.inc: add an even shorter alias, for ls -l

[Martin Jansa]

On Mon, Jun 07, 2010 at 09:24:54AM +0200, Antonio Ospite wrote:
> On Mon, 31 May 2010 13:19:30 +0200
> Koen Kooi <k.kooi@student.utwente.nl> wrote:
> 
> > -----BEGIN PGP SIGNED MESSAGE-----
> > Hash: SHA1
> > 
> > On 31-05-10 11:55, Antonio Ospite wrote:
> > > 'l' is a must have along with 'll'.
> > > 
> > > Signed-off-by: Antonio Ospite <ospite@studenti.unina.it>
> [...]
> > diff --git a/recipes/images/fso-image.inc b/recipes/images/fso-image.inc
> [...]
> > > +    echo "alias l='ls -l'" >>./etc/profile
> > >      echo "alias ll='ls -al'" >>./etc/profile
> > >      # nfs
> > >      mkdir -p ./local/pkg
> > 
> > And what happens if you opkg upgrade base-files? You suddenly lost all
> > your tweaks to /etc/profile.
> 
> Right, /etc/profile would be overwritten, but that's quite independent
> from this very patch, it's the whole fso-image.inc approach which
> should be revised, so I'd like this one could still make it.
> 
> Or if you can point to the right way to do what
> recipes/images/fso-image.inc::fso_rootfs_postprocess() is doing I can
> try to implement that.

Apply those changes in base-files recipe.

If you send it as RFC to list than maybe it will be OK for everyone,
otherwise you can apply it with distro override or something.

Maybe those profile tweaks should be in user profile instead of system
profile? Someone noticed that xserver-common Xsession script is using
only "ls" to list Xsession.d scripts and then later fails if profile has
alias ls="ls --color"...

FYI: I removed similar postprocess tweaks from shr images about a month
ago, because of those reasons...

Regards,

-- 
Jansa 'JaMa' Martin     jabber: Martin.Jansa@gmail.com

Re: [PATCH 01/12] fso-image.inc: add an even shorter alias, for ls -l

[Koen Kooi]

Op 7 jun 2010, om 09:50 heeft Martin Jansa het volgende geschreven:

> On Mon, Jun 07, 2010 at 09:24:54AM +0200, Antonio Ospite wrote:
>> On Mon, 31 May 2010 13:19:30 +0200
>> Koen Kooi <k.kooi@student.utwente.nl> wrote:
>> 
>>> -----BEGIN PGP SIGNED MESSAGE-----
>>> Hash: SHA1
>>> 
>>> On 31-05-10 11:55, Antonio Ospite wrote:
>>>> 'l' is a must have along with 'll'.
>>>> 
>>>> Signed-off-by: Antonio Ospite <ospite@studenti.unina.it>
>> [...]
>>> diff --git a/recipes/images/fso-image.inc b/recipes/images/fso-image.inc
>> [...]
>>>> +    echo "alias l='ls -l'" >>./etc/profile
>>>>     echo "alias ll='ls -al'" >>./etc/profile
>>>>     # nfs
>>>>     mkdir -p ./local/pkg
>>> 
>>> And what happens if you opkg upgrade base-files? You suddenly lost all
>>> your tweaks to /etc/profile.
>> 
>> Right, /etc/profile would be overwritten, but that's quite independent
>> from this very patch, it's the whole fso-image.inc approach which
>> should be revised, so I'd like this one could still make it.
>> 
>> Or if you can point to the right way to do what
>> recipes/images/fso-image.inc::fso_rootfs_postprocess() is doing I can
>> try to implement that.

<snip>

> FYI: I removed similar postprocess tweaks from shr images about a month
> ago, because of those reasons...

I removed them when I started developing narcissus (late 2008), since I couldn't reproduce OE images from their packages...

regards,

Koen