[PATCH] sane-toolchain.inc: FEED_ARCH should be prepended to OVERRIDES

[PATCH] sane-toolchain.inc: FEED_ARCH should be prepended to OVERRIDES

[Khem Raj]

Currently it ends up after local override and hence appears first in FILESPATH
and for buiding uclibc_git.bb on qemuarm it picks wrong uClibc.machine file from
uclibc-git/armv5te where as it should have picked from uclibc-git/qemuarm

Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
 conf/distro/include/sane-toolchain.inc |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/conf/distro/include/sane-toolchain.inc b/conf/distro/include/sane-toolchain.inc
index 6802eb2..f5ca22b 100644
--- a/conf/distro/include/sane-toolchain.inc
+++ b/conf/distro/include/sane-toolchain.inc
@@ -75,7 +75,7 @@ require conf/distro/include/toolchain-${TOOLCHAIN_TYPE}.inc
 # Add FEED_ARCH to the overrides list so that we can override the
 # ARM_INSTRUCTION_SET like below
 
-OVERRIDES .= ":${FEED_ARCH}"
+OVERRIDES =. "${FEED_ARCH}:"
 
 # ARM920T and up can use thumb mode to decrease binary size at the expense of speed
 # (the complete story is a bit more nuanced due to cache starvation)
-- 
1.7.0.4

Re: [PATCH] sane-toolchain.inc: FEED_ARCH should be prepended to OVERRIDES

[Koen Kooi]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 22-12-10 07:25, Khem Raj wrote:
> Currently it ends up after local override and hence appears first in FILESPATH
> and for buiding uclibc_git.bb on qemuarm it picks wrong uClibc.machine file from
> uclibc-git/armv5te where as it should have picked from uclibc-git/qemuarm
> 
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
>  conf/distro/include/sane-toolchain.inc |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/conf/distro/include/sane-toolchain.inc b/conf/distro/include/sane-toolchain.inc
> index 6802eb2..f5ca22b 100644
> --- a/conf/distro/include/sane-toolchain.inc
> +++ b/conf/distro/include/sane-toolchain.inc
> @@ -75,7 +75,7 @@ require conf/distro/include/toolchain-${TOOLCHAIN_TYPE}.inc
>  # Add FEED_ARCH to the overrides list so that we can override the
>  # ARM_INSTRUCTION_SET like below
>  
> -OVERRIDES .= ":${FEED_ARCH}"
> +OVERRIDES =. "${FEED_ARCH}:"
>  
>  # ARM920T and up can use thumb mode to decrease binary size at the expense of speed
>  # (the complete story is a bit more nuanced due to cache starvation)

Shouldn't that be BASE_PACKAGE_ARCH nowadays?
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)

iD8DBQFNEbe6MkyGM64RGpERAnMHAJ9x+kBJeouJPeVMJxQlgWNzTK05sACfSFur
ckz3MaEHqpx3h9rPdo9pKn8=
=xnMX
-----END PGP SIGNATURE-----

Re: [PATCH] sane-toolchain.inc: FEED_ARCH should be prepended to OVERRIDES

[Khem Raj]

On Wed, Dec 22, 2010 at 12:32 AM, Koen Kooi <k.kooi@student.utwente.nl> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On 22-12-10 07:25, Khem Raj wrote:
>> Currently it ends up after local override and hence appears first in FILESPATH
>> and for buiding uclibc_git.bb on qemuarm it picks wrong uClibc.machine file from
>> uclibc-git/armv5te where as it should have picked from uclibc-git/qemuarm
>>
>> Signed-off-by: Khem Raj <raj.khem@gmail.com>
>> ---
>>  conf/distro/include/sane-toolchain.inc |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/conf/distro/include/sane-toolchain.inc b/conf/distro/include/sane-toolchain.inc
>> index 6802eb2..f5ca22b 100644
>> --- a/conf/distro/include/sane-toolchain.inc
>> +++ b/conf/distro/include/sane-toolchain.inc
>> @@ -75,7 +75,7 @@ require conf/distro/include/toolchain-${TOOLCHAIN_TYPE}.inc
>>  # Add FEED_ARCH to the overrides list so that we can override the
>>  # ARM_INSTRUCTION_SET like below
>>
>> -OVERRIDES .= ":${FEED_ARCH}"
>> +OVERRIDES =. "${FEED_ARCH}:"
>>
>>  # ARM920T and up can use thumb mode to decrease binary size at the expense of speed
>>  # (the complete story is a bit more nuanced due to cache starvation)
>
> Shouldn't that be BASE_PACKAGE_ARCH nowadays?

logically yes. I think I will change it to BASE_PACKAGE_ARCH