[[meta-oe][PATCH 0/3] Pending fixes in O.S. Systems tree

[[meta-oe][PATCH 0/3] Pending fixes in O.S. Systems tree

[Otavio Salvador]

The following changes since commit 797fc635c1a693abb07392a22e0b001bc331f633:

  gvfs: the sftp plugin only works with openssh-ssh (2011-06-13 20:20:15 +0200)

are available in the git repository at:
  git://github.com/OSSystems/meta-oe master
  https://github.com/OSSystems/meta-oe/tree/master

Otavio Salvador (3):
  xf86-video-geode: add 2.11.12 version recipe
  freerdp: bump SRCREV to gather fixes
  freerdp-extension-xpunlimited: bump SRCREV due library renaming

 .../xorg-driver/xf86-video-geode_2.11.12.bb        |   11 +++++++++++
 .../freerdp/freerdp-extension-xpunlimited_git.bb   |    2 +-
 meta-oe/recipes-support/freerdp/freerdp_git.bb     |    2 +-
 3 files changed, 13 insertions(+), 2 deletions(-)
 create mode 100644 meta-oe/recipes-graphics/xorg-driver/xf86-video-geode_2.11.12.bb

-- 
1.7.2.5

[[meta-oe][PATCH 1/3] xf86-video-geode: add 2.11.12 version recipe

[Otavio Salvador]

Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
---
 .../xorg-driver/xf86-video-geode_2.11.12.bb        |   11 +++++++++++
 1 files changed, 11 insertions(+), 0 deletions(-)
 create mode 100644 meta-oe/recipes-graphics/xorg-driver/xf86-video-geode_2.11.12.bb

diff --git a/meta-oe/recipes-graphics/xorg-driver/xf86-video-geode_2.11.12.bb b/meta-oe/recipes-graphics/xorg-driver/xf86-video-geode_2.11.12.bb
new file mode 100644
index 0000000..d14d63e
--- /dev/null
+++ b/meta-oe/recipes-graphics/xorg-driver/xf86-video-geode_2.11.12.bb
@@ -0,0 +1,11 @@
+require xorg-driver-video.inc
+LIC_FILES_CHKSUM = "file://COPYING;md5=f8ad89d9d9a024f19d7dcc5acb044a42"
+
+DESCRIPTION = "X.org server -- Geode GX2/LX display driver"
+PE = "1"
+PR = "${INC_PR}.0"
+
+SRC_URI[md5sum] = "a99c521db731c2f1df309057a8465e4c"
+SRC_URI[sha256sum] = "28d845d727d99bfa4d4b93c5486ec01b72eb222e0910a766089db1103b1c2d92"
+
+COMPATIBLE_HOST = "i.86.*-linux"
-- 
1.7.2.5

Re: [[meta-oe][PATCH 1/3] xf86-video-geode: add 2.11.12 version recipe

[Paul Menzel]

[-- Attachment #1: Type: text/plain, Size: 1676 bytes --]

Dear Otavio,


Am Dienstag, den 14.06.2011, 16:49 +0000 schrieb Otavio Salvador:

1. You could leave out recipe from the commit summary.

»Add version 2.11.12« should suffice.

2. Please add the necessary information to the commit message as
recommended in the commit message guidelines [1].

As far as I can see you imported this recipe from oe.dev.

> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> ---
>  .../xorg-driver/xf86-video-geode_2.11.12.bb        |   11 +++++++++++
>  1 files changed, 11 insertions(+), 0 deletions(-)
>  create mode 100644 meta-oe/recipes-graphics/xorg-driver/xf86-video-geode_2.11.12.bb
> 
> diff --git a/meta-oe/recipes-graphics/xorg-driver/xf86-video-geode_2.11.12.bb b/meta-oe/recipes-graphics/xorg-driver/xf86-video-geode_2.11.12.bb
> new file mode 100644
> index 0000000..d14d63e
> --- /dev/null
> +++ b/meta-oe/recipes-graphics/xorg-driver/xf86-video-geode_2.11.12.bb
> @@ -0,0 +1,11 @@
> +require xorg-driver-video.inc
> +LIC_FILES_CHKSUM = "file://COPYING;md5=f8ad89d9d9a024f19d7dcc5acb044a42"
> +
> +DESCRIPTION = "X.org server -- Geode GX2/LX display driver"
> +PE = "1"

Why is that needed? There are not colons in the version nor did the
versioning mess up [2] since it is an import.

> +PR = "${INC_PR}.0"
> +
> +SRC_URI[md5sum] = "a99c521db731c2f1df309057a8465e4c"
> +SRC_URI[sha256sum] = "28d845d727d99bfa4d4b93c5486ec01b72eb222e0910a766089db1103b1c2d92"
> +
> +COMPATIBLE_HOST = "i.86.*-linux"


Thanks,

Paul


[1] http://wiki.openembedded.org/index.php/Commit_Patch_Message_Guidelines
[2] http://www.debian.org/doc/debian-policy/ch-controlfields.html#s-f-Version

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

Re: [[meta-oe][PATCH 1/3] xf86-video-geode: add 2.11.12 version recipe

[Otavio Salvador]

On Wed, Jun 15, 2011 at 09:57, Paul Menzel
<paulepanter@users.sourceforge.net> wrote:
> 2. Please add the necessary information to the commit message as
> recommended in the commit message guidelines [1].
>
> As far as I can see you imported this recipe from oe.dev.

In fact no ... it is based on an old version from OE that I changes to
look like we're using today.

But AFAIK it is on Koen queue already so too late to change.

-- 
Otavio Salvador                             O.S. Systems
E-mail: otavio@ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br

Re: [[meta-oe][PATCH 1/3] xf86-video-geode: add 2.11.12 version recipe

[Paul Menzel]

[-- Attachment #1: Type: text/plain, Size: 703 bytes --]

Am Mittwoch, den 15.06.2011, 12:22 +0000 schrieb Otavio Salvador:
> On Wed, Jun 15, 2011 at 09:57, Paul Menzel wrote:
> > 2. Please add the necessary information to the commit message as
> > recommended in the commit message guidelines [1].
> >
> > As far as I can see you imported this recipe from oe.dev.
> 
> In fact no ... it is based on an old version from OE that I changes to
> look like we're using today.

So you just changed the checksums and added the `LICENSE` field?

Could also please answer why setting `PE` is needed.

> But AFAIK it is on Koen queue already so too late to change.

Koen has not pushed them yet so it is not too late in my opinion.


Thanks,

Paul

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

Re: [[meta-oe][PATCH 1/3] xf86-video-geode: add 2.11.12 version recipe

[Otavio Salvador]

On Wed, Jun 15, 2011 at 12:34, Paul Menzel
<paulepanter@users.sourceforge.net> wrote:
>> In fact no ... it is based on an old version from OE that I changes to
>> look like we're using today.
>
> So you just changed the checksums and added the `LICENSE` field?

I don't recall exactly what I did but I guess so.

> Could also please answer why setting `PE` is needed.

It had it already IIRC.

>> But AFAIK it is on Koen queue already so too late to change.
>
> Koen has not pushed them yet so it is not too late in my opinion.

I asked him to drop it and wait for a new version.

-- 
Otavio Salvador                             O.S. Systems
E-mail: otavio@ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br

Re: [[meta-oe][PATCH 1/3] xf86-video-geode: add 2.11.12 version recipe

[Koen Kooi]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 15-06-11 14:59, Otavio Salvador wrote:
> On Wed, Jun 15, 2011 at 12:34, Paul Menzel
> <paulepanter@users.sourceforge.net> wrote:
>>> In fact no ... it is based on an old version from OE that I changes to
>>> look like we're using today.
>>
>> So you just changed the checksums and added the `LICENSE` field?
> 
> I don't recall exactly what I did but I guess so.
> 
>> Could also please answer why setting `PE` is needed.
> 
> It had it already IIRC.

Historical reasons, it's from the x11r6 -> x11r7 -> 1.0 transitions.
I've been silently dropping them when adding X recipes to meta-oe

>>> But AFAIK it is on Koen queue already so too late to change.
>>
>> Koen has not pushed them yet so it is not too late in my opinion.
> 
> I asked him to drop it and wait for a new version.

Done

regards,

Koen

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)

iD8DBQFN+K8SMkyGM64RGpERAhvUAJ9X3VZqVqEEScWwS9Z0QfStYDWWZQCfel3u
KGvvI5FMR58T1O1jm/NGqag=
=klWr
-----END PGP SIGNATURE-----

Re: [[meta-oe][PATCH 1/3] xf86-video-geode: add 2.11.12 version recipe

[Otavio Salvador]

On Wed, Jun 15, 2011 at 13:09, Koen Kooi <koen@dominion.thruhere.net> wrote:
>>> Could also please answer why setting `PE` is needed.
>>
>> It had it already IIRC.
>
> Historical reasons, it's from the x11r6 -> x11r7 -> 1.0 transitions.
> I've been silently dropping them when adding X recipes to meta-oe

Ok; I will drop it here then.

-- 
Otavio Salvador                             O.S. Systems
E-mail: otavio@ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br

[[meta-oe][PATCH 2/3] freerdp: bump SRCREV to gather fixes

[Otavio Salvador]

This new version has many major refactorings that will be available on
0.9.0 release but the main fix is related to serial port redirection
that has got many fixes and improvements.

Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
---
 meta-oe/recipes-support/freerdp/freerdp_git.bb |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/meta-oe/recipes-support/freerdp/freerdp_git.bb b/meta-oe/recipes-support/freerdp/freerdp_git.bb
index a5f158a..a3f4a03 100644
--- a/meta-oe/recipes-support/freerdp/freerdp_git.bb
+++ b/meta-oe/recipes-support/freerdp/freerdp_git.bb
@@ -9,7 +9,7 @@ PV = "gitr${SRCPV}"
 PKGV = "${GITPKGVTAG}"
 PR = "${INC_PR}.2"
 
-SRCREV = "dd759622a097474114ce425021ef52d0aa5d3957"
+SRCREV = "d1eef40acc994d85cb78c0a98914edc097c9b44d"
 SRC_URI = "git://github.com/FreeRDP/FreeRDP.git;protocol=git"
 
 S = "${WORKDIR}/git"
-- 
1.7.2.5

[[meta-oe][PATCH 3/3] freerdp-extension-xpunlimited: bump SRCREV due library renaming

[Otavio Salvador]

Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
---
 .../freerdp/freerdp-extension-xpunlimited_git.bb   |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/meta-oe/recipes-support/freerdp/freerdp-extension-xpunlimited_git.bb b/meta-oe/recipes-support/freerdp/freerdp-extension-xpunlimited_git.bb
index 4fc6928..c9721f4 100644
--- a/meta-oe/recipes-support/freerdp/freerdp-extension-xpunlimited_git.bb
+++ b/meta-oe/recipes-support/freerdp/freerdp-extension-xpunlimited_git.bb
@@ -14,7 +14,7 @@ PR = "r0"
 
 inherit pkgconfig cmake
 
-SRCREV = "d27f90a0128c687ce74cc922dba8b7eeb33f0654"
+SRCREV = "e952627ff4c116b4ce8541c91cb96bd5422c4a0d"
 SRC_URI = "git://github.com/OSSystems/FreeRDP-Extension-XPUnlimited.git;protocol=git"
 
 S = "${WORKDIR}/git"
-- 
1.7.2.5

Re: [[meta-oe][PATCH 3/3] freerdp-extension-xpunlimited: bump SRCREV due library renaming

[Paul Menzel]

[-- Attachment #1: Type: text/plain, Size: 1226 bytes --]

Dear Otavio,


Am Dienstag, den 14.06.2011, 16:49 +0000 schrieb Otavio Salvador:

nitpick: I think it is due *to*.

Additionally it would be nice, if you could be more elaborate what
library was renamed. An URL would be good enough.

Additionally in my opinion it would be great if you could add a short
note what build configuration you used for testing.

> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> ---
>  .../freerdp/freerdp-extension-xpunlimited_git.bb   |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/meta-oe/recipes-support/freerdp/freerdp-extension-xpunlimited_git.bb b/meta-oe/recipes-support/freerdp/freerdp-extension-xpunlimited_git.bb
> index 4fc6928..c9721f4 100644
> --- a/meta-oe/recipes-support/freerdp/freerdp-extension-xpunlimited_git.bb
> +++ b/meta-oe/recipes-support/freerdp/freerdp-extension-xpunlimited_git.bb
> @@ -14,7 +14,7 @@ PR = "r0"
>  
>  inherit pkgconfig cmake
>  
> -SRCREV = "d27f90a0128c687ce74cc922dba8b7eeb33f0654"
> +SRCREV = "e952627ff4c116b4ce8541c91cb96bd5422c4a0d"
>  SRC_URI = "git://github.com/OSSystems/FreeRDP-Extension-XPUnlimited.git;protocol=git"
>  
>  S = "${WORKDIR}/git"


Thanks,

Paul

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

Re: [[meta-oe][PATCH 3/3] freerdp-extension-xpunlimited: bump SRCREV due library renaming

[Otavio Salvador]

On Wed, Jun 15, 2011 at 10:00, Paul Menzel
<paulepanter@users.sourceforge.net> wrote:
> nitpick: I think it is due *to*.

AFAIK Koen has already put it on his queue.

> Additionally it would be nice, if you could be more elaborate what
> library was renamed. An URL would be good enough.

FreeRDP has not a big refactoring and thus libfreerdp has been renamed
to libfreerdp-core.

> Additionally in my opinion it would be great if you could add a short
> note what build configuration you used for testing.

I don't see this on commit messages comming to the ml; why is it need
for this case?

-- 
Otavio Salvador                             O.S. Systems
E-mail: otavio@ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br

Re: [[meta-oe][PATCH 3/3] freerdp-extension-xpunlimited: bump SRCREV due library renaming

[Koen Kooi]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 15-06-11 14:18, Otavio Salvador wrote:
> On Wed, Jun 15, 2011 at 10:00, Paul Menzel
> <paulepanter@users.sourceforge.net> wrote:
>> nitpick: I think it is due *to*.
> 
> AFAIK Koen has already put it on his queue.

I haven't pushed it yet since there were other problems getting in the
way of build testing, so feel free to update your branch :)
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)

iD8DBQFN+KapMkyGM64RGpERAmAHAJ4qZsIZO3n9cYB6WHiR3T2zQfAalwCeKRaT
gt47A70Zqm+eZ6l4WzOAUVI=
=hS3g
-----END PGP SIGNATURE-----

Re: [[meta-oe][PATCH 3/3] freerdp-extension-xpunlimited: bump SRCREV due library renaming

[Otavio Salvador]

On Wed, Jun 15, 2011 at 12:33, Koen Kooi <koen@dominion.thruhere.net> wrote:
> I haven't pushed it yet since there were other problems getting in the
> way of build testing, so feel free to update your branch :)

Please drop those 3 patches then. I will resend them on the end of
week or when I have more fixes. They're not urgent.

I fixed them locally already.

-- 
Otavio Salvador                             O.S. Systems
E-mail: otavio@ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br

Re: [[meta-oe][PATCH 3/3] freerdp-extension-xpunlimited: bump SRCREV due library renaming

[Paul Menzel]

[-- Attachment #1: Type: text/plain, Size: 989 bytes --]

Am Mittwoch, den 15.06.2011, 12:18 +0000 schrieb Otavio Salvador:
> On Wed, Jun 15, 2011 at 10:00, Paul Menzel
> <paulepanter@users.sourceforge.net> wrote:
> > nitpick: I think it is due *to*.
> 
> AFAIK Koen has already put it on his queue.

But he has not pushed them yet.

> > Additionally it would be nice, if you could be more elaborate what
> > library was renamed. An URL would be good enough.
> 
> FreeRDP has not a big refactoring and thus libfreerdp has been renamed
> to libfreerdp-core.

Thank you.

> > Additionally in my opinion it would be great if you could add a short
> > note what build configuration you used for testing.
> 
> I don't see this on commit messages comming to the ml; why is it need
> for this case?

It is not required. But I had enough cases where I had (build) problems
with commits and it would have saved me time to be able to reproduce a
successful build. That is why I ask for it when I do reviews.


Thanks,

Paul


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

Re: [[meta-oe][PATCH 0/3] Pending fixes in O.S. Systems tree

[Koen Kooi]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 14-06-11 18:49, Otavio Salvador wrote:
> The following changes since commit 797fc635c1a693abb07392a22e0b001bc331f633:
> 
>   gvfs: the sftp plugin only works with openssh-ssh (2011-06-13 20:20:15 +0200)
> 
> are available in the git repository at:
>   git://github.com/OSSystems/meta-oe master
>   https://github.com/OSSystems/meta-oe/tree/master
> 
> Otavio Salvador (3):
>   xf86-video-geode: add 2.11.12 version recipe
>   freerdp: bump SRCREV to gather fixes
>   freerdp-extension-xpunlimited: bump SRCREV due library renaming

I have queued all three and will push them out after I build test them,
which has hit a snag in eglibc patching today.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)

iD8DBQFN95cGMkyGM64RGpERAgqDAJ9IGRny1bN8fDB8LtX6sloHR4nDuQCgphMl
Qb9c+++fpPxaKurpRIxdtGE=
=hPln
-----END PGP SIGNATURE-----