* [PATCH] lxdm: fix postinst-code
@ 2013-04-24 15:21 Andreas Müller
2013-04-26 7:50 ` Andreas Müller
0 siblings, 1 reply; 6+ messages in thread
From: Andreas Müller @ 2013-04-24 15:21 UTC (permalink / raw)
To: openembedded-devel
Exiting postinst code leaves systemd.bbclass offline postinst code unexecuted,
causes postinst not to finish at first boot (lxdm.service is not aliased to
display-manager.service -> started much too early) and is not neccesary:
language preparation can be done offline.
Signed-off-by: Andreas Müller <schnitzeltony@googlemail.com>
---
meta-oe/recipes-graphics/lxdm/lxdm_git.bb | 21 +++++++++------------
1 files changed, 9 insertions(+), 12 deletions(-)
diff --git a/meta-oe/recipes-graphics/lxdm/lxdm_git.bb b/meta-oe/recipes-graphics/lxdm/lxdm_git.bb
index a24f75c..6675691 100644
--- a/meta-oe/recipes-graphics/lxdm/lxdm_git.bb
+++ b/meta-oe/recipes-graphics/lxdm/lxdm_git.bb
@@ -15,7 +15,7 @@ LXDM_PAM = "${@base_contains("DISTRO_TYPE", "debug", "lxdm-pam-debug", "lxdm-pam
SRCREV = "65e7cc8fdc150c2b925eb348ce82de17dee5eb0b"
PV = "0.4.2+git${SRCPV}"
PE = "1"
-PR = "r6"
+PR = "r7"
DEPENDS = "cairo consolekit dbus gdk-pixbuf glib-2.0 gtk+ virtual/libx11 libxcb pango"
@@ -49,19 +49,16 @@ do_install_append() {
# make installed languages choosable
pkg_postinst_${PN} () {
-if [ "x$D" != "x" ]; then
- exit 1
-fi
langs=""
-for lang in `find ${libdir}/locale -maxdepth 1 | grep _ | sort`; do
- lang=`basename $lang`
- if [ "x$langs" = "x" ]; then
- langs="$lang"
- else
- langs="$langs $lang"
- fi
+for lang in `find $D${libdir}/locale -maxdepth 1 | grep _ | sort`; do
+lang=`basename $lang`
+if [ "x$langs" = "x" ]; then
+ langs="$lang"
+else
+ langs="$langs $lang"
+fi
done
-sed -i "s:last_langs=.*$:last_langs=$langs:g" ${localstatedir}/lib/lxdm/lxdm.conf
+sed -i "s:last_langs=.*$:last_langs=$langs:g" $D${localstatedir}/lib/lxdm/lxdm.conf
}
RDEPENDS_${PN} = "pam-plugin-loginuid setxkbmap"
--
1.7.6.5
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] lxdm: fix postinst-code
2013-04-24 15:21 [PATCH] lxdm: fix postinst-code Andreas Müller
@ 2013-04-26 7:50 ` Andreas Müller
2013-04-26 8:12 ` Koen Kooi
0 siblings, 1 reply; 6+ messages in thread
From: Andreas Müller @ 2013-04-26 7:50 UTC (permalink / raw)
To: openembedded-devel
On Wed, Apr 24, 2013 at 5:21 PM, Andreas Müller
<schnitzeltony@googlemail.com> wrote:
> Exiting postinst code leaves systemd.bbclass offline postinst code unexecuted,
> causes postinst not to finish at first boot (lxdm.service is not aliased to
> display-manager.service -> started much too early) and is not neccesary:
> language preparation can be done offline.
>
> Signed-off-by: Andreas Müller <schnitzeltony@googlemail.com>
> ---
This unbreaks 1st boot postinst issue - so I would like to see it also
in dylan (of course also in master :).
BTW: I am looking into postinst issue for gdm (and other recipes) -
will send out a patch as soon as I have test results.
Andreas
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] lxdm: fix postinst-code
2013-04-26 7:50 ` Andreas Müller
@ 2013-04-26 8:12 ` Koen Kooi
2013-04-26 8:43 ` Martin Jansa
0 siblings, 1 reply; 6+ messages in thread
From: Koen Kooi @ 2013-04-26 8:12 UTC (permalink / raw)
To: openembedded-devel
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Op 26-04-13 09:50, Andreas Müller schreef:
> On Wed, Apr 24, 2013 at 5:21 PM, Andreas Müller
> <schnitzeltony@googlemail.com> wrote:
>> Exiting postinst code leaves systemd.bbclass offline postinst code
>> unexecuted, causes postinst not to finish at first boot (lxdm.service
>> is not aliased to display-manager.service -> started much too early)
>> and is not neccesary: language preparation can be done offline.
>>
>> Signed-off-by: Andreas Müller <schnitzeltony@googlemail.com> ---
> This unbreaks 1st boot postinst issue - so I would like to see it also in
> dylan (of course also in master :).
\o/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)
Comment: GPGTools - http://gpgtools.org
iD8DBQFRejbeMkyGM64RGpERAvn7AKC2vNtsJOFH0B69XviG62I4FZ5RUgCeIbHi
C8vhmqTdYaoaziBDunpf2UQ=
=qqO1
-----END PGP SIGNATURE-----
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] lxdm: fix postinst-code
2013-04-26 8:12 ` Koen Kooi
@ 2013-04-26 8:43 ` Martin Jansa
2013-04-26 8:57 ` Andreas Müller
2013-04-26 8:57 ` Koen Kooi
0 siblings, 2 replies; 6+ messages in thread
From: Martin Jansa @ 2013-04-26 8:43 UTC (permalink / raw)
To: openembedded-devel
[-- Attachment #1: Type: text/plain, Size: 1188 bytes --]
On Fri, Apr 26, 2013 at 10:12:14AM +0200, Koen Kooi wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Op 26-04-13 09:50, Andreas Müller schreef:
> > On Wed, Apr 24, 2013 at 5:21 PM, Andreas Müller
> > <schnitzeltony@googlemail.com> wrote:
> >> Exiting postinst code leaves systemd.bbclass offline postinst code
> >> unexecuted, causes postinst not to finish at first boot (lxdm.service
> >> is not aliased to display-manager.service -> started much too early)
> >> and is not neccesary: language preparation can be done offline.
> >>
> >> Signed-off-by: Andreas Müller <schnitzeltony@googlemail.com> ---
> > This unbreaks 1st boot postinst issue - so I would like to see it also in
> > dylan (of course also in master :).
>
> \o/
Not sure what this ascii art means, but if it's something about pushing
stuff through narrow bottleneck, then I plan to push more stuff to
master after this jenkins job is finished:
NOTE: Running task 6924 of 26342
I was trying to test at least qemuarm/qemux86 before branching and there
was a lot of rebuilds... More ACKs on patches on ML helps a lot.
--
Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] lxdm: fix postinst-code
2013-04-26 8:43 ` Martin Jansa
@ 2013-04-26 8:57 ` Andreas Müller
2013-04-26 8:57 ` Koen Kooi
1 sibling, 0 replies; 6+ messages in thread
From: Andreas Müller @ 2013-04-26 8:57 UTC (permalink / raw)
To: openembedded-devel
On Fri, Apr 26, 2013 at 10:43 AM, Martin Jansa <martin.jansa@gmail.com> wrote:
> On Fri, Apr 26, 2013 at 10:12:14AM +0200, Koen Kooi wrote:
>> -----BEGIN PGP SIGNED MESSAGE-----
>> Hash: SHA1
>>
>> Op 26-04-13 09:50, Andreas Müller schreef:
>> > On Wed, Apr 24, 2013 at 5:21 PM, Andreas Müller
>> > <schnitzeltony@googlemail.com> wrote:
>> >> Exiting postinst code leaves systemd.bbclass offline postinst code
>> >> unexecuted, causes postinst not to finish at first boot (lxdm.service
>> >> is not aliased to display-manager.service -> started much too early)
>> >> and is not neccesary: language preparation can be done offline.
>> >>
>> >> Signed-off-by: Andreas Müller <schnitzeltony@googlemail.com> ---
>> > This unbreaks 1st boot postinst issue - so I would like to see it also in
>> > dylan (of course also in master :).
>>
>> \o/
>
> Not sure what this ascii art means, but if it's something about pushing
> stuff through narrow bottleneck, then I plan to push more stuff to
> master after this jenkins job is finished:
> NOTE: Running task 6924 of 26342
My intention was not to put pressure on you. I highly appreciate that
you are testing patches and this takes time - I know that.
Andreas
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] lxdm: fix postinst-code
2013-04-26 8:43 ` Martin Jansa
2013-04-26 8:57 ` Andreas Müller
@ 2013-04-26 8:57 ` Koen Kooi
1 sibling, 0 replies; 6+ messages in thread
From: Koen Kooi @ 2013-04-26 8:57 UTC (permalink / raw)
To: openembedded-devel
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Op 26-04-13 10:43, Martin Jansa schreef:
> On Fri, Apr 26, 2013 at 10:12:14AM +0200, Koen Kooi wrote:
>> -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
>>
>> Op 26-04-13 09:50, Andreas Müller schreef:
>>> On Wed, Apr 24, 2013 at 5:21 PM, Andreas Müller
>>> <schnitzeltony@googlemail.com> wrote:
>>>> Exiting postinst code leaves systemd.bbclass offline postinst code
>>>> unexecuted, causes postinst not to finish at first boot
>>>> (lxdm.service is not aliased to display-manager.service -> started
>>>> much too early) and is not neccesary: language preparation can be
>>>> done offline.
>>>>
>>>> Signed-off-by: Andreas Müller <schnitzeltony@googlemail.com> ---
>>> This unbreaks 1st boot postinst issue - so I would like to see it
>>> also in dylan (of course also in master :).
>>
>> \o/
>
> Not sure what this ascii art means,
It's a cheer: http://en.wikipedia.org/wiki/List_of_emoticons
but if it's something about pushing
> stuff through narrow bottleneck, then I plan to push more stuff to master
> after this jenkins job is finished: NOTE: Running task 6924 of 26342
>
> I was trying to test at least qemuarm/qemux86 before branching and there
> was a lot of rebuilds... More ACKs on patches on ML helps a lot.
Still rebuilding dylan branches for a few machines to test, on a laptop :/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)
Comment: GPGTools - http://gpgtools.org
iD8DBQFRekGVMkyGM64RGpERAnKjAJwJnAm6slXhV+ITveWLx7t7+0vEWACfY8XO
FgeL+JHAcYJoyocoFx86Bi4=
=9PL9
-----END PGP SIGNATURE-----
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-04-26 9:16 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-04-24 15:21 [PATCH] lxdm: fix postinst-code Andreas Müller
2013-04-26 7:50 ` Andreas Müller
2013-04-26 8:12 ` Koen Kooi
2013-04-26 8:43 ` Martin Jansa
2013-04-26 8:57 ` Andreas Müller
2013-04-26 8:57 ` Koen Kooi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox