* [PATCH] openrisc: Fix misalignments in head.S
@ 2024-12-05 13:04 Geert Uytterhoeven
2024-12-05 18:39 ` Stafford Horne
0 siblings, 1 reply; 2+ messages in thread
From: Geert Uytterhoeven @ 2024-12-05 13:04 UTC (permalink / raw)
To: Jonas Bonn, Stefan Kristiansson, Stafford Horne
Cc: linux-openrisc, Geert Uytterhoeven
Align all line continuations and (sub)section headers in a consistent
way.
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
arch/openrisc/kernel/head.S | 26 +++++++++++++-------------
1 file changed, 13 insertions(+), 13 deletions(-)
diff --git a/arch/openrisc/kernel/head.S b/arch/openrisc/kernel/head.S
index 439e00f81e5dde18..b64ac73455ed3279 100644
--- a/arch/openrisc/kernel/head.S
+++ b/arch/openrisc/kernel/head.S
@@ -26,15 +26,15 @@
#include <asm/asm-offsets.h>
#include <linux/of_fdt.h>
-#define tophys(rd,rs) \
- l.movhi rd,hi(-KERNELBASE) ;\
+#define tophys(rd,rs) \
+ l.movhi rd,hi(-KERNELBASE) ;\
l.add rd,rd,rs
-#define CLEAR_GPR(gpr) \
+#define CLEAR_GPR(gpr) \
l.movhi gpr,0x0
-#define LOAD_SYMBOL_2_GPR(gpr,symbol) \
- l.movhi gpr,hi(symbol) ;\
+#define LOAD_SYMBOL_2_GPR(gpr,symbol) \
+ l.movhi gpr,hi(symbol) ;\
l.ori gpr,gpr,lo(symbol)
@@ -326,21 +326,21 @@
l.addi r1,r1,-(INT_FRAME_SIZE) ;\
/* r1 is KSP, r30 is __pa(KSP) */ ;\
tophys (r30,r1) ;\
- l.sw PT_GPR12(r30),r12 ;\
+ l.sw PT_GPR12(r30),r12 ;\
l.mfspr r12,r0,SPR_EPCR_BASE ;\
l.sw PT_PC(r30),r12 ;\
l.mfspr r12,r0,SPR_ESR_BASE ;\
l.sw PT_SR(r30),r12 ;\
/* save r31 */ ;\
EXCEPTION_T_LOAD_GPR30(r12) ;\
- l.sw PT_GPR30(r30),r12 ;\
+ l.sw PT_GPR30(r30),r12 ;\
/* save r10 as was prior to exception */ ;\
EXCEPTION_T_LOAD_GPR10(r12) ;\
- l.sw PT_GPR10(r30),r12 ;\
- /* save PT_SP as was prior to exception */ ;\
+ l.sw PT_GPR10(r30),r12 ;\
+ /* save PT_SP as was prior to exception */ ;\
EXCEPTION_T_LOAD_SP(r12) ;\
l.sw PT_SP(r30),r12 ;\
- l.sw PT_GPR13(r30),r13 ;\
+ l.sw PT_GPR13(r30),r13 ;\
/* --> */ ;\
/* save exception r4, set r4 = EA */ ;\
l.sw PT_GPR4(r30),r4 ;\
@@ -394,7 +394,7 @@ _dispatch_do_ipage_fault:
.org 0x500
EXCEPTION_HANDLE(_timer_handler)
-/* ---[ 0x600: Alignment exception ]-------------------------------------- */
+/* ---[ 0x600: Alignment exception ]------------------------------------- */
.org 0x600
EXCEPTION_HANDLE(_alignment_handler)
@@ -424,7 +424,7 @@ _dispatch_do_ipage_fault:
.org 0xc00
EXCEPTION_HANDLE(_sys_call_handler)
-/* ---[ 0xd00: Floating point exception ]--------------------------------- */
+/* ---[ 0xd00: Floating point exception ]-------------------------------- */
.org 0xd00
EXCEPTION_HANDLE(_fpe_trap_handler)
@@ -816,7 +816,7 @@ secondary_start:
#endif
-/* ========================================[ cache ]=== */
+/* ==========================================================[ cache ]=== */
/* alignment here so we don't change memory offsets with
* memory controller defined
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] openrisc: Fix misalignments in head.S
2024-12-05 13:04 [PATCH] openrisc: Fix misalignments in head.S Geert Uytterhoeven
@ 2024-12-05 18:39 ` Stafford Horne
0 siblings, 0 replies; 2+ messages in thread
From: Stafford Horne @ 2024-12-05 18:39 UTC (permalink / raw)
To: Geert Uytterhoeven; +Cc: Jonas Bonn, Stefan Kristiansson, linux-openrisc
On Thu, Dec 05, 2024 at 02:04:26PM +0100, Geert Uytterhoeven wrote:
> Align all line continuations and (sub)section headers in a consistent
> way.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> arch/openrisc/kernel/head.S | 26 +++++++++++++-------------
> 1 file changed, 13 insertions(+), 13 deletions(-)
>
> diff --git a/arch/openrisc/kernel/head.S b/arch/openrisc/kernel/head.S
> index 439e00f81e5dde18..b64ac73455ed3279 100644
> --- a/arch/openrisc/kernel/head.S
> +++ b/arch/openrisc/kernel/head.S
> @@ -26,15 +26,15 @@
> #include <asm/asm-offsets.h>
> #include <linux/of_fdt.h>
>
> -#define tophys(rd,rs) \
> - l.movhi rd,hi(-KERNELBASE) ;\
> +#define tophys(rd,rs) \
> + l.movhi rd,hi(-KERNELBASE) ;\
> l.add rd,rd,rs
>
> -#define CLEAR_GPR(gpr) \
> +#define CLEAR_GPR(gpr) \
> l.movhi gpr,0x0
>
> -#define LOAD_SYMBOL_2_GPR(gpr,symbol) \
> - l.movhi gpr,hi(symbol) ;\
> +#define LOAD_SYMBOL_2_GPR(gpr,symbol) \
> + l.movhi gpr,hi(symbol) ;\
> l.ori gpr,gpr,lo(symbol)
>
>
> @@ -326,21 +326,21 @@
> l.addi r1,r1,-(INT_FRAME_SIZE) ;\
> /* r1 is KSP, r30 is __pa(KSP) */ ;\
> tophys (r30,r1) ;\
> - l.sw PT_GPR12(r30),r12 ;\
> + l.sw PT_GPR12(r30),r12 ;\
> l.mfspr r12,r0,SPR_EPCR_BASE ;\
> l.sw PT_PC(r30),r12 ;\
> l.mfspr r12,r0,SPR_ESR_BASE ;\
> l.sw PT_SR(r30),r12 ;\
> /* save r31 */ ;\
> EXCEPTION_T_LOAD_GPR30(r12) ;\
> - l.sw PT_GPR30(r30),r12 ;\
> + l.sw PT_GPR30(r30),r12 ;\
> /* save r10 as was prior to exception */ ;\
> EXCEPTION_T_LOAD_GPR10(r12) ;\
> - l.sw PT_GPR10(r30),r12 ;\
> - /* save PT_SP as was prior to exception */ ;\
> + l.sw PT_GPR10(r30),r12 ;\
> + /* save PT_SP as was prior to exception */ ;\
> EXCEPTION_T_LOAD_SP(r12) ;\
> l.sw PT_SP(r30),r12 ;\
> - l.sw PT_GPR13(r30),r13 ;\
> + l.sw PT_GPR13(r30),r13 ;\
> /* --> */ ;\
> /* save exception r4, set r4 = EA */ ;\
> l.sw PT_GPR4(r30),r4 ;\
> @@ -394,7 +394,7 @@ _dispatch_do_ipage_fault:
> .org 0x500
> EXCEPTION_HANDLE(_timer_handler)
>
> -/* ---[ 0x600: Alignment exception ]-------------------------------------- */
> +/* ---[ 0x600: Alignment exception ]------------------------------------- */
> .org 0x600
> EXCEPTION_HANDLE(_alignment_handler)
>
> @@ -424,7 +424,7 @@ _dispatch_do_ipage_fault:
> .org 0xc00
> EXCEPTION_HANDLE(_sys_call_handler)
>
> -/* ---[ 0xd00: Floating point exception ]--------------------------------- */
> +/* ---[ 0xd00: Floating point exception ]-------------------------------- */
> .org 0xd00
> EXCEPTION_HANDLE(_fpe_trap_handler)
>
> @@ -816,7 +816,7 @@ secondary_start:
>
> #endif
>
> -/* ========================================[ cache ]=== */
> +/* ==========================================================[ cache ]=== */
>
> /* alignment here so we don't change memory offsets with
> * memory controller defined
Hi Geert,
This all looks fine to me. Traditionally I haven't attempted to fix up these
formatting issues as early on the maintainer Jonas was agaist this due to it
being unncessasary churn in the git history. Also, it makes git blame a bit
more difficult to use.
However, I am fine with this if there are more people than must me who feel the
formatting needs fixing.
I will queue this up.
Thanks,
-Stafford
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-12-05 18:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-12-05 13:04 [PATCH] openrisc: Fix misalignments in head.S Geert Uytterhoeven
2024-12-05 18:39 ` Stafford Horne
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox