OpenSBI Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Anup Patel <apatel@ventanamicro.com>
To: opensbi@lists.infradead.org
Subject: [PATCH v2 05/13] lib: utils/irqchip: Allow multiple FDT irqchip drivers
Date: Wed,  9 Feb 2022 20:34:32 +0530	[thread overview]
Message-ID: <20220209150441.121729-6-apatel@ventanamicro.com> (raw)
In-Reply-To: <20220209150441.121729-1-apatel@ventanamicro.com>

We can have multiple FDT irqchip drivers to be probed when a RISC-V
system has different types of interrupt controller in a hierarchy.

This will be certainly the case when a RISC-V system has both
RISC-V AIA IMSIC and RISC-V AIA APLIC implemented.

We extend simple FDT irqchip framework to allow multiple FDT
irqchip drivers to be used for same RISC-V platform.

Signed-off-by: Anup Patel <anup.patel@wdc.com>
Signed-off-by: Anup Patel <apatel@ventanamicro.com>
Reviewed-by: Atish Patra <atishp@rivosinc.com>
---
 lib/utils/irqchip/fdt_irqchip.c | 37 ++++++++++++++++++++++++++-------
 1 file changed, 30 insertions(+), 7 deletions(-)

diff --git a/lib/utils/irqchip/fdt_irqchip.c b/lib/utils/irqchip/fdt_irqchip.c
index 8dda661..bf6969a 100644
--- a/lib/utils/irqchip/fdt_irqchip.c
+++ b/lib/utils/irqchip/fdt_irqchip.c
@@ -18,23 +18,40 @@ static struct fdt_irqchip *irqchip_drivers[] = {
 	&fdt_irqchip_plic
 };
 
-static struct fdt_irqchip *current_driver = NULL;
+#define FDT_IRQCHIP_MAX_DRIVERS	8
+
+static struct fdt_irqchip *current_drivers[FDT_IRQCHIP_MAX_DRIVERS] = {0};
+static int current_drivers_count;
 
 void fdt_irqchip_exit(void)
 {
-	if (current_driver && current_driver->exit)
-		current_driver->exit();
+	int i;
+
+	for (i = 0; i < current_drivers_count; i++) {
+		if (!current_drivers[i] || !current_drivers[i]->exit)
+			continue;
+		current_drivers[i]->exit();
+	}
 }
 
 static int fdt_irqchip_warm_init(void)
 {
-	if (current_driver && current_driver->warm_init)
-		return current_driver->warm_init();
+	int i, rc;
+
+	for (i = 0; i < current_drivers_count; i++) {
+		if (!current_drivers[i] || !current_drivers[i]->warm_init)
+			continue;
+		rc = current_drivers[i]->warm_init();
+		if (rc)
+			return rc;
+	}
+
 	return 0;
 }
 
 static int fdt_irqchip_cold_init(void)
 {
+	bool drv_added;
 	int pos, noff, rc;
 	struct fdt_irqchip *drv;
 	const struct fdt_match *match;
@@ -44,6 +61,7 @@ static int fdt_irqchip_cold_init(void)
 		drv = irqchip_drivers[pos];
 
 		noff = -1;
+		drv_added = false;
 		while ((noff = fdt_find_match(fdt, noff,
 					drv->match_table, &match)) >= 0) {
 			if (drv->cold_init) {
@@ -53,10 +71,15 @@ static int fdt_irqchip_cold_init(void)
 				if (rc)
 					return rc;
 			}
-			current_driver = drv;
+
+			if (drv_added)
+				continue;
+
+			current_drivers[current_drivers_count++] = drv;
+			drv_added = true;
 		}
 
-		if (current_driver)
+		if (FDT_IRQCHIP_MAX_DRIVERS <= current_drivers_count)
 			break;
 	}
 
-- 
2.25.1



  parent reply	other threads:[~2022-02-09 15:04 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-09 15:04 [PATCH v2 00/13] OpenSBI RISC-V AIA Support Anup Patel
2022-02-09 15:04 ` [PATCH v2 01/13] include: sbi: Add AIA related CSR defines Anup Patel
2022-02-15 15:14   ` Anup Patel
2022-02-09 15:04 ` [PATCH v2 02/13] lib: sbi: Detect AIA CSRs at boot-time Anup Patel
2022-02-09 16:33   ` Atish Patra
2022-02-15 15:14     ` Anup Patel
2022-02-09 15:04 ` [PATCH v2 03/13] lib: sbi: Use AIA CSRs for local interrupts when available Anup Patel
2022-02-09 16:41   ` Atish Patra
2022-02-15 15:15     ` Anup Patel
2022-02-09 15:04 ` [PATCH v2 04/13] lib: sbi: Add sbi_trap_set_external_irqfn() API Anup Patel
2022-02-15 15:15   ` Anup Patel
2022-02-09 15:04 ` Anup Patel [this message]
2022-02-15 15:16   ` [PATCH v2 05/13] lib: utils/irqchip: Allow multiple FDT irqchip drivers Anup Patel
2022-02-09 15:04 ` [PATCH v2 06/13] include: sbi: Introduce nascent_init() platform callback Anup Patel
2022-02-15 15:16   ` Anup Patel
2022-02-09 15:04 ` [PATCH v2 07/13] lib: sbi: Enable mie.MEIE bit for IPIs based on external interrupts Anup Patel
2022-02-09 16:31   ` Atish Patra
2022-02-15 15:19     ` Anup Patel
2022-02-09 15:04 ` [PATCH v2 08/13] lib: utils/irqchip: Add IMSIC library Anup Patel
2022-02-12  9:09   ` Atish Patra
2022-02-15 15:19     ` Anup Patel
2022-02-09 15:04 ` [PATCH v2 09/13] lib: utils/irqchip: Add FDT based driver for IMSIC Anup Patel
2022-02-12  0:54   ` Atish Patra
2022-02-15 14:57     ` Anup Patel
2022-02-15 15:20     ` Anup Patel
2022-02-09 15:04 ` [PATCH v2 10/13] lib: utils: Disable appropriate IMSIC DT nodes in fdt_fixups() Anup Patel
2022-02-15 15:20   ` Anup Patel
2022-02-09 15:04 ` [PATCH v2 11/13] lib: utils/irqchip: Add APLIC initialization library Anup Patel
2022-02-12  0:32   ` Atish Patra
2022-02-15 15:24     ` Anup Patel
2022-02-09 15:04 ` [PATCH v2 12/13] lib: utils/irqchip: Add FDT based driver for APLIC Anup Patel
2022-02-12  0:56   ` Atish Patra
2022-02-15 14:57     ` Anup Patel
2022-02-15 15:25     ` Anup Patel
2022-02-09 15:04 ` [PATCH v2 13/13] lib: utils: Disable appropriate APLIC DT nodes in fdt_fixups() Anup Patel
2022-02-15 15:25   ` Anup Patel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220209150441.121729-6-apatel@ventanamicro.com \
    --to=apatel@ventanamicro.com \
    --cc=opensbi@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox