OpenSBI Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Anup Patel <apatel@ventanamicro.com>
To: opensbi@lists.infradead.org
Subject: [PATCH v2 07/13] lib: sbi: Enable mie.MEIE bit for IPIs based on external interrupts.
Date: Wed,  9 Feb 2022 20:34:34 +0530	[thread overview]
Message-ID: <20220209150441.121729-8-apatel@ventanamicro.com> (raw)
In-Reply-To: <20220209150441.121729-1-apatel@ventanamicro.com>

We can have IPIs based on external interrupts provided by devices
such as AIA IMSIC so we should enable mie.MEIE bit at appropriate
places in generic library.

Signed-off-by: Anup Patel <anup@brainfault.org>
Signed-off-by: Anup Patel <apatel@ventanamicro.com>
---
 lib/sbi/sbi_hsm.c  | 4 ++--
 lib/sbi/sbi_init.c | 9 ++++++---
 2 files changed, 8 insertions(+), 5 deletions(-)

diff --git a/lib/sbi/sbi_hsm.c b/lib/sbi/sbi_hsm.c
index ecd2e45..c4d2c6d 100644
--- a/lib/sbi/sbi_hsm.c
+++ b/lib/sbi/sbi_hsm.c
@@ -113,8 +113,8 @@ static void sbi_hsm_hart_wait(struct sbi_scratch *scratch, u32 hartid)
 	/* Save MIE CSR */
 	saved_mie = csr_read(CSR_MIE);
 
-	/* Set MSIE bit to receive IPI */
-	csr_set(CSR_MIE, MIP_MSIP);
+	/* Set MSIE and MEIE bits to receive IPI */
+	csr_set(CSR_MIE, MIP_MSIP | MIP_MEIP);
 
 	/* Wait for hart_add call*/
 	while (atomic_read(&hdata->state) != SBI_HSM_STATE_START_PENDING) {
diff --git a/lib/sbi/sbi_init.c b/lib/sbi/sbi_init.c
index 27d03a7..6876eb2 100644
--- a/lib/sbi/sbi_init.c
+++ b/lib/sbi/sbi_init.c
@@ -165,8 +165,8 @@ static void wait_for_coldboot(struct sbi_scratch *scratch, u32 hartid)
 	/* Save MIE CSR */
 	saved_mie = csr_read(CSR_MIE);
 
-	/* Set MSIE bit to receive IPI */
-	csr_set(CSR_MIE, MIP_MSIP);
+	/* Set MSIE and MEIE bits to receive IPI */
+	csr_set(CSR_MIE, MIP_MSIP | MIP_MEIP);
 
 	/* Acquire coldboot lock */
 	spin_lock(&coldboot_lock);
@@ -182,7 +182,7 @@ static void wait_for_coldboot(struct sbi_scratch *scratch, u32 hartid)
 		do {
 			wfi();
 			cmip = csr_read(CSR_MIP);
-		 } while (!(cmip & MIP_MSIP));
+		 } while (!(cmip & (MIP_MSIP | MIP_MEIP)));
 	};
 
 	/* Acquire coldboot lock */
@@ -276,6 +276,7 @@ static void __noreturn init_coldboot(struct sbi_scratch *scratch, u32 hartid)
 			   __func__, rc);
 		sbi_hart_hang();
 	}
+	csr_set(CSR_MIE, MIP_MEIP);
 
 	rc = sbi_ipi_init(scratch, TRUE);
 	if (rc) {
@@ -376,6 +377,7 @@ static void init_warm_startup(struct sbi_scratch *scratch, u32 hartid)
 	rc = sbi_platform_irqchip_init(plat, FALSE);
 	if (rc)
 		sbi_hart_hang();
+	csr_set(CSR_MIE, MIP_MEIP);
 
 	rc = sbi_ipi_init(scratch, FALSE);
 	if (rc)
@@ -550,6 +552,7 @@ void __noreturn sbi_exit(struct sbi_scratch *scratch)
 
 	sbi_ipi_exit(scratch);
 
+	csr_clear(CSR_MIE, MIP_MEIP);
 	sbi_platform_irqchip_exit(plat);
 
 	sbi_platform_final_exit(plat);
-- 
2.25.1



  parent reply	other threads:[~2022-02-09 15:04 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-09 15:04 [PATCH v2 00/13] OpenSBI RISC-V AIA Support Anup Patel
2022-02-09 15:04 ` [PATCH v2 01/13] include: sbi: Add AIA related CSR defines Anup Patel
2022-02-15 15:14   ` Anup Patel
2022-02-09 15:04 ` [PATCH v2 02/13] lib: sbi: Detect AIA CSRs at boot-time Anup Patel
2022-02-09 16:33   ` Atish Patra
2022-02-15 15:14     ` Anup Patel
2022-02-09 15:04 ` [PATCH v2 03/13] lib: sbi: Use AIA CSRs for local interrupts when available Anup Patel
2022-02-09 16:41   ` Atish Patra
2022-02-15 15:15     ` Anup Patel
2022-02-09 15:04 ` [PATCH v2 04/13] lib: sbi: Add sbi_trap_set_external_irqfn() API Anup Patel
2022-02-15 15:15   ` Anup Patel
2022-02-09 15:04 ` [PATCH v2 05/13] lib: utils/irqchip: Allow multiple FDT irqchip drivers Anup Patel
2022-02-15 15:16   ` Anup Patel
2022-02-09 15:04 ` [PATCH v2 06/13] include: sbi: Introduce nascent_init() platform callback Anup Patel
2022-02-15 15:16   ` Anup Patel
2022-02-09 15:04 ` Anup Patel [this message]
2022-02-09 16:31   ` [PATCH v2 07/13] lib: sbi: Enable mie.MEIE bit for IPIs based on external interrupts Atish Patra
2022-02-15 15:19     ` Anup Patel
2022-02-09 15:04 ` [PATCH v2 08/13] lib: utils/irqchip: Add IMSIC library Anup Patel
2022-02-12  9:09   ` Atish Patra
2022-02-15 15:19     ` Anup Patel
2022-02-09 15:04 ` [PATCH v2 09/13] lib: utils/irqchip: Add FDT based driver for IMSIC Anup Patel
2022-02-12  0:54   ` Atish Patra
2022-02-15 14:57     ` Anup Patel
2022-02-15 15:20     ` Anup Patel
2022-02-09 15:04 ` [PATCH v2 10/13] lib: utils: Disable appropriate IMSIC DT nodes in fdt_fixups() Anup Patel
2022-02-15 15:20   ` Anup Patel
2022-02-09 15:04 ` [PATCH v2 11/13] lib: utils/irqchip: Add APLIC initialization library Anup Patel
2022-02-12  0:32   ` Atish Patra
2022-02-15 15:24     ` Anup Patel
2022-02-09 15:04 ` [PATCH v2 12/13] lib: utils/irqchip: Add FDT based driver for APLIC Anup Patel
2022-02-12  0:56   ` Atish Patra
2022-02-15 14:57     ` Anup Patel
2022-02-15 15:25     ` Anup Patel
2022-02-09 15:04 ` [PATCH v2 13/13] lib: utils: Disable appropriate APLIC DT nodes in fdt_fixups() Anup Patel
2022-02-15 15:25   ` Anup Patel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220209150441.121729-8-apatel@ventanamicro.com \
    --to=apatel@ventanamicro.com \
    --cc=opensbi@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox