From: Yu Chien Peter Lin <peterlin@andestech.com>
To: opensbi@lists.infradead.org
Subject: [PATCH v4 10/14] platform: andes/ae350: Use fdt irqchip driver
Date: Fri, 14 Oct 2022 08:32:48 +0800 [thread overview]
Message-ID: <20221014003252.17765-11-peterlin@andestech.com> (raw)
In-Reply-To: <20221014003252.17765-1-peterlin@andestech.com>
Andes PLIC is compatible with plic driver. The PLIC base address and
number of source can be obtained by parsing the device tree.
Signed-off-by: Yu Chien Peter Lin <peterlin@andestech.com>
Reviewed-by: Leo Yu-Chi Liang <ycliang@andestech.com>
Reviewed-by: Anup Patel <anup@brainfault.org>
---
platform/andes/ae350/Kconfig | 3 ++-
platform/andes/ae350/platform.c | 24 ++----------------------
platform/andes/ae350/platform.h | 3 ---
3 files changed, 4 insertions(+), 26 deletions(-)
diff --git a/platform/andes/ae350/Kconfig b/platform/andes/ae350/Kconfig
index 8486f08..084b27f 100644
--- a/platform/andes/ae350/Kconfig
+++ b/platform/andes/ae350/Kconfig
@@ -3,13 +3,14 @@
config PLATFORM_ANDES_AE350
bool
select FDT
- select IRQCHIP_PLIC
select FDT_SERIAL
select FDT_SERIAL_UART8250
select FDT_TIMER
select FDT_TIMER_PLMT
select FDT_RESET
select FDT_RESET_ATCWDT200
+ select FDT_IRQCHIP
+ select FDT_IRQCHIP_PLIC
default y
if PLATFORM_ANDES_AE350
diff --git a/platform/andes/ae350/platform.c b/platform/andes/ae350/platform.c
index c6a8eeb..98acaaa 100644
--- a/platform/andes/ae350/platform.c
+++ b/platform/andes/ae350/platform.c
@@ -17,7 +17,7 @@
#include <sbi/sbi_trap.h>
#include <sbi_utils/fdt/fdt_helper.h>
#include <sbi_utils/fdt/fdt_fixup.h>
-#include <sbi_utils/irqchip/plic.h>
+#include <sbi_utils/irqchip/fdt_irqchip.h>
#include <sbi_utils/reset/fdt_reset.h>
#include <sbi_utils/serial/fdt_serial.h>
#include <sbi_utils/timer/fdt_timer.h>
@@ -25,11 +25,6 @@
#include "plicsw.h"
#include "cache.h"
-static struct plic_data plic = {
- .addr = AE350_PLIC_ADDR,
- .num_src = AE350_PLIC_NUM_SOURCES,
-};
-
/* Platform final initialization. */
static int ae350_final_init(bool cold_boot)
{
@@ -46,21 +41,6 @@ static int ae350_final_init(bool cold_boot)
return 0;
}
-/* Initialize the platform interrupt controller for current HART. */
-static int ae350_irqchip_init(bool cold_boot)
-{
- u32 hartid = current_hartid();
- int ret;
-
- if (cold_boot) {
- ret = plic_cold_irqchip_init(&plic);
- if (ret)
- return ret;
- }
-
- return plic_warm_irqchip_init(&plic, 2 * hartid, 2 * hartid + 1);
-}
-
static struct sbi_ipi_device plicsw_ipi = {
.name = "ae350_plicsw",
.ipi_send = plicsw_ipi_send,
@@ -134,7 +114,7 @@ const struct sbi_platform_operations platform_ops = {
.console_init = fdt_serial_init,
- .irqchip_init = ae350_irqchip_init,
+ .irqchip_init = fdt_irqchip_init,
.ipi_init = ae350_ipi_init,
diff --git a/platform/andes/ae350/platform.h b/platform/andes/ae350/platform.h
index 6a29fe5..3264b6f 100644
--- a/platform/andes/ae350/platform.h
+++ b/platform/andes/ae350/platform.h
@@ -13,9 +13,6 @@
#define AE350_HART_COUNT 4
-#define AE350_PLIC_ADDR 0xe4000000
-#define AE350_PLIC_NUM_SOURCES 71
-
#define AE350_PLICSW_ADDR 0xe6400000
#define AE350_L2C_ADDR 0xe0500000
--
2.34.1
next prev parent reply other threads:[~2022-10-14 0:32 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-14 0:32 [PATCH v4 00/14] Add Andes AE350 fdt driver support Yu Chien Peter Lin
2022-10-14 0:32 ` [PATCH v4 01/14] include: sbi: Fix typo in comment Yu Chien Peter Lin
2022-10-14 0:32 ` [PATCH v4 02/14] lib: " Yu Chien Peter Lin
2022-10-14 0:32 ` [PATCH v4 03/14] include: sbi: Fix grammar " Yu Chien Peter Lin
2022-10-23 4:39 ` Anup Patel
2022-10-14 0:32 ` [PATCH v4 04/14] lib: sbi: Add sbi_domain_root_add_memrange() API Yu Chien Peter Lin
2022-10-14 0:32 ` [PATCH v4 05/14] platform: andes/ae350: Remove enabling cache from an350_final_init Yu Chien Peter Lin
2022-10-14 0:32 ` [PATCH v4 06/14] platform: andes/ae350: Use kconfig to set platform version and default name Yu Chien Peter Lin
2022-10-14 0:32 ` [PATCH v4 07/14] platform: andes/ae350: Use fdt serial driver Yu Chien Peter Lin
2022-10-14 0:32 ` [PATCH v4 08/14] lib: utils/timer: Add Andes fdt timer support Yu Chien Peter Lin
2022-10-16 19:15 ` Samuel Holland
2022-10-19 21:23 ` Yu-Chien Peter Lin
2022-10-21 5:11 ` Anup Patel
2022-10-21 6:01 ` Atish Patra
2022-10-29 15:51 ` Samuel Holland
2022-10-14 0:32 ` [PATCH v4 09/14] lib: utils/reset: Add Andes fdt reset driver support Yu Chien Peter Lin
2022-10-16 19:19 ` Samuel Holland
2022-10-14 0:32 ` Yu Chien Peter Lin [this message]
2022-10-14 0:32 ` [PATCH v4 11/14] platform: andes/ae350: Add fw_platform_init for platform initialization Yu Chien Peter Lin
2022-10-14 0:32 ` [PATCH v4 12/14] lib: utils/ipi: Add Andes fdt ipi driver support Yu Chien Peter Lin
2022-10-23 4:43 ` Anup Patel
2022-10-14 0:32 ` [PATCH v4 13/14] platform: andes/ae350: Add AE350 domain support Yu Chien Peter Lin
2022-10-14 0:32 ` [PATCH v4 14/14] docs: andes-ae350.md: Update ae350 documentation for fdt driver support Yu Chien Peter Lin
2022-10-23 5:12 ` [PATCH v4 00/14] Add Andes AE350 " Anup Patel
2022-10-24 15:10 ` Yu-Chien Peter Lin
2022-10-24 8:10 ` Anup Patel
2022-10-27 20:21 ` Yu-Chien Peter Lin
2022-10-27 12:43 ` Anup Patel
2022-10-28 8:43 ` Yu-Chien Peter Lin
2022-10-28 16:38 ` Anup Patel
2022-10-29 10:01 ` Yu-Chien Peter Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221014003252.17765-11-peterlin@andestech.com \
--to=peterlin@andestech.com \
--cc=opensbi@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox