OpenSBI Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yu-Chien Peter Lin <peterlin@andestech.com>
To: opensbi@lists.infradead.org
Subject: [PATCH v4 08/14] lib: utils/timer: Add Andes fdt timer support
Date: Wed, 19 Oct 2022 21:23:26 +0000	[thread overview]
Message-ID: <Y1BqzqFKA0B9v4BQ@APC323> (raw)
In-Reply-To: <43cddb0a-934c-a020-f7d4-dcc5ef0401f3@sholland.org>

On Sun, Oct 16, 2022 at 02:15:42PM -0500, Samuel Holland wrote:
> On 10/13/22 19:32, Yu Chien Peter Lin wrote:
> > Since we can get the PLMT base address and timer frequency from
> > device tree, move plmt timer device to fdt timer framework.
> > 
> > dts example (Quad-core AX45MP):
> > 
> >   cpus {
> >       ...
> >       timebase-frequency = <0x3938700>;
> >       ...
> >   }
> >   soc {
> >       ...
> >       plmt0 at e6000000 {
> >           compatible = "andestech,plmt0";
> >           reg = <0x00 0xe6000000 0x00 0x100000>;
> >           interrupts-extended = <&cpu0_intc 0x07
> >                                  &cpu1_intc 0x07
> >                                  &cpu2_intc 0x07
> >                                  &cpu3_intc 0x07>;
> >       };
> >       ...
> >   }
> 
> Where is the binding for this compatible string? I do not see anything
> either upstream or downstream:
> 
> https://lore.kernel.org/linux-devicetree/?q=andestech%2Cplmt0
> https://github.com/andestech/linux/commits/RISCV-Linux-5.4-ast-v5_1_0-branch/Documentation/devicetree/bindings
> 
> We really shouldn't be accepting any devicetree compatible unless a YAML
> binding for it exists, ideally one acked by the DT schema maintainers.
> 
> Regards,
> Samuel
> 

Hi Samuel,

Thanks for pointing this out!
As PLMT and PLICSW are not used by any driver in kernel, I think it's
better to maintain within our own repository. Here is the branch [1]
we've updated the schemas for these fdt drivers.
If this works for you, we'll send PATCH v5 to fix dt binding check
violation.

[1] https://github.com/andestech/linux/commits/v6.0.y_ae350-ax45mp/Documentation/devicetree/bindings


  reply	other threads:[~2022-10-19 21:23 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-14  0:32 [PATCH v4 00/14] Add Andes AE350 fdt driver support Yu Chien Peter Lin
2022-10-14  0:32 ` [PATCH v4 01/14] include: sbi: Fix typo in comment Yu Chien Peter Lin
2022-10-14  0:32 ` [PATCH v4 02/14] lib: " Yu Chien Peter Lin
2022-10-14  0:32 ` [PATCH v4 03/14] include: sbi: Fix grammar " Yu Chien Peter Lin
2022-10-23  4:39   ` Anup Patel
2022-10-14  0:32 ` [PATCH v4 04/14] lib: sbi: Add sbi_domain_root_add_memrange() API Yu Chien Peter Lin
2022-10-14  0:32 ` [PATCH v4 05/14] platform: andes/ae350: Remove enabling cache from an350_final_init Yu Chien Peter Lin
2022-10-14  0:32 ` [PATCH v4 06/14] platform: andes/ae350: Use kconfig to set platform version and default name Yu Chien Peter Lin
2022-10-14  0:32 ` [PATCH v4 07/14] platform: andes/ae350: Use fdt serial driver Yu Chien Peter Lin
2022-10-14  0:32 ` [PATCH v4 08/14] lib: utils/timer: Add Andes fdt timer support Yu Chien Peter Lin
2022-10-16 19:15   ` Samuel Holland
2022-10-19 21:23     ` Yu-Chien Peter Lin [this message]
2022-10-21  5:11     ` Anup Patel
2022-10-21  6:01       ` Atish Patra
2022-10-29 15:51         ` Samuel Holland
2022-10-14  0:32 ` [PATCH v4 09/14] lib: utils/reset: Add Andes fdt reset driver support Yu Chien Peter Lin
2022-10-16 19:19   ` Samuel Holland
2022-10-14  0:32 ` [PATCH v4 10/14] platform: andes/ae350: Use fdt irqchip driver Yu Chien Peter Lin
2022-10-14  0:32 ` [PATCH v4 11/14] platform: andes/ae350: Add fw_platform_init for platform initialization Yu Chien Peter Lin
2022-10-14  0:32 ` [PATCH v4 12/14] lib: utils/ipi: Add Andes fdt ipi driver support Yu Chien Peter Lin
2022-10-23  4:43   ` Anup Patel
2022-10-14  0:32 ` [PATCH v4 13/14] platform: andes/ae350: Add AE350 domain support Yu Chien Peter Lin
2022-10-14  0:32 ` [PATCH v4 14/14] docs: andes-ae350.md: Update ae350 documentation for fdt driver support Yu Chien Peter Lin
2022-10-23  5:12 ` [PATCH v4 00/14] Add Andes AE350 " Anup Patel
2022-10-24 15:10   ` Yu-Chien Peter Lin
2022-10-24  8:10     ` Anup Patel
2022-10-27 20:21       ` Yu-Chien Peter Lin
2022-10-27 12:43         ` Anup Patel
2022-10-28  8:43           ` Yu-Chien Peter Lin
2022-10-28 16:38             ` Anup Patel
2022-10-29 10:01               ` Yu-Chien Peter Lin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y1BqzqFKA0B9v4BQ@APC323 \
    --to=peterlin@andestech.com \
    --cc=opensbi@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox