From: Anup Patel <apatel@ventanamicro.com>
To: opensbi@lists.infradead.org
Subject: [PATCH v5 6/8] lib: sbi: Add console_puts() callback in the console device
Date: Fri, 13 Jan 2023 17:11:08 +0530 [thread overview]
Message-ID: <20230113114110.1916226-7-apatel@ventanamicro.com> (raw)
In-Reply-To: <20230113114110.1916226-1-apatel@ventanamicro.com>
We add console_puts() callback in the console device which allows
console drivers (such as semihosting) to implement a specialized
way to output character string.
Signed-off-by: Anup Patel <apatel@ventanamicro.com>
Reviewed-by: Atish Patra <atishp@rivosinc.com>
Reviewed-by: Xiang W <wxjstz@126.com>
Reviewed-by: Bin Meng <bmeng@tinylab.org>
---
include/sbi/sbi_console.h | 3 +++
lib/sbi/sbi_console.c | 19 ++++++++++++++-----
2 files changed, 17 insertions(+), 5 deletions(-)
diff --git a/include/sbi/sbi_console.h b/include/sbi/sbi_console.h
index 660c239..8e95b9d 100644
--- a/include/sbi/sbi_console.h
+++ b/include/sbi/sbi_console.h
@@ -19,6 +19,9 @@ struct sbi_console_device {
/** Write a character to the console output */
void (*console_putc)(char ch);
+ /** Write a character string to the console output */
+ void (*console_puts)(const char *str, unsigned long len);
+
/** Read a character from the console input */
int (*console_getc)(void);
};
diff --git a/lib/sbi/sbi_console.c b/lib/sbi/sbi_console.c
index 89d6a49..c1b9f73 100644
--- a/lib/sbi/sbi_console.c
+++ b/lib/sbi/sbi_console.c
@@ -12,6 +12,7 @@
#include <sbi/sbi_hart.h>
#include <sbi/sbi_platform.h>
#include <sbi/sbi_scratch.h>
+#include <sbi/sbi_string.h>
static const struct sbi_console_device *console_dev = NULL;
static spinlock_t console_out_lock = SPIN_LOCK_INITIALIZER;
@@ -44,9 +45,13 @@ void sbi_putc(char ch)
void sbi_puts(const char *str)
{
spin_lock(&console_out_lock);
- while (*str) {
- sbi_putc(*str);
- str++;
+ if (console_dev && console_dev->console_puts) {
+ console_dev->console_puts(str, sbi_strlen(str));
+ } else {
+ while (*str) {
+ sbi_putc(*str);
+ str++;
+ }
}
spin_unlock(&console_out_lock);
}
@@ -56,8 +61,12 @@ void sbi_nputs(const char *str, unsigned long len)
unsigned long i;
spin_lock(&console_out_lock);
- for (i = 0; i < len; i++)
- sbi_putc(str[i]);
+ if (console_dev && console_dev->console_puts) {
+ console_dev->console_puts(str, len);
+ } else {
+ for (i = 0; i < len; i++)
+ sbi_putc(str[i]);
+ }
spin_unlock(&console_out_lock);
}
--
2.34.1
next prev parent reply other threads:[~2023-01-13 11:41 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-13 11:41 [PATCH v5 0/8] OpenSBI debug console support Anup Patel
2023-01-13 11:41 ` [PATCH v5 1/8] include: Add defines for SBI debug console extension Anup Patel
2023-01-31 17:26 ` Andrew Jones
2023-02-09 16:51 ` Anup Patel
2023-01-13 11:41 ` [PATCH v5 2/8] lib: sbi: Add sbi_nputs() function Anup Patel
2023-01-31 17:32 ` Andrew Jones
2023-02-09 16:59 ` Anup Patel
2023-02-09 17:02 ` Jessica Clarke
2023-01-13 11:41 ` [PATCH v5 3/8] lib: sbi: Add sbi_ngets() function Anup Patel
2023-01-31 17:34 ` Andrew Jones
2023-01-13 11:41 ` [PATCH v5 4/8] lib: sbi: Add sbi_domain_check_addr_range() function Anup Patel
2023-02-01 8:48 ` Andrew Jones
2023-01-13 11:41 ` [PATCH v5 5/8] lib: sbi: Implement SBI debug console extension Anup Patel
2023-02-01 8:58 ` Andrew Jones
2023-02-10 4:23 ` Anup Patel
2023-02-10 5:19 ` Jessica Clarke
2023-02-10 5:29 ` Anup Patel
2023-02-01 9:35 ` Andrew Jones
2023-02-10 4:25 ` Anup Patel
2023-01-13 11:41 ` Anup Patel [this message]
2023-02-01 9:00 ` [PATCH v5 6/8] lib: sbi: Add console_puts() callback in the console device Andrew Jones
2023-02-04 13:14 ` Xiang W
2023-02-01 9:30 ` Andrew Jones
2023-02-01 9:37 ` Andrew Jones
2023-01-13 11:41 ` [PATCH v5 7/8] lib: utils/serial: Implement console_puts() for semihosting Anup Patel
2023-02-01 9:03 ` Andrew Jones
2023-01-13 11:41 ` [PATCH v5 8/8] lib: sbi: Speed-up sbi_printf() and friends using nputs() Anup Patel
2023-02-01 9:22 ` Andrew Jones
2023-02-10 5:41 ` Anup Patel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230113114110.1916226-7-apatel@ventanamicro.com \
--to=apatel@ventanamicro.com \
--cc=opensbi@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox