From: Anup Patel <apatel@ventanamicro.com>
To: opensbi@lists.infradead.org
Subject: [PATCH v5 8/8] lib: sbi: Speed-up sbi_printf() and friends using nputs()
Date: Fri, 13 Jan 2023 17:11:10 +0530 [thread overview]
Message-ID: <20230113114110.1916226-9-apatel@ventanamicro.com> (raw)
In-Reply-To: <20230113114110.1916226-1-apatel@ventanamicro.com>
The sbi_printf() is slow for semihosting because it prints one
character at a time. To speed-up sbi_printf() for semihosting,
we use a temporary buffer and nputs().
Signed-off-by: Anup Patel <apatel@ventanamicro.com>
---
lib/sbi/sbi_console.c | 52 ++++++++++++++++++++++++++++---------------
1 file changed, 34 insertions(+), 18 deletions(-)
diff --git a/lib/sbi/sbi_console.c b/lib/sbi/sbi_console.c
index c1b9f73..41881d7 100644
--- a/lib/sbi/sbi_console.c
+++ b/lib/sbi/sbi_console.c
@@ -42,31 +42,29 @@ void sbi_putc(char ch)
}
}
-void sbi_puts(const char *str)
+static void nputs(const char *str, unsigned long len)
{
- spin_lock(&console_out_lock);
+ unsigned long i;
+
if (console_dev && console_dev->console_puts) {
- console_dev->console_puts(str, sbi_strlen(str));
+ console_dev->console_puts(str, len);
} else {
- while (*str) {
- sbi_putc(*str);
- str++;
- }
+ for (i = 0; i < len; i++)
+ sbi_putc(str[i]);
}
+}
+
+void sbi_puts(const char *str)
+{
+ spin_lock(&console_out_lock);
+ nputs(str, sbi_strlen(str));
spin_unlock(&console_out_lock);
}
void sbi_nputs(const char *str, unsigned long len)
{
- unsigned long i;
-
spin_lock(&console_out_lock);
- if (console_dev && console_dev->console_puts) {
- console_dev->console_puts(str, len);
- } else {
- for (i = 0; i < len; i++)
- sbi_putc(str[i]);
- }
+ nputs(str, len);
spin_unlock(&console_out_lock);
}
@@ -102,6 +100,7 @@ unsigned long sbi_ngets(char *str, unsigned long len)
#define PAD_ZERO 2
#define PAD_ALTERNATE 4
#define PRINT_BUF_LEN 64
+#define PRINT_TBUF_MAX 128
#define va_start(v, l) __builtin_va_start((v), l)
#define va_end __builtin_va_end
@@ -217,12 +216,26 @@ static int printi(char **out, u32 *out_len, long long i, int b, int sg,
static int print(char **out, u32 *out_len, const char *format, va_list args)
{
- int width, flags;
- int pc = 0;
- char scr[2];
+ u32 tbuf_len;
+ int width, flags, pc = 0;
+ char scr[2], *tout, tbuf[PRINT_TBUF_MAX];
+ bool use_tbuf = (!out) ? true : false;
unsigned long long tmp;
+ if (use_tbuf) {
+ tbuf_len = PRINT_TBUF_MAX;
+ tout = tbuf;
+ out = &tout;
+ out_len = &tbuf_len;
+ }
+
for (; *format != 0; ++format) {
+ if (use_tbuf && !tbuf_len) {
+ nputs(tbuf, PRINT_TBUF_MAX);
+ tbuf_len = PRINT_TBUF_MAX;
+ tout = tbuf;
+ }
+
if (*format == '%') {
++format;
width = flags = 0;
@@ -348,6 +361,9 @@ literal:
}
}
+ if (use_tbuf && tbuf_len < PRINT_TBUF_MAX)
+ nputs(tbuf, PRINT_TBUF_MAX - tbuf_len);
+
return pc;
}
--
2.34.1
next prev parent reply other threads:[~2023-01-13 11:41 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-13 11:41 [PATCH v5 0/8] OpenSBI debug console support Anup Patel
2023-01-13 11:41 ` [PATCH v5 1/8] include: Add defines for SBI debug console extension Anup Patel
2023-01-31 17:26 ` Andrew Jones
2023-02-09 16:51 ` Anup Patel
2023-01-13 11:41 ` [PATCH v5 2/8] lib: sbi: Add sbi_nputs() function Anup Patel
2023-01-31 17:32 ` Andrew Jones
2023-02-09 16:59 ` Anup Patel
2023-02-09 17:02 ` Jessica Clarke
2023-01-13 11:41 ` [PATCH v5 3/8] lib: sbi: Add sbi_ngets() function Anup Patel
2023-01-31 17:34 ` Andrew Jones
2023-01-13 11:41 ` [PATCH v5 4/8] lib: sbi: Add sbi_domain_check_addr_range() function Anup Patel
2023-02-01 8:48 ` Andrew Jones
2023-01-13 11:41 ` [PATCH v5 5/8] lib: sbi: Implement SBI debug console extension Anup Patel
2023-02-01 8:58 ` Andrew Jones
2023-02-10 4:23 ` Anup Patel
2023-02-10 5:19 ` Jessica Clarke
2023-02-10 5:29 ` Anup Patel
2023-02-01 9:35 ` Andrew Jones
2023-02-10 4:25 ` Anup Patel
2023-01-13 11:41 ` [PATCH v5 6/8] lib: sbi: Add console_puts() callback in the console device Anup Patel
2023-02-01 9:00 ` Andrew Jones
2023-02-04 13:14 ` Xiang W
2023-02-01 9:30 ` Andrew Jones
2023-02-01 9:37 ` Andrew Jones
2023-01-13 11:41 ` [PATCH v5 7/8] lib: utils/serial: Implement console_puts() for semihosting Anup Patel
2023-02-01 9:03 ` Andrew Jones
2023-01-13 11:41 ` Anup Patel [this message]
2023-02-01 9:22 ` [PATCH v5 8/8] lib: sbi: Speed-up sbi_printf() and friends using nputs() Andrew Jones
2023-02-10 5:41 ` Anup Patel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230113114110.1916226-9-apatel@ventanamicro.com \
--to=apatel@ventanamicro.com \
--cc=opensbi@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox