From: Anup Patel <apatel@ventanamicro.com>
To: opensbi@lists.infradead.org
Subject: [PATCH 00/17] Introduce and use simple heap allocator
Date: Tue, 25 Apr 2023 18:02:13 +0530 [thread overview]
Message-ID: <20230425123230.3943447-1-apatel@ventanamicro.com> (raw)
Currently, we use global variables instead of explicitly allocating
memory in different parts of OpenSBI. This leads to a bloated BSS
section in the firmware binaries and this will continue to grow as
more drivers (and frameworks) with global variables are added.
To improve memory utilizaiton in OpenSBI:
1) We introduce a simple heap allocator which based on linked list.
This is a reasonable heap implementation to start with because
heap allocation and free-up won't be in hot path.
2) Use a combination of heap allocations and scratch space allocations
to improve the reduce the BSS memory foot-print.
As a by-product, this series also redunces global arrays indexed by hartid
which is preparatory work for the upcoming full sparse hartid support.
These patches can also be found in simple_heap_v1 branch at:
https://github.com/avpatel/opensbi.git
Anup Patel (17):
platform: Allow platforms to specify heap size
lib: sbi: Introduce simple heap allocator
lib: sbi: Print scratch size and usage at boot time
lib: sbi_pmu: Use heap for per-HART PMU state
lib: sbi: Use heap for root domain creation
lib: sbi: Use scratch space to save per-HART domain pointer
lib: utils/gpio: Use heap in SiFive and StartFive GPIO drivers
lib: utils/i2c: Use heap in DesignWare and SiFive I2C drivers
lib: utils/ipi: Use heap in ACLINT MSWI driver
lib: utils/irqchip: Use heap in PLIC, APLIC and IMSIC drivers
lib: utils/timer: Use heap in ACLINT MTIMER driver
lib: utils/fdt: Use heap in FDT domain parsing
lib: utils/ipi: Use scratch space to save per-HART MSWI pointer
lib: utils/timer: Use scratch space to save per-HART MTIMER pointer
lib: utils/irqchip: Use scratch space to save per-HART PLIC pointer
lib: utils/irqchip: Don't check hartid in imsic_update_hartid_table()
lib: utils/irqchip: Use scratch space to save per-HART IMSIC pointer
firmware/fw_base.S | 15 ++
include/sbi/sbi_domain.h | 6 +-
include/sbi/sbi_heap.h | 44 +++++
include/sbi/sbi_platform.h | 18 ++-
include/sbi/sbi_scratch.h | 31 ++--
lib/sbi/objects.mk | 1 +
lib/sbi/sbi_domain.c | 83 ++++++++--
lib/sbi/sbi_heap.c | 204 ++++++++++++++++++++++++
lib/sbi/sbi_init.c | 20 +++
lib/sbi/sbi_pmu.c | 221 ++++++++++++++++----------
lib/sbi/sbi_scratch.c | 11 ++
lib/utils/fdt/fdt_domain.c | 111 ++++++++-----
lib/utils/gpio/fdt_gpio_sifive.c | 21 ++-
lib/utils/gpio/fdt_gpio_starfive.c | 20 +--
lib/utils/i2c/fdt_i2c_dw.c | 24 ++-
lib/utils/i2c/fdt_i2c_sifive.c | 23 ++-
lib/utils/ipi/aclint_mswi.c | 49 ++++--
lib/utils/ipi/fdt_ipi_mswi.c | 21 ++-
lib/utils/irqchip/fdt_irqchip_aplic.c | 24 +--
lib/utils/irqchip/fdt_irqchip_imsic.c | 37 +++--
lib/utils/irqchip/fdt_irqchip_plic.c | 142 ++++++++++++-----
lib/utils/irqchip/imsic.c | 87 ++++++++--
lib/utils/timer/aclint_mtimer.c | 82 ++++++++--
lib/utils/timer/fdt_timer_mtimer.c | 47 ++++--
platform/fpga/ariane/platform.c | 1 +
platform/fpga/openpiton/platform.c | 2 +
platform/generic/platform.c | 3 +-
platform/kendryte/k210/platform.c | 2 +
platform/nuclei/ux600/platform.c | 2 +
platform/template/platform.c | 1 +
30 files changed, 1004 insertions(+), 349 deletions(-)
create mode 100644 include/sbi/sbi_heap.h
create mode 100644 lib/sbi/sbi_heap.c
--
2.34.1
next reply other threads:[~2023-04-25 12:32 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-25 12:32 Anup Patel [this message]
2023-04-25 12:32 ` [PATCH 01/17] platform: Allow platforms to specify heap size Anup Patel
2023-05-31 11:17 ` Andrew Jones
2023-04-25 12:32 ` [PATCH 02/17] lib: sbi: Introduce simple heap allocator Anup Patel
2023-05-31 12:11 ` Andrew Jones
2023-06-04 10:17 ` Anup Patel
2023-04-25 12:32 ` [PATCH 03/17] lib: sbi: Print scratch size and usage at boot time Anup Patel
2023-05-31 12:20 ` Andrew Jones
2023-04-25 12:32 ` [PATCH 04/17] lib: sbi_pmu: Use heap for per-HART PMU state Anup Patel
2023-05-31 12:32 ` Andrew Jones
2023-04-25 12:32 ` [PATCH 05/17] lib: sbi: Use heap for root domain creation Anup Patel
2023-05-31 12:34 ` Andrew Jones
2023-04-25 12:32 ` [PATCH 06/17] lib: sbi: Use scratch space to save per-HART domain pointer Anup Patel
2023-05-31 12:39 ` Andrew Jones
2023-06-04 10:38 ` Anup Patel
2023-04-25 12:32 ` [PATCH 07/17] lib: utils/gpio: Use heap in SiFive and StartFive GPIO drivers Anup Patel
2023-05-31 12:42 ` Andrew Jones
2023-04-25 12:32 ` [PATCH 08/17] lib: utils/i2c: Use heap in DesignWare and SiFive I2C drivers Anup Patel
2023-05-31 12:42 ` Andrew Jones
2023-04-25 12:32 ` [PATCH 09/17] lib: utils/ipi: Use heap in ACLINT MSWI driver Anup Patel
2023-05-31 12:43 ` Andrew Jones
2023-04-25 12:32 ` [PATCH 10/17] lib: utils/irqchip: Use heap in PLIC, APLIC and IMSIC drivers Anup Patel
2023-05-31 12:46 ` Andrew Jones
2023-06-04 11:43 ` Anup Patel
2023-04-25 12:32 ` [PATCH 11/17] lib: utils/timer: Use heap in ACLINT MTIMER driver Anup Patel
2023-05-31 12:50 ` Andrew Jones
2023-04-25 12:32 ` [PATCH 12/17] lib: utils/fdt: Use heap in FDT domain parsing Anup Patel
2023-05-31 13:02 ` Andrew Jones
2023-06-05 4:00 ` Anup Patel
2023-04-25 12:32 ` [PATCH 13/17] lib: utils/ipi: Use scratch space to save per-HART MSWI pointer Anup Patel
2023-05-31 13:03 ` Andrew Jones
2023-04-25 12:32 ` [PATCH 14/17] lib: utils/timer: Use scratch space to save per-HART MTIMER pointer Anup Patel
2023-05-31 13:06 ` Andrew Jones
2023-04-25 12:32 ` [PATCH 15/17] lib: utils/irqchip: Use scratch space to save per-HART PLIC pointer Anup Patel
2023-05-31 13:12 ` Andrew Jones
2023-06-05 5:31 ` Anup Patel
2023-06-05 5:43 ` Jessica Clarke
2023-06-05 6:51 ` Anup Patel
2023-06-05 6:57 ` Jessica Clarke
2023-06-05 11:23 ` Anup Patel
2023-04-25 12:32 ` [PATCH 16/17] lib: utils/irqchip: Don't check hartid in imsic_update_hartid_table() Anup Patel
2023-05-31 13:14 ` Andrew Jones
2023-04-25 12:32 ` [PATCH 17/17] lib: utils/irqchip: Use scratch space to save per-HART IMSIC pointer Anup Patel
2023-05-31 13:34 ` Andrew Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230425123230.3943447-1-apatel@ventanamicro.com \
--to=apatel@ventanamicro.com \
--cc=opensbi@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox