From: Anup Patel <apatel@ventanamicro.com>
To: opensbi@lists.infradead.org
Subject: [PATCH 13/17] lib: utils/ipi: Use scratch space to save per-HART MSWI pointer
Date: Tue, 25 Apr 2023 18:02:26 +0530 [thread overview]
Message-ID: <20230425123230.3943447-14-apatel@ventanamicro.com> (raw)
In-Reply-To: <20230425123230.3943447-1-apatel@ventanamicro.com>
Instead of using a global array indexed by hartid, we should use
scratch space to save per-HART MSWI pointer.
Signed-off-by: Anup Patel <apatel@ventanamicro.com>
---
lib/utils/ipi/aclint_mswi.c | 49 +++++++++++++++++++++++++++++--------
1 file changed, 39 insertions(+), 10 deletions(-)
diff --git a/lib/utils/ipi/aclint_mswi.c b/lib/utils/ipi/aclint_mswi.c
index 6b004cb..a8a2872 100644
--- a/lib/utils/ipi/aclint_mswi.c
+++ b/lib/utils/ipi/aclint_mswi.c
@@ -12,21 +12,36 @@
#include <sbi/riscv_io.h>
#include <sbi/sbi_domain.h>
#include <sbi/sbi_error.h>
-#include <sbi/sbi_hartmask.h>
#include <sbi/sbi_ipi.h>
+#include <sbi/sbi_scratch.h>
#include <sbi/sbi_timer.h>
#include <sbi_utils/ipi/aclint_mswi.h>
-static struct aclint_mswi_data *mswi_hartid2data[SBI_HARTMASK_MAX_BITS];
+static unsigned long mswi_ptr_offset;
+
+#define mswi_get_hart_data_ptr(__scratch) \
+({ \
+ (void *)(*((ulong *)sbi_scratch_offset_ptr((__scratch), \
+ mswi_ptr_offset))); \
+})
+
+#define mswi_set_hart_data_ptr(__scratch, __mswi) \
+do { \
+ *((ulong *)sbi_scratch_offset_ptr((__scratch), mswi_ptr_offset))\
+ = (ulong)(__mswi); \
+} while (0)
static void mswi_ipi_send(u32 target_hart)
{
u32 *msip;
+ struct sbi_scratch *scratch;
struct aclint_mswi_data *mswi;
- if (SBI_HARTMASK_MAX_BITS <= target_hart)
+ scratch = sbi_hartid_to_scratch(target_hart);
+ if (!scratch)
return;
- mswi = mswi_hartid2data[target_hart];
+
+ mswi = mswi_get_hart_data_ptr(scratch);
if (!mswi)
return;
@@ -38,11 +53,14 @@ static void mswi_ipi_send(u32 target_hart)
static void mswi_ipi_clear(u32 target_hart)
{
u32 *msip;
+ struct sbi_scratch *scratch;
struct aclint_mswi_data *mswi;
- if (SBI_HARTMASK_MAX_BITS <= target_hart)
+ scratch = sbi_hartid_to_scratch(target_hart);
+ if (!scratch)
return;
- mswi = mswi_hartid2data[target_hart];
+
+ mswi = mswi_get_hart_data_ptr(scratch);
if (!mswi)
return;
@@ -69,19 +87,30 @@ int aclint_mswi_cold_init(struct aclint_mswi_data *mswi)
{
u32 i;
int rc;
+ struct sbi_scratch *scratch;
unsigned long pos, region_size;
struct sbi_domain_memregion reg;
/* Sanity checks */
if (!mswi || (mswi->addr & (ACLINT_MSWI_ALIGN - 1)) ||
(mswi->size < (mswi->hart_count * sizeof(u32))) ||
- (mswi->first_hartid >= SBI_HARTMASK_MAX_BITS) ||
(mswi->hart_count > ACLINT_MSWI_MAX_HARTS))
return SBI_EINVAL;
- /* Update MSWI hartid table */
- for (i = 0; i < mswi->hart_count; i++)
- mswi_hartid2data[mswi->first_hartid + i] = mswi;
+ /* Allocate scratch space pointer */
+ if (!mswi_ptr_offset) {
+ mswi_ptr_offset = sbi_scratch_alloc_offset(sizeof(ulong));
+ if (!mswi_ptr_offset)
+ return SBI_ENOMEM;
+ }
+
+ /* Update MSWI pointer in scratch space */
+ for (i = 0; i < mswi->hart_count; i++) {
+ scratch = sbi_hartid_to_scratch(mswi->first_hartid + i);
+ if (!scratch)
+ return SBI_ENOENT;
+ mswi_set_hart_data_ptr(scratch, mswi);
+ }
/* Add MSWI regions to the root domain */
for (pos = 0; pos < mswi->size; pos += ACLINT_MSWI_ALIGN) {
--
2.34.1
next prev parent reply other threads:[~2023-04-25 12:32 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-25 12:32 [PATCH 00/17] Introduce and use simple heap allocator Anup Patel
2023-04-25 12:32 ` [PATCH 01/17] platform: Allow platforms to specify heap size Anup Patel
2023-05-31 11:17 ` Andrew Jones
2023-04-25 12:32 ` [PATCH 02/17] lib: sbi: Introduce simple heap allocator Anup Patel
2023-05-31 12:11 ` Andrew Jones
2023-06-04 10:17 ` Anup Patel
2023-04-25 12:32 ` [PATCH 03/17] lib: sbi: Print scratch size and usage at boot time Anup Patel
2023-05-31 12:20 ` Andrew Jones
2023-04-25 12:32 ` [PATCH 04/17] lib: sbi_pmu: Use heap for per-HART PMU state Anup Patel
2023-05-31 12:32 ` Andrew Jones
2023-04-25 12:32 ` [PATCH 05/17] lib: sbi: Use heap for root domain creation Anup Patel
2023-05-31 12:34 ` Andrew Jones
2023-04-25 12:32 ` [PATCH 06/17] lib: sbi: Use scratch space to save per-HART domain pointer Anup Patel
2023-05-31 12:39 ` Andrew Jones
2023-06-04 10:38 ` Anup Patel
2023-04-25 12:32 ` [PATCH 07/17] lib: utils/gpio: Use heap in SiFive and StartFive GPIO drivers Anup Patel
2023-05-31 12:42 ` Andrew Jones
2023-04-25 12:32 ` [PATCH 08/17] lib: utils/i2c: Use heap in DesignWare and SiFive I2C drivers Anup Patel
2023-05-31 12:42 ` Andrew Jones
2023-04-25 12:32 ` [PATCH 09/17] lib: utils/ipi: Use heap in ACLINT MSWI driver Anup Patel
2023-05-31 12:43 ` Andrew Jones
2023-04-25 12:32 ` [PATCH 10/17] lib: utils/irqchip: Use heap in PLIC, APLIC and IMSIC drivers Anup Patel
2023-05-31 12:46 ` Andrew Jones
2023-06-04 11:43 ` Anup Patel
2023-04-25 12:32 ` [PATCH 11/17] lib: utils/timer: Use heap in ACLINT MTIMER driver Anup Patel
2023-05-31 12:50 ` Andrew Jones
2023-04-25 12:32 ` [PATCH 12/17] lib: utils/fdt: Use heap in FDT domain parsing Anup Patel
2023-05-31 13:02 ` Andrew Jones
2023-06-05 4:00 ` Anup Patel
2023-04-25 12:32 ` Anup Patel [this message]
2023-05-31 13:03 ` [PATCH 13/17] lib: utils/ipi: Use scratch space to save per-HART MSWI pointer Andrew Jones
2023-04-25 12:32 ` [PATCH 14/17] lib: utils/timer: Use scratch space to save per-HART MTIMER pointer Anup Patel
2023-05-31 13:06 ` Andrew Jones
2023-04-25 12:32 ` [PATCH 15/17] lib: utils/irqchip: Use scratch space to save per-HART PLIC pointer Anup Patel
2023-05-31 13:12 ` Andrew Jones
2023-06-05 5:31 ` Anup Patel
2023-06-05 5:43 ` Jessica Clarke
2023-06-05 6:51 ` Anup Patel
2023-06-05 6:57 ` Jessica Clarke
2023-06-05 11:23 ` Anup Patel
2023-04-25 12:32 ` [PATCH 16/17] lib: utils/irqchip: Don't check hartid in imsic_update_hartid_table() Anup Patel
2023-05-31 13:14 ` Andrew Jones
2023-04-25 12:32 ` [PATCH 17/17] lib: utils/irqchip: Use scratch space to save per-HART IMSIC pointer Anup Patel
2023-05-31 13:34 ` Andrew Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230425123230.3943447-14-apatel@ventanamicro.com \
--to=apatel@ventanamicro.com \
--cc=opensbi@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox