From: Andrew Jones <ajones@ventanamicro.com>
To: opensbi@lists.infradead.org
Subject: [PATCH 1/3] Makefile: clean auto-generated *.c files properly
Date: Mon, 22 Apr 2024 17:19:41 +0200 [thread overview]
Message-ID: <20240422-57f6d7d8e00b7b11cf364cb1@orel> (raw)
In-Reply-To: <20240401213438.590209-2-ivan.orlov0322@gmail.com>
On Mon, Apr 01, 2024 at 10:34:36PM +0100, Ivan Orlov wrote:
> Currently, `make clean` doesn't remove auto-generated .c files in the
> `build/` directory. It means that we don't have a reliable way of
> regenerating these files except from removing the `build/` directory
> manually.
>
> Update the `clean` target in order to remove these files as well.
>
> In the discussion of the "[PATCH v2 3/5] Makefile: clean '.c' files
> generated by carray", Andrew Jones <ajones@ventanamicro.com> suggested
> placing the auto-generated .c files into the `build/generated/` folder.
> However, I believe it may not be necessary as in fact all of the files
> in `build/` are auto-generated.
Since the Makefile enforces that the build dir is not the same as the
source dir and the only C files we currently generate are carray files,
then OK. I still think it would be nice to be more specific about what
we clean, though.
>
> Signed-off-by: Ivan Orlov <ivan.orlov0322@gmail.com>
> ---
> Makefile | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Makefile b/Makefile
> index 680c19a..4519277 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -684,6 +684,8 @@ clean:
> $(CMD_PREFIX)find $(build_dir) -type f -name "*.bin" -exec rm -rf {} +
> $(if $(V), @echo " RM $(build_dir)/*.dtb")
> $(CMD_PREFIX)find $(build_dir) -type f -name "*.dtb" -exec rm -rf {} +
> + $(if $(V), @echo " RM $(build_dir)/*.c")
> + $(CMD_PREFIX)find $(build_dir) -type f -name "*.c" -exec rm -rf {} +
>
> # Rule for "make distclean"
> .PHONY: distclean
> --
> 2.34.1
>
Reviewed-by: Andrew Jones <ajones@ventanamicro.com>
next prev parent reply other threads:[~2024-04-22 15:19 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-01 21:34 [PATCH 0/3] CArray improvements Ivan Orlov
2024-04-01 21:34 ` [PATCH 1/3] Makefile: clean auto-generated *.c files properly Ivan Orlov
2024-04-22 15:19 ` Andrew Jones [this message]
2024-04-23 14:58 ` Ivan Orlov
2024-04-23 15:15 ` Ben Dooks
2024-04-23 15:18 ` Andrew Jones
2024-04-23 15:20 ` Ben Dooks
2024-04-23 15:24 ` Ben Dooks
2024-04-23 15:26 ` Ben Dooks
2024-04-23 15:41 ` Ivan Orlov
2024-04-26 16:25 ` Ben Dooks
2024-04-29 8:52 ` Andrew Jones
2024-04-29 12:16 ` Ben Dooks
2024-04-29 13:11 ` Ben Dooks
2024-04-01 21:34 ` [PATCH 2/3] scripts/carray.sh: Add comment to generated files Ivan Orlov
2024-04-22 15:21 ` Andrew Jones
2024-04-23 15:25 ` Ben Dooks
2024-04-01 21:34 ` [PATCH 3/3] docs: writing tests: update cleaning instructions Ivan Orlov
2024-04-22 15:22 ` Andrew Jones
2024-05-07 6:06 ` [PATCH 0/3] CArray improvements Anup Patel
2024-05-10 15:56 ` Ivan Orlov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240422-57f6d7d8e00b7b11cf364cb1@orel \
--to=ajones@ventanamicro.com \
--cc=opensbi@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox