From: Ben Dooks <ben.dooks@codethink.co.uk>
To: opensbi@lists.infradead.org
Subject: [PATCH 2/3] scripts/carray.sh: Add comment to generated files
Date: Tue, 23 Apr 2024 16:25:29 +0100 [thread overview]
Message-ID: <b6ea6c8b-28bf-4c4c-8bb2-cf3ed94eae1d@codethink.co.uk> (raw)
In-Reply-To: <20240401213438.590209-3-ivan.orlov0322@gmail.com>
On 01/04/2024 22:34, Ivan Orlov wrote:
> Add a comment about where auto-generated file came from to the carray.sh
> output. This should help avoiding confusion for the developers looking
> at the build artifacts and finding .c files there.
>
> Signed-off-by: Ivan Orlov <ivan.orlov0322@gmail.com>
> ---
> scripts/carray.sh | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/scripts/carray.sh b/scripts/carray.sh
> index 13f9d36..1fa2366 100755
> --- a/scripts/carray.sh
> +++ b/scripts/carray.sh
> @@ -61,6 +61,7 @@ if [ -z "${ARRAY_NAME}" ]; then
> usage
> fi
>
> +printf "// Generated with $(basename $0) from $(basename ${CONFIG_FILE})\n"
> printf "#include <%s>\n\n" "${TYPE_HEADER}"
>
> for VAR in ${VAR_LIST}; do
minor nit, "Auto generated" might be a better comment start.
--
Ben Dooks http://www.codethink.co.uk/
Senior Engineer Codethink - Providing Genius
https://www.codethink.co.uk/privacy.html
next prev parent reply other threads:[~2024-04-23 15:25 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-01 21:34 [PATCH 0/3] CArray improvements Ivan Orlov
2024-04-01 21:34 ` [PATCH 1/3] Makefile: clean auto-generated *.c files properly Ivan Orlov
2024-04-22 15:19 ` Andrew Jones
2024-04-23 14:58 ` Ivan Orlov
2024-04-23 15:15 ` Ben Dooks
2024-04-23 15:18 ` Andrew Jones
2024-04-23 15:20 ` Ben Dooks
2024-04-23 15:24 ` Ben Dooks
2024-04-23 15:26 ` Ben Dooks
2024-04-23 15:41 ` Ivan Orlov
2024-04-26 16:25 ` Ben Dooks
2024-04-29 8:52 ` Andrew Jones
2024-04-29 12:16 ` Ben Dooks
2024-04-29 13:11 ` Ben Dooks
2024-04-01 21:34 ` [PATCH 2/3] scripts/carray.sh: Add comment to generated files Ivan Orlov
2024-04-22 15:21 ` Andrew Jones
2024-04-23 15:25 ` Ben Dooks [this message]
2024-04-01 21:34 ` [PATCH 3/3] docs: writing tests: update cleaning instructions Ivan Orlov
2024-04-22 15:22 ` Andrew Jones
2024-05-07 6:06 ` [PATCH 0/3] CArray improvements Anup Patel
2024-05-10 15:56 ` Ivan Orlov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b6ea6c8b-28bf-4c4c-8bb2-cf3ed94eae1d@codethink.co.uk \
--to=ben.dooks@codethink.co.uk \
--cc=opensbi@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox