From: Clément Léger <cleger@rivosinc.com>
To: opensbi@lists.infradead.org
Subject: [PATCH v3 2/4] lib: sbi: fwft: add support for SBI_FWFT_MISALIGNED_EXC_DELEG
Date: Wed, 19 Jun 2024 11:42:40 +0200 [thread overview]
Message-ID: <20240619094244.603628-3-cleger@rivosinc.com> (raw)
In-Reply-To: <20240619094244.603628-1-cleger@rivosinc.com>
Add support for SBI_FWFT_MISALIGNED_EXC_DELEG withing FWFT support. This
support allows to delegate misaligned accesses traps.
Signed-off-by: Cl?ment L?ger <cleger@rivosinc.com>
---
lib/sbi/sbi_fwft.c | 39 ++++++++++++++++++++++++++++++++++++++-
lib/sbi/sbi_hsm.c | 3 +++
2 files changed, 41 insertions(+), 1 deletion(-)
diff --git a/lib/sbi/sbi_fwft.c b/lib/sbi/sbi_fwft.c
index b302b5d..289a344 100644
--- a/lib/sbi/sbi_fwft.c
+++ b/lib/sbi/sbi_fwft.c
@@ -32,6 +32,8 @@ static unsigned long fwft_ptr_offset;
#define fwft_set_hart_state_ptr(__scratch, __phs) \
sbi_scratch_write_type((__scratch), void *, fwft_ptr_offset, (__phs))
+#define MIS_DELEG (1UL << CAUSE_MISALIGNED_LOAD | 1UL << CAUSE_MISALIGNED_STORE)
+
struct fwft_config;
struct fwft_feature {
@@ -71,6 +73,33 @@ static bool fwft_is_defined_feature(enum sbi_fwft_feature_t feature)
return false;
}
+static int fwft_misaligned_delegation_supported(struct fwft_config *conf)
+{
+ if (!misa_extension('S'))
+ return SBI_ENOTSUPP;
+
+ return SBI_OK;
+}
+
+static int fwft_set_misaligned_delegation(struct fwft_config *conf,
+ unsigned long value)
+{
+ if (value)
+ csr_set(CSR_MEDELEG, MIS_DELEG);
+ else
+ csr_clear(CSR_MEDELEG, MIS_DELEG);
+
+ return SBI_OK;
+}
+
+static int fwft_get_misaligned_delegation(struct fwft_config *conf,
+ unsigned long *value)
+{
+ *value = (csr_read(CSR_MEDELEG) & MIS_DELEG) != 0;
+
+ return SBI_OK;
+}
+
static struct fwft_config* get_feature_config(enum sbi_fwft_feature_t feature)
{
int i;
@@ -148,7 +177,15 @@ int sbi_fwft_get(enum sbi_fwft_feature_t feature, unsigned long *out_val)
return conf->feature->get(conf, out_val);
}
-static const struct fwft_feature features[] = {};
+static const struct fwft_feature features[] =
+{
+ {
+ .id = SBI_FWFT_MISALIGNED_EXC_DELEG,
+ .supported = fwft_misaligned_delegation_supported,
+ .set = fwft_set_misaligned_delegation,
+ .get = fwft_get_misaligned_delegation,
+ },
+};
int sbi_fwft_init(struct sbi_scratch *scratch, bool cold_boot)
{
diff --git a/lib/sbi/sbi_hsm.c b/lib/sbi/sbi_hsm.c
index be48d64..2b23e13 100644
--- a/lib/sbi/sbi_hsm.c
+++ b/lib/sbi/sbi_hsm.c
@@ -44,6 +44,7 @@ struct sbi_hsm_data {
unsigned long suspend_type;
unsigned long saved_mie;
unsigned long saved_mip;
+ unsigned long saved_medeleg;
atomic_t start_ticket;
};
@@ -417,6 +418,7 @@ void __sbi_hsm_suspend_non_ret_save(struct sbi_scratch *scratch)
hdata->saved_mie = csr_read(CSR_MIE);
hdata->saved_mip = csr_read(CSR_MIP) & (MIP_SSIP | MIP_STIP);
+ hdata->saved_medeleg = csr_read(CSR_MEDELEG);
}
static void __sbi_hsm_suspend_non_ret_restore(struct sbi_scratch *scratch)
@@ -424,6 +426,7 @@ static void __sbi_hsm_suspend_non_ret_restore(struct sbi_scratch *scratch)
struct sbi_hsm_data *hdata = sbi_scratch_offset_ptr(scratch,
hart_data_offset);
+ csr_write(CSR_MEDELEG, hdata->saved_medeleg);
csr_write(CSR_MIE, hdata->saved_mie);
csr_set(CSR_MIP, (hdata->saved_mip & (MIP_SSIP | MIP_STIP)));
}
--
2.45.2
next prev parent reply other threads:[~2024-06-19 9:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-19 9:42 [PATCH v3 0/4] Add SBI FWFT extension support Clément Léger
2024-06-19 9:42 ` [PATCH v3 1/4] lib: sbi: add support for firmware features extension Clément Léger
2024-06-19 12:47 ` Anup Patel
2024-06-19 9:42 ` Clément Léger [this message]
2024-06-19 12:48 ` [PATCH v3 2/4] lib: sbi: fwft: add support for SBI_FWFT_MISALIGNED_EXC_DELEG Anup Patel
2024-06-21 13:50 ` Andrew Jones
2024-06-24 8:28 ` Clément Léger
2024-06-19 9:42 ` [PATCH v3 3/4] lib: sbi: fwft: add support for SBI_FWFT_PTE_AD_HW_UPDATING Clément Léger
2024-06-19 12:48 ` Anup Patel
2024-06-19 9:42 ` [PATCH v3 4/4] lib: sbi: implement SBI FWFT extension Clément Léger
2024-06-19 12:49 ` Anup Patel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240619094244.603628-3-cleger@rivosinc.com \
--to=cleger@rivosinc.com \
--cc=opensbi@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox