Re: [PATCH v4 6/6] platform: generic: spacemit: k3: override cold_boot_allowed for hart 0 only

From: E Shattow <e@freeshell.de>
To: Troy Mitchell <troy.mitchell@linux.spacemit.com>,
	opensbi@lists.infradead.org
Cc: Xianbin Zhu <xianbin.zhu@linux.spacemit.com>,
	Anup Patel <anup@brainfault.org>, Bo Gan <ganboing@gmail.com>,
	Samuel Holland <samuel.holland@sifive.com>,
	Heinrich Schuchardt <heinrich.schuchardt@canonical.com>,
	Kevin Zhang <zhangmeng.kevin@linux.spacemit.com>,
	Valentin Haudiquet <valentin.haudiquet@canonical.com>
Subject: Re: [PATCH v4 6/6] platform: generic: spacemit: k3: override cold_boot_allowed for hart 0 only
Date: Wed, 7 Oct 2026 13:58:54 -0700	[thread overview]
Message-ID: <210d8f61-6efd-413d-a7d4-87a214f50c01@freeshell.de> (raw)
In-Reply-To: <20260910-spacemit-k3-v4-6-0793b62329f6@linux.spacemit.com>

On 9/10/26 07:00, Troy Mitchell wrote:
> From: Valentin Haudiquet <valentin.haudiquet@canonical.com>
> 
> Only hart 0 is powered at reset on K3; secondary harts are started later
> through HSM. Restrict cold-boot eligibility to hart 0 instead of using
> the generic DT-configured hart mask, matching K1.
> 
> Signed-off-by: Valentin Haudiquet <valentin.haudiquet@canonical.com>
> Signed-off-by: Troy Mitchell <troy.mitchell@linux.spacemit.com>
> ---
>  platform/generic/spacemit/k3.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/platform/generic/spacemit/k3.c b/platform/generic/spacemit/k3.c
> index 967d09bf..7922ab11 100644
> --- a/platform/generic/spacemit/k3.c
> +++ b/platform/generic/spacemit/k3.c
> @@ -102,11 +102,17 @@ static int spacemit_k3_early_init(bool cold_boot)
>  	return generic_early_init(cold_boot);
>  }
>  
> +static bool spacemit_k3_cold_boot_allowed(u32 hartid)
> +{
> +	return !hartid;
> +}
> +
>  static int spacemit_k3_platform_init(const void *fdt, int nodeoff,
>  				     const struct fdt_match *match)
>  {
>  	spacemit_k3_hart_init(current_hartid());
>  	generic_platform_ops.early_init = spacemit_k3_early_init;
> +	generic_platform_ops.cold_boot_allowed = spacemit_k3_cold_boot_allowed;
>  
>  	return 0;
>  }
> 

Reviewed-by: E Shattow <e@freeshell.de>

-- 
opensbi mailing list
opensbi@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/opensbi