Re: [PATCH v4 3/6] platform: generic: spacemit: k1: move hart init to nascent hook

From: E Shattow <e@freeshell.de>
To: Troy Mitchell <troy.mitchell@linux.spacemit.com>,
	opensbi@lists.infradead.org
Cc: Xianbin Zhu <xianbin.zhu@linux.spacemit.com>,
	Anup Patel <anup@brainfault.org>, Bo Gan <ganboing@gmail.com>,
	Samuel Holland <samuel.holland@sifive.com>,
	Heinrich Schuchardt <heinrich.schuchardt@canonical.com>,
	Kevin Zhang <zhangmeng.kevin@linux.spacemit.com>
Subject: Re: [PATCH v4 3/6] platform: generic: spacemit: k1: move hart init to nascent hook
Date: Wed, 7 Oct 2026 14:14:05 -0700	[thread overview]
Message-ID: <914fcfdb-289f-4aef-a223-2d7303498972@freeshell.de> (raw)
In-Reply-To: <20260910-spacemit-k3-v4-3-0793b62329f6@linux.spacemit.com>

Hi Troy,

On 9/10/26 07:00, Troy Mitchell wrote:
> cold_boot_allowed() is a policy query and should not modify per-hart
> state. The K1 callback currently programs ML2SETUP as a side effect.
> 
> Move the ML2SETUP programming to nascent_init(), which runs on every
> hart before common initialization. Chain generic_nascent_init() to keep
> the generic per-hart setup intact.
> 
> Fixes: 1f84ec2ac22e ("platform: generic: spacemit: add K1")
> Reported-by: Bo Gan <ganboing@gmail.com>
> Link: https://lore.kernel.org/r/56220293-88e3-451f-833e-8251656a83d9@gmail.com
> Signed-off-by: Troy Mitchell <troy.mitchell@linux.spacemit.com>
> Reviewed-by: Bo Gan <ganboing@gmail.com>
> ---
>  platform/generic/spacemit/k1.c | 12 ++++++++++--
>  1 file changed, 10 insertions(+), 2 deletions(-)
> 
> diff --git a/platform/generic/spacemit/k1.c b/platform/generic/spacemit/k1.c
> index 7ee5f17a..19a9b27c 100644
> --- a/platform/generic/spacemit/k1.c
> +++ b/platform/generic/spacemit/k1.c
> @@ -8,6 +8,7 @@
>   */
>  
>  #include <platform_override.h>
> +#include <sbi/riscv_asm.h>
>  #include <sbi/riscv_io.h>
>  #include <sbi/sbi_hsm.h>
>  #include <spacemit/k1.h>
> @@ -86,16 +87,23 @@ static int spacemit_k1_early_init(bool cold_boot)
>  	return 0;
>  }
>  
> -static bool spacemit_cold_boot_allowed(u32 hartid)
> +static int spacemit_k1_nascent_init(void)
>  {
> -	csr_set(CSR_ML2SETUP, 1 << (hartid % PLATFORM_MAX_CPUS_PER_CLUSTER));
> +	csr_set(CSR_ML2SETUP,
> +		1 << (current_hartid() % PLATFORM_MAX_CPUS_PER_CLUSTER));

I think use BIT macro here for bitwise left-shift unless some reason not to?

> +
> +	return generic_nascent_init();
> +}
>  
> +static bool spacemit_cold_boot_allowed(u32 hartid)
> +{
>  	return !hartid;
>  }
>  
>  static int spacemit_k1_platform_init(const void *fdt, int nodeoff,
>  				     const struct fdt_match *match)
>  {
> +	generic_platform_ops.nascent_init = spacemit_k1_nascent_init;
>  	generic_platform_ops.early_init = spacemit_k1_early_init;
>  	generic_platform_ops.cold_boot_allowed = spacemit_cold_boot_allowed;
>  
> 

-E

-- 
opensbi mailing list
opensbi@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/opensbi