From: "Radim Krčmář" <rkrcmar@ventanamicro.com>
To: "Anup Patel" <anup@brainfault.org>
Cc: <opensbi@lists.infradead.org>
Subject: Re: [PATCH 7/8] lib: sbi_hart: add Ssstateen extension
Date: Mon, 28 Apr 2025 15:47:30 +0200 [thread overview]
Message-ID: <D9IBHEG15AYR.122VJJYNT9QGQ@ventanamicro.com> (raw)
In-Reply-To: <CAAhSdy0_3DrkKWTcA57KDmCgEWV+1Be2hkh8LxrnyO_RXSjzog@mail.gmail.com>
2025-04-28T18:08:12+05:30, Anup Patel <anup@brainfault.org>:
> On Tue, Apr 15, 2025 at 8:13 PM Radim Krčmář <rkrcmar@ventanamicro.com> wrote:
>>
>> We already detect Smstateen, but Ssstateen exists as well and it doesn't
>> have the M-state CSRs.
>>
>> Signed-off-by: Radim Krčmář <rkrcmar@ventanamicro.com>
>> ---
>> diff --git a/include/sbi/sbi_hart.h b/include/sbi/sbi_hart.h
>> @@ -31,7 +31,7 @@ enum sbi_hart_extensions {
>> SBI_HART_EXT_SMAIA = 0,
>> /** HART has Smepmp */
>> SBI_HART_EXT_SMEPMP,
>> - /** HART has Smstateen CSR **/
>> + /** HART has mstateen*, sstateen*, and hstateen* CSRs **/
>
> Let's not define what Smstateen means here.
>
> Smstateen implies only mstateen CSRs whereas
> Sstateeen implies [h|s]stateen CSRs.
The spec actually says that Smstateen is all of the CSRs and Sstateeen
misses mstateen*, but yeah, it's not that important...
Can I remove the comments instead?
SBI_HART_EXT_SMSTATEEN is obviously Smstateen, so I don't see the point
of the comment.
--
opensbi mailing list
opensbi@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/opensbi
next prev parent reply other threads:[~2025-04-28 13:55 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-15 13:19 [PATCH 0/8] Reset more security-related CSRs Radim Krčmář
2025-04-15 13:19 ` [PATCH 1/8] lib: sbi: add 64 bit csr macros Radim Krčmář
2025-04-28 12:28 ` Anup Patel
2025-04-28 13:48 ` Radim Krčmář
2025-04-15 13:19 ` [PATCH 2/8] lib: sbi: use " Radim Krčmář
2025-04-28 12:29 ` Anup Patel
2025-04-15 13:19 ` [PATCH 3/8] lib: sbi_hart: reset hstatus Radim Krčmář
2025-04-28 12:27 ` Anup Patel
2025-04-15 13:19 ` [PATCH 4/8] lib: sbi_hart: reset sstateen and hstateen Radim Krčmář
2025-04-28 12:29 ` Anup Patel
2025-04-15 13:19 ` [PATCH 5/8] lib: sbi_hart: fix sstateen emulation Radim Krčmář
2025-04-28 12:34 ` Anup Patel
2025-04-15 13:19 ` [PATCH 6/8] lib: sbi_hart: reset mstateen0 Radim Krčmář
2025-04-28 12:35 ` Anup Patel
2025-04-15 13:19 ` [PATCH 7/8] lib: sbi_hart: add Ssstateen extension Radim Krčmář
2025-04-28 12:38 ` Anup Patel
2025-04-28 13:47 ` Radim Krčmář [this message]
2025-04-29 5:30 ` Anup Patel
2025-04-15 13:19 ` [PATCH 8/8] lib: sbi_hart: properly reset Ssstateen Radim Krčmář
2025-04-28 12:39 ` Anup Patel
2025-04-28 13:44 ` Radim Krčmář
2025-04-28 12:41 ` [PATCH 0/8] Reset more security-related CSRs Anup Patel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D9IBHEG15AYR.122VJJYNT9QGQ@ventanamicro.com \
--to=rkrcmar@ventanamicro.com \
--cc=anup@brainfault.org \
--cc=opensbi@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox