* [PATCH v2] lib: sbi: sbi_ecall: Check the range of SBI error
@ 2023-02-22 2:48 Yu Chien Peter Lin
2023-02-22 12:24 ` Andrew Jones
2023-02-27 6:23 ` Anup Patel
0 siblings, 2 replies; 4+ messages in thread
From: Yu Chien Peter Lin @ 2023-02-22 2:48 UTC (permalink / raw)
To: opensbi
We should also check if the return error code is greater than 0
(SBI_SUCCESS), as this is an invalid error.
Signed-off-by: Yu Chien Peter Lin <peterlin@andestech.com>
Reviewed-by: Xiang W <wxjstz@126.com>
---
Changes v1 -> v2:
- Include Xiang's Reviewed-by
- Drop the 'ret -> out_err' rename
---
lib/sbi/sbi_ecall.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/sbi/sbi_ecall.c b/lib/sbi/sbi_ecall.c
index 27ce5d49..d0f01665 100644
--- a/lib/sbi/sbi_ecall.c
+++ b/lib/sbi/sbi_ecall.c
@@ -120,7 +120,7 @@ int sbi_ecall_handler(struct sbi_trap_regs *regs)
trap.epc = regs->mepc;
sbi_trap_redirect(regs, &trap);
} else {
- if (ret < SBI_LAST_ERR) {
+ if (ret < SBI_LAST_ERR || SBI_SUCCESS < ret) {
sbi_printf("%s: Invalid error %d for ext=0x%lx "
"func=0x%lx\n", __func__, ret,
extension_id, func_id);
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH v2] lib: sbi: sbi_ecall: Check the range of SBI error
2023-02-22 2:48 [PATCH v2] lib: sbi: sbi_ecall: Check the range of SBI error Yu Chien Peter Lin
@ 2023-02-22 12:24 ` Andrew Jones
2023-02-23 10:50 ` Yu-Chien Peter Lin
2023-02-27 6:23 ` Anup Patel
1 sibling, 1 reply; 4+ messages in thread
From: Andrew Jones @ 2023-02-22 12:24 UTC (permalink / raw)
To: opensbi
On Wed, Feb 22, 2023 at 10:48:54AM +0800, Yu Chien Peter Lin wrote:
> We should also check if the return error code is greater than 0
> (SBI_SUCCESS), as this is an invalid error.
>
> Signed-off-by: Yu Chien Peter Lin <peterlin@andestech.com>
> Reviewed-by: Xiang W <wxjstz@126.com>
> ---
> Changes v1 -> v2:
> - Include Xiang's Reviewed-by
> - Drop the 'ret -> out_err' rename
The SBI_ENOTSUPP -> SBI_ERR_NOT_SUPPORTED rename was also dropped, but as
Anup suggests, we should probably do a full rework of that in another
series later.
Reviewed-by: Andrew Jones <ajones@ventanamicro.com>
Thanks,
drew
> ---
> lib/sbi/sbi_ecall.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/sbi/sbi_ecall.c b/lib/sbi/sbi_ecall.c
> index 27ce5d49..d0f01665 100644
> --- a/lib/sbi/sbi_ecall.c
> +++ b/lib/sbi/sbi_ecall.c
> @@ -120,7 +120,7 @@ int sbi_ecall_handler(struct sbi_trap_regs *regs)
> trap.epc = regs->mepc;
> sbi_trap_redirect(regs, &trap);
> } else {
> - if (ret < SBI_LAST_ERR) {
> + if (ret < SBI_LAST_ERR || SBI_SUCCESS < ret) {
> sbi_printf("%s: Invalid error %d for ext=0x%lx "
> "func=0x%lx\n", __func__, ret,
> extension_id, func_id);
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH v2] lib: sbi: sbi_ecall: Check the range of SBI error
2023-02-22 12:24 ` Andrew Jones
@ 2023-02-23 10:50 ` Yu-Chien Peter Lin
0 siblings, 0 replies; 4+ messages in thread
From: Yu-Chien Peter Lin @ 2023-02-23 10:50 UTC (permalink / raw)
To: opensbi
Hi Andrew,
On Wed, Feb 22, 2023 at 01:24:05PM +0100, Andrew Jones wrote:
> On Wed, Feb 22, 2023 at 10:48:54AM +0800, Yu Chien Peter Lin wrote:
> > We should also check if the return error code is greater than 0
> > (SBI_SUCCESS), as this is an invalid error.
> >
> > Signed-off-by: Yu Chien Peter Lin <peterlin@andestech.com>
> > Reviewed-by: Xiang W <wxjstz@126.com>
> > ---
> > Changes v1 -> v2:
> > - Include Xiang's Reviewed-by
> > - Drop the 'ret -> out_err' rename
>
> The SBI_ENOTSUPP -> SBI_ERR_NOT_SUPPORTED rename was also dropped, but as
> Anup suggests, we should probably do a full rework of that in another
> series later.
>
> Reviewed-by: Andrew Jones <ajones@ventanamicro.com>
>
> Thanks,
> drew
Agreed, thanks for the review.
Best regards,
Peter Lin
>
> > ---
> > lib/sbi/sbi_ecall.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/lib/sbi/sbi_ecall.c b/lib/sbi/sbi_ecall.c
> > index 27ce5d49..d0f01665 100644
> > --- a/lib/sbi/sbi_ecall.c
> > +++ b/lib/sbi/sbi_ecall.c
> > @@ -120,7 +120,7 @@ int sbi_ecall_handler(struct sbi_trap_regs *regs)
> > trap.epc = regs->mepc;
> > sbi_trap_redirect(regs, &trap);
> > } else {
> > - if (ret < SBI_LAST_ERR) {
> > + if (ret < SBI_LAST_ERR || SBI_SUCCESS < ret) {
> > sbi_printf("%s: Invalid error %d for ext=0x%lx "
> > "func=0x%lx\n", __func__, ret,
> > extension_id, func_id);
> > --
> > 2.34.1
> >
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v2] lib: sbi: sbi_ecall: Check the range of SBI error
2023-02-22 2:48 [PATCH v2] lib: sbi: sbi_ecall: Check the range of SBI error Yu Chien Peter Lin
2023-02-22 12:24 ` Andrew Jones
@ 2023-02-27 6:23 ` Anup Patel
1 sibling, 0 replies; 4+ messages in thread
From: Anup Patel @ 2023-02-27 6:23 UTC (permalink / raw)
To: opensbi
On Wed, Feb 22, 2023 at 8:19 AM Yu Chien Peter Lin
<peterlin@andestech.com> wrote:
>
> We should also check if the return error code is greater than 0
> (SBI_SUCCESS), as this is an invalid error.
>
> Signed-off-by: Yu Chien Peter Lin <peterlin@andestech.com>
> Reviewed-by: Xiang W <wxjstz@126.com>
Looks good to me.
Reviewed-by: Anup Patel <anup@brainfault.org>
Applied this patch to the riscv/opensbi repo.
Thanks,
Anup
> ---
> Changes v1 -> v2:
> - Include Xiang's Reviewed-by
> - Drop the 'ret -> out_err' rename
> ---
> lib/sbi/sbi_ecall.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/sbi/sbi_ecall.c b/lib/sbi/sbi_ecall.c
> index 27ce5d49..d0f01665 100644
> --- a/lib/sbi/sbi_ecall.c
> +++ b/lib/sbi/sbi_ecall.c
> @@ -120,7 +120,7 @@ int sbi_ecall_handler(struct sbi_trap_regs *regs)
> trap.epc = regs->mepc;
> sbi_trap_redirect(regs, &trap);
> } else {
> - if (ret < SBI_LAST_ERR) {
> + if (ret < SBI_LAST_ERR || SBI_SUCCESS < ret) {
> sbi_printf("%s: Invalid error %d for ext=0x%lx "
> "func=0x%lx\n", __func__, ret,
> extension_id, func_id);
> --
> 2.34.1
>
>
> --
> opensbi mailing list
> opensbi at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/opensbi
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-02-27 6:23 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-02-22 2:48 [PATCH v2] lib: sbi: sbi_ecall: Check the range of SBI error Yu Chien Peter Lin
2023-02-22 12:24 ` Andrew Jones
2023-02-23 10:50 ` Yu-Chien Peter Lin
2023-02-27 6:23 ` Anup Patel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox