OpenSBI Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] lib: utils/irqchip: plic: support T-HEAD C910 PLIC
@ 2023-05-07 18:28 Jisheng Zhang
  2023-05-08  6:29 ` Guo Ren
  0 siblings, 1 reply; 3+ messages in thread
From: Jisheng Zhang @ 2023-05-07 18:28 UTC (permalink / raw)
  To: opensbi

T-HEAD's C910 PLIC still needs the delegation bit setting to allow
access from S-mode, but it doesn't need the edge quirk. To distinguish
it from C906, add C910 binding.

Signed-off-by: Jisheng Zhang <jszhang@kernel.org>
---
 lib/utils/irqchip/fdt_irqchip_plic.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/lib/utils/irqchip/fdt_irqchip_plic.c b/lib/utils/irqchip/fdt_irqchip_plic.c
index 1aadf91..ed572f7 100644
--- a/lib/utils/irqchip/fdt_irqchip_plic.c
+++ b/lib/utils/irqchip/fdt_irqchip_plic.c
@@ -165,6 +165,8 @@ static const struct fdt_match irqchip_plic_match[] = {
 	{ .compatible = "sifive,plic-1.0.0" },
 	{ .compatible = "thead,c900-plic",
 	  .data = thead_plic_plat_init },
+	{ .compatible = "thead,c910-plic",
+	  .data = thead_plic_plat_init },
 	{ /* sentinel */ }
 };
 
-- 
2.40.1



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH] lib: utils/irqchip: plic: support T-HEAD C910 PLIC
  2023-05-07 18:28 [PATCH] lib: utils/irqchip: plic: support T-HEAD C910 PLIC Jisheng Zhang
@ 2023-05-08  6:29 ` Guo Ren
  2023-05-08 16:02   ` Jisheng Zhang
  0 siblings, 1 reply; 3+ messages in thread
From: Guo Ren @ 2023-05-08  6:29 UTC (permalink / raw)
  To: opensbi

On Mon, May 8, 2023 at 2:39?AM Jisheng Zhang <jszhang@kernel.org> wrote:
>
> T-HEAD's C910 PLIC still needs the delegation bit setting to allow
> access from S-mode, but it doesn't need the edge quirk. To distinguish
> it from C906, add C910 binding.
>
> Signed-off-by: Jisheng Zhang <jszhang@kernel.org>
> ---
>  lib/utils/irqchip/fdt_irqchip_plic.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/lib/utils/irqchip/fdt_irqchip_plic.c b/lib/utils/irqchip/fdt_irqchip_plic.c
> index 1aadf91..ed572f7 100644
> --- a/lib/utils/irqchip/fdt_irqchip_plic.c
> +++ b/lib/utils/irqchip/fdt_irqchip_plic.c
> @@ -165,6 +165,8 @@ static const struct fdt_match irqchip_plic_match[] = {
>         { .compatible = "sifive,plic-1.0.0" },
>         { .compatible = "thead,c900-plic",
c900 means c906, c908, c910. There is no c900 model, it's a series name.

But still, thx for the patch. If you want to join T-HEAD SoC
maintenance work, please contact Wei Fu.
Contributions of any are welcome.

>           .data = thead_plic_plat_init },
> +       { .compatible = "thead,c910-plic",
> +         .data = thead_plic_plat_init },
>         { /* sentinel */ }
>  };
>
> --
> 2.40.1
>


-- 
Best Regards
 Guo Ren


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH] lib: utils/irqchip: plic: support T-HEAD C910 PLIC
  2023-05-08  6:29 ` Guo Ren
@ 2023-05-08 16:02   ` Jisheng Zhang
  0 siblings, 0 replies; 3+ messages in thread
From: Jisheng Zhang @ 2023-05-08 16:02 UTC (permalink / raw)
  To: opensbi

On Mon, May 08, 2023 at 02:29:16PM +0800, Guo Ren wrote:
> On Mon, May 8, 2023 at 2:39?AM Jisheng Zhang <jszhang@kernel.org> wrote:
> >
> > T-HEAD's C910 PLIC still needs the delegation bit setting to allow
> > access from S-mode, but it doesn't need the edge quirk. To distinguish
> > it from C906, add C910 binding.

Hi all,

This patch isn't needed any more, plz ignore it.
> >
> > Signed-off-by: Jisheng Zhang <jszhang@kernel.org>
> > ---
> >  lib/utils/irqchip/fdt_irqchip_plic.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/lib/utils/irqchip/fdt_irqchip_plic.c b/lib/utils/irqchip/fdt_irqchip_plic.c
> > index 1aadf91..ed572f7 100644
> > --- a/lib/utils/irqchip/fdt_irqchip_plic.c
> > +++ b/lib/utils/irqchip/fdt_irqchip_plic.c
> > @@ -165,6 +165,8 @@ static const struct fdt_match irqchip_plic_match[] = {
> >         { .compatible = "sifive,plic-1.0.0" },
> >         { .compatible = "thead,c900-plic",
> c900 means c906, c908, c910. There is no c900 model, it's a series name.

I knew C900 is the series name, I made a mistake when understanding
the PLIC edge quirk.

> 
> But still, thx for the patch. If you want to join T-HEAD SoC
> maintenance work, please contact Wei Fu.
> Contributions of any are welcome.
> 

hhh, I'm a riscv enthusiast, and got a Lichee Pi 4A board, just want
to mainline its support.


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-05-08 16:02 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-07 18:28 [PATCH] lib: utils/irqchip: plic: support T-HEAD C910 PLIC Jisheng Zhang
2023-05-08  6:29 ` Guo Ren
2023-05-08 16:02   ` Jisheng Zhang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox