[PATCH 1/2] memorder: Express `value-returning RMW` more explicitly

[PATCH 1/2] memorder: Express `value-returning RMW` more explicitly

[SeongJae Park]

A sentence represents `Successful Non-Relaced Non-void RMW' row in
`Linux-Kernel Memory-Ordering Cheat Sheet` as `value-returning RMW` row.
Because it is far different expression, some reader may confuse.  This
commit remove the confuse by representing the row with exactly same
words.

Signed-off-by: SeongJae Park <sj38.park@gmail.com>
---
 memorder/memorder.tex | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/memorder/memorder.tex b/memorder/memorder.tex
index 3e85eca..5e7176e 100644
--- a/memorder/memorder.tex
+++ b/memorder/memorder.tex
@@ -507,9 +507,9 @@ The \co{*_acquire} row covers \co{smp_load_acquire()},
 \co{cmpxchg_acquire()}, \co{xchg_release()}, and so on;
 the \co{*_release} row covers \co{smp_store_release()},
 \co{cmpxchg_release()}, \co{xchg_release()}, and so on; and
-the value-returning RMW row covers \co{atomic_add_return()},
-\co{atomic_add_unless()},
-\co{atomic_dec_and_test()}, \co{cmpxchg()}, \co{xchg()}, and so on.
+the ``Successful Non-Relaxed Non-\co{void} RMW'' row covers
+\co{atomic_add_return()}, \co{atomic_add_unless()}, \co{atomic_dec_and_test()},
+\co{cmpxchg()}, \co{xchg()}, and so on.
 The ``Successful'' qualifiers apply to primitives such as
 \co{atomic_add_unless()}, \co{cmpxchg_acquire()}, and \co{cmpxchg_release()},
 which have no effect on either memory or on ordering when they indicate
-- 
2.10.0

[PATCH 2/2] memorder: Add missed closing parenthesis

[SeongJae Park]

A closing parenthesis is missed.  This commit adds it.

Signed-off-by: SeongJae Park <sj38.park@gmail.com>
---
 memorder/memorder.tex | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/memorder/memorder.tex b/memorder/memorder.tex
index 5e7176e..b3b657b 100644
--- a/memorder/memorder.tex
+++ b/memorder/memorder.tex
@@ -596,7 +596,7 @@ are at most two threads involved.
 	ordering for any accesses preceding or following both.
 	No ordering need be provided for accesses between the
 	\co{smp_mb__before_atomic()} (or, similarly, the
-	\co{smp_mb__after_atomic()} and the atomic RMW operation, as
+	\co{smp_mb__after_atomic()}) and the atomic RMW operation, as
 	indicated by the ``a'' entries on the \co{smp_mb__before_atomic()}
 	and \co{smp_mb__after_atomic()} rows of the table.

-- 
2.10.0

Re: [PATCH 1/2] memorder: Express `value-returning RMW` more explicitly

[Paul E. McKenney]

On Sat, Sep 02, 2017 at 11:49:36AM +0900, SeongJae Park wrote:
> A sentence represents `Successful Non-Relaced Non-void RMW' row in
> `Linux-Kernel Memory-Ordering Cheat Sheet` as `value-returning RMW` row.
> Because it is far different expression, some reader may confuse.  This
> commit remove the confuse by representing the row with exactly same
> words.
> 
> Signed-off-by: SeongJae Park <sj38.park@gmail.com>

Good catches, applied both, thank you!

							Thanx, Paul

> ---
>  memorder/memorder.tex | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/memorder/memorder.tex b/memorder/memorder.tex
> index 3e85eca..5e7176e 100644
> --- a/memorder/memorder.tex
> +++ b/memorder/memorder.tex
> @@ -507,9 +507,9 @@ The \co{*_acquire} row covers \co{smp_load_acquire()},
>  \co{cmpxchg_acquire()}, \co{xchg_release()}, and so on;
>  the \co{*_release} row covers \co{smp_store_release()},
>  \co{cmpxchg_release()}, \co{xchg_release()}, and so on; and
> -the value-returning RMW row covers \co{atomic_add_return()},
> -\co{atomic_add_unless()},
> -\co{atomic_dec_and_test()}, \co{cmpxchg()}, \co{xchg()}, and so on.
> +the ``Successful Non-Relaxed Non-\co{void} RMW'' row covers
> +\co{atomic_add_return()}, \co{atomic_add_unless()}, \co{atomic_dec_and_test()},
> +\co{cmpxchg()}, \co{xchg()}, and so on.
>  The ``Successful'' qualifiers apply to primitives such as
>  \co{atomic_add_unless()}, \co{cmpxchg_acquire()}, and \co{cmpxchg_release()},
>  which have no effect on either memory or on ordering when they indicate
> -- 
> 2.10.0
> 

--
To unsubscribe from this list: send the line "unsubscribe perfbook" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  https://urldefense.proofpoint.com/v2/url?u=http-3A__vger.kernel.org_majordomo-2Dinfo.html&d=DwIBAg&c=jf_iaSHvJObTbx-siA1ZOg&r=ux41CW3B5BSVxDMRNRWyLbUmPebZc70Kq4AkfdiRGMI&m=VjmF1wSmnKfzHsjtYLhnVDL4Sn_rjJ0qmIkI1wh9cDM&s=IRasYQidXsEuhEadRYwKZtOJuZD_KbTh3IIyCMnRMLM&e=