[PATCH 1/2] locking: fix typo

[PATCH 1/2] locking: fix typo

[pierre Kuo]

From: Pierre Kuo <vichy.kuo@gmail.com>

In 7.1.1.2 Local Locking Hierarchies, below left parenthesis seems
better to be comma.

"before invoking the comparison function
(which is unknown code from qsort()’s perspective,"
^^^ change it as comma.

Signed-off-by: Pierre Kuo <vichy.kuo@gmail.com>
---
 locking/locking.tex | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/locking/locking.tex b/locking/locking.tex
index 12a0240..5921f50 100644
--- a/locking/locking.tex
+++ b/locking/locking.tex
@@ -327,7 +327,7 @@ But the first thread holds Lock~C, so the second thread's call to
 Lock~B, resulting in deadlock.

 In contrast, if \co{qsort()} releases Lock~C before invoking the
-comparison function (which is unknown code from \co{qsort()}'s perspective,
+comparison function ,which is unknown code from \co{qsort()}'s perspective,
 then deadlock is avoided as shown in
 Figure~\ref{fig:lock:Local Locking Hierarchy for qsort()}.

-- 
1.9.1

[PATCH 2/2] SMPdesign: fix typo

[pierre Kuo]

From: Pierre Kuo <vichy.kuo@gmail.com>

In 6.5.1 Work-Queue Parallel Maze Solver, the line #4 and line #5 of
listing 6.13 seem describe the cell 't' instead of cell 'n'.

Signed-off-by: Pierre Kuo <vichy.kuo@gmail.com>
---
 SMPdesign/beyond.tex | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/SMPdesign/beyond.tex b/SMPdesign/beyond.tex
index 72862c5..88e2b31 100644
--- a/SMPdesign/beyond.tex
+++ b/SMPdesign/beyond.tex
@@ -141,8 +141,8 @@ Line~20 initializes for the next pass through the outer loop.
 The pseudocode for \co{maze_try_visit_cell()} is shown on lines~1-12
 of Listing~\ref{lst:SMPdesign:SEQ Helper Pseudocode}
 (\path{maze.c}).
-Line~4 checks to see if cells \co{c} and \co{n} are adjacent and connected,
-while line~5 checks to see if cell \co{n} has not yet been visited.
+Line~4 checks to see if cells \co{c} and \co{t} are adjacent and connected,
+while line~5 checks to see if cell \co{t} has not yet been visited.
 The \co{celladdr()} function returns the address of the specified cell.
 If either check fails, line~6 returns failure.
 Line~7 indicates the next cell, line~8 records this cell in the next
-- 
1.9.1

Re: [PATCH 1/2] locking: fix typo

[Paul E. McKenney]

On Thu, Nov 02, 2017 at 02:57:48PM +0800, pierre Kuo wrote:
> From: Pierre Kuo <vichy.kuo@gmail.com>
> 
> In 7.1.1.2 Local Locking Hierarchies, below left parenthesis seems
> better to be comma.
> 
> "before invoking the comparison function
> (which is unknown code from qsort()’s perspective,"
> ^^^ change it as comma.
> 
> Signed-off-by: Pierre Kuo <vichy.kuo@gmail.com>

I queued and pushed both, thank you!

On the patch below, I interchanged the comma with the preceding space
character.

							Thanx, Paul

> ---
>  locking/locking.tex | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/locking/locking.tex b/locking/locking.tex
> index 12a0240..5921f50 100644
> --- a/locking/locking.tex
> +++ b/locking/locking.tex
> @@ -327,7 +327,7 @@ But the first thread holds Lock~C, so the second thread's call to
>  Lock~B, resulting in deadlock.
> 
>  In contrast, if \co{qsort()} releases Lock~C before invoking the
> -comparison function (which is unknown code from \co{qsort()}'s perspective,
> +comparison function ,which is unknown code from \co{qsort()}'s perspective,
>  then deadlock is avoided as shown in
>  Figure~\ref{fig:lock:Local Locking Hierarchy for qsort()}.
> 
> -- 
> 1.9.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe perfbook" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

Re: [PATCH 1/2] locking: fix typo

[pierre kuo]

hi Paul:
> On the patch below, I interchanged the comma with the preceding space
> character.
>
Got it.
BTW, I have another patch need ur review.
Would you mind to give some comment?
http://www.spinics.net/lists/perfbook/msg01522.html

Appreciate your help in advance.

Re: [PATCH 1/2] locking: fix typo

[Paul E. McKenney]

On Fri, Nov 03, 2017 at 09:23:05PM +0800, pierre kuo wrote:
> hi Paul:
> > On the patch below, I interchanged the comma with the preceding space
> > character.
> >
> Got it.
> BTW, I have another patch need ur review.
> Would you mind to give some comment?
> http://www.spinics.net/lists/perfbook/msg01522.html
> 
> Appreciate your help in advance.

I already did.

From my previous email: "I queued and pushed both, thank you!"
So your second patch is applied unchanged.  ;-)

							Thanx, Paul

Re: [PATCH 1/2] locking: fix typo

[pierre kuo]

hi Paul:
>
> I already did.
>
> From my previous email: "I queued and pushed both, thank you!"
> So your second patch is applied unchanged.  ;-)
sorry for unaware the "both" key word.
Thank U ^^