* [PATCH 1/7] datastruct: Fix wrong line number
@ 2018-11-20 0:00 SeongJae Park
2018-11-20 0:00 ` [PATCH 2/7] datastruct: Update an outdated footnote SeongJae Park
` (6 more replies)
0 siblings, 7 replies; 8+ messages in thread
From: SeongJae Park @ 2018-11-20 0:00 UTC (permalink / raw)
To: paulmck; +Cc: perfbook, SeongJae Park
Signed-off-by: SeongJae Park <sj38.park@gmail.com>
---
datastruct/datastruct.tex | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/datastruct/datastruct.tex b/datastruct/datastruct.tex
index 1dc2b49..fb8fc20 100644
--- a/datastruct/datastruct.tex
+++ b/datastruct/datastruct.tex
@@ -1549,7 +1549,7 @@ Line~17 conditionally acquires the top-level \co{->ht_lock}, and if
this acquisition fails, line~18 returns \co{-EBUSY} to indicate that
a resize is already in progress.
Otherwise, line~19 picks up a reference to the current hash table,
-and lines~21-24 allocate a new hash table of the desired size.
+and lines~20-24 allocate a new hash table of the desired size.
If a new set of hash/key functions have been specified, these are
used for the new table, otherwise those of the old table are preserved.
If line~25 detects memory-allocation failure, line~26 releases \co{->ht_lock}
--
2.10.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 2/7] datastruct: Update an outdated footnote
2018-11-20 0:00 [PATCH 1/7] datastruct: Fix wrong line number SeongJae Park
@ 2018-11-20 0:00 ` SeongJae Park
2018-11-20 0:00 ` [PATCH 3/7] count: Use '\lnref' consistently SeongJae Park
` (5 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: SeongJae Park @ 2018-11-20 0:00 UTC (permalink / raw)
To: paulmck; +Cc: perfbook, SeongJae Park
'Bits and Bytes' subsection says smartphones with gigabytes of memory as
an impossible case. However, such smartphones are prevalent now. This
commit updates the sentence for trends in these days.
Signed-off-by: SeongJae Park <sj38.park@gmail.com>
---
datastruct/datastruct.tex | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/datastruct/datastruct.tex b/datastruct/datastruct.tex
index fb8fc20..744a8cb 100644
--- a/datastruct/datastruct.tex
+++ b/datastruct/datastruct.tex
@@ -2055,7 +2055,7 @@ Fortunately, the relatively large memories available on modern
systems have allowed us to prioritize performance and simplicity
over memory overhead.
However, even with today's large-memory systems\footnote{
- Smartphones with gigabytes of memory, anyone?}
+ Smartphones with hundreds of gigabytes of memory, anyone?}
it is sometime necessary to take extreme measures to reduce
memory overhead.
--
2.10.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 3/7] count: Use '\lnref' consistently
2018-11-20 0:00 [PATCH 1/7] datastruct: Fix wrong line number SeongJae Park
2018-11-20 0:00 ` [PATCH 2/7] datastruct: Update an outdated footnote SeongJae Park
@ 2018-11-20 0:00 ` SeongJae Park
2018-11-20 0:00 ` [PATCH 4/7] toolsoftrade: Fix a typo for function name SeongJae Park
` (4 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: SeongJae Park @ 2018-11-20 0:00 UTC (permalink / raw)
To: paulmck; +Cc: perfbook, SeongJae Park
Signed-off-by: SeongJae Park <sj38.park@gmail.com>
---
count/count.tex | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/count/count.tex b/count/count.tex
index 0f35042..c465634 100644
--- a/count/count.tex
+++ b/count/count.tex
@@ -2456,8 +2456,9 @@ line~\lnref{signal} sends the thread a signal.
\QuickQuizAnswer{
There is no need for an additional check.
The caller of \co{flush_local_count()} has already invoked
- \co{globalize_count()}, so the check on line~28 will have
- succeeded, skipping the later \co{pthread_kill()}.
+ \co{globalize_count()}, so the check on
+ line~\ref{ln:count:count_lim_sig:migration:flush:checkmax}
+ will have succeeded, skipping the later \co{pthread_kill()}.
} \QuickQuizEnd
\QuickQuiz{}
--
2.10.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 4/7] toolsoftrade: Fix a typo for function name
2018-11-20 0:00 [PATCH 1/7] datastruct: Fix wrong line number SeongJae Park
2018-11-20 0:00 ` [PATCH 2/7] datastruct: Update an outdated footnote SeongJae Park
2018-11-20 0:00 ` [PATCH 3/7] count: Use '\lnref' consistently SeongJae Park
@ 2018-11-20 0:00 ` SeongJae Park
2018-11-20 0:00 ` [PATCH 5/7] toolsoftrade: Use '\co' consistently for volatile keyword SeongJae Park
` (3 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: SeongJae Park @ 2018-11-20 0:00 UTC (permalink / raw)
To: paulmck; +Cc: perfbook, SeongJae Park
---
toolsoftrade/toolsoftrade.tex | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/toolsoftrade/toolsoftrade.tex b/toolsoftrade/toolsoftrade.tex
index 0fe1038..96014b9 100644
--- a/toolsoftrade/toolsoftrade.tex
+++ b/toolsoftrade/toolsoftrade.tex
@@ -1741,7 +1741,7 @@ void work_until_shut_down(void)
However, there are exceptions, for example as shown in
Listing~\ref{lst:toolsoftrade:C Compilers Can Fuse Stores}.
\begin{lineref}[ln:toolsoftrade:C Compilers Can Fuse Stores]
-The function \co{shut_it_down(void)()} stores to the shared
+The function \co{shut_it_down()} stores to the shared
variable \co{status} on lines~\lnref{store:a} and~\lnref{store:b},
and so assuming that neither
\co{start_shutdown()} nor \co{finish_shutdown()} access \co{status},
--
2.10.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 5/7] toolsoftrade: Use '\co' consistently for volatile keyword
2018-11-20 0:00 [PATCH 1/7] datastruct: Fix wrong line number SeongJae Park
` (2 preceding siblings ...)
2018-11-20 0:00 ` [PATCH 4/7] toolsoftrade: Fix a typo for function name SeongJae Park
@ 2018-11-20 0:00 ` SeongJae Park
2018-11-20 0:00 ` [PATCH 6/7] formal/axiomatic: Fix a typo: s/Figure/Listing SeongJae Park
` (2 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: SeongJae Park @ 2018-11-20 0:00 UTC (permalink / raw)
To: paulmck; +Cc: perfbook, SeongJae Park
In a paragraph, every volatile keyword is using '\co' but one case.
This commit use '\co' for the inconsistent case.
Signed-off-by: SeongJae Park <sj38.park@gmail.com>
---
toolsoftrade/toolsoftrade.tex | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/toolsoftrade/toolsoftrade.tex b/toolsoftrade/toolsoftrade.tex
index 96014b9..ad6661b 100644
--- a/toolsoftrade/toolsoftrade.tex
+++ b/toolsoftrade/toolsoftrade.tex
@@ -1896,7 +1896,7 @@ Perhaps the most clear guidance is provided by this non-normative note:
aggressive optimization involving the object because the value
of the object might be changed by means undetectable by an
implementation.
- Furthermore, for some implementations, volatile might indicate
+ Furthermore, for some implementations, \co{volatile} might indicate
that special hardware instructions are required to access
the object.
See 6.8.1 for detailed semantics.
--
2.10.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 6/7] formal/axiomatic: Fix a typo: s/Figure/Listing
2018-11-20 0:00 [PATCH 1/7] datastruct: Fix wrong line number SeongJae Park
` (3 preceding siblings ...)
2018-11-20 0:00 ` [PATCH 5/7] toolsoftrade: Use '\co' consistently for volatile keyword SeongJae Park
@ 2018-11-20 0:00 ` SeongJae Park
2018-11-20 0:00 ` [PATCH 7/7] formal/axiomatic: Add missed parentheses for 'WRITE_ONCE()' SeongJae Park
2018-11-20 1:45 ` [PATCH 1/7] datastruct: Fix wrong line number Paul E. McKenney
6 siblings, 0 replies; 8+ messages in thread
From: SeongJae Park @ 2018-11-20 0:00 UTC (permalink / raw)
To: paulmck; +Cc: perfbook, SeongJae Park
Signed-off-by: SeongJae Park <sj38.park@gmail.com>
---
formal/axiomatic.tex | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/formal/axiomatic.tex b/formal/axiomatic.tex
index 4a3bd0c..58513eb 100644
--- a/formal/axiomatic.tex
+++ b/formal/axiomatic.tex
@@ -279,7 +279,7 @@ the \co{herd} output.
\begin{lineref}[ln:formal:C-RomanPenyaev-list-rcu-rr:whole]
A litmus test for a more complex example proposed by
Roman Penyaev~\cite{RomanPenyaev2018rrRCU} is shown in
-Figure~\ref{lst:formal:Complex RCU Litmus Test}.
+Listing~\ref{lst:formal:Complex RCU Litmus Test}.
In this example, readers (modeled by \co{P0()} on
lines~\lnref{P0start}--\lnref{P0end}) access a linked list
in a round-robin fashion by ``leaking'' a pointer to the last
--
2.10.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 7/7] formal/axiomatic: Add missed parentheses for 'WRITE_ONCE()'
2018-11-20 0:00 [PATCH 1/7] datastruct: Fix wrong line number SeongJae Park
` (4 preceding siblings ...)
2018-11-20 0:00 ` [PATCH 6/7] formal/axiomatic: Fix a typo: s/Figure/Listing SeongJae Park
@ 2018-11-20 0:00 ` SeongJae Park
2018-11-20 1:45 ` [PATCH 1/7] datastruct: Fix wrong line number Paul E. McKenney
6 siblings, 0 replies; 8+ messages in thread
From: SeongJae Park @ 2018-11-20 0:00 UTC (permalink / raw)
To: paulmck; +Cc: perfbook, SeongJae Park
Signed-off-by: SeongJae Park <sj38.park@gmail.com>
---
formal/axiomatic.tex | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/formal/axiomatic.tex b/formal/axiomatic.tex
index 58513eb..65d1b6a 100644
--- a/formal/axiomatic.tex
+++ b/formal/axiomatic.tex
@@ -383,7 +383,7 @@ in the \co{herd} output.
\QuickQuiz{}
\begin{lineref}[ln:formal:C-RomanPenyaev-list-rcu-rr:whole]
Also in Listing~\ref{lst:formal:Complex RCU Litmus Test},
- can't line~\lnref{updfree} be \co{WRITE_ONCE} instead
+ can't line~\lnref{updfree} be \co{WRITE_ONCE()} instead
of \co{smp_store_release()}?
\end{lineref}
\QuickQuizAnswer{
--
2.10.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH 1/7] datastruct: Fix wrong line number
2018-11-20 0:00 [PATCH 1/7] datastruct: Fix wrong line number SeongJae Park
` (5 preceding siblings ...)
2018-11-20 0:00 ` [PATCH 7/7] formal/axiomatic: Add missed parentheses for 'WRITE_ONCE()' SeongJae Park
@ 2018-11-20 1:45 ` Paul E. McKenney
6 siblings, 0 replies; 8+ messages in thread
From: Paul E. McKenney @ 2018-11-20 1:45 UTC (permalink / raw)
To: SeongJae Park; +Cc: perfbook
On Tue, Nov 20, 2018 at 09:00:51AM +0900, SeongJae Park wrote:
> Signed-off-by: SeongJae Park <sj38.park@gmail.com>
Good eyes! I queued and pushed the series, thank you!!!
Thanx, Paul
> ---
> datastruct/datastruct.tex | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/datastruct/datastruct.tex b/datastruct/datastruct.tex
> index 1dc2b49..fb8fc20 100644
> --- a/datastruct/datastruct.tex
> +++ b/datastruct/datastruct.tex
> @@ -1549,7 +1549,7 @@ Line~17 conditionally acquires the top-level \co{->ht_lock}, and if
> this acquisition fails, line~18 returns \co{-EBUSY} to indicate that
> a resize is already in progress.
> Otherwise, line~19 picks up a reference to the current hash table,
> -and lines~21-24 allocate a new hash table of the desired size.
> +and lines~20-24 allocate a new hash table of the desired size.
> If a new set of hash/key functions have been specified, these are
> used for the new table, otherwise those of the old table are preserved.
> If line~25 detects memory-allocation failure, line~26 releases \co{->ht_lock}
> --
> 2.10.0
>
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2018-11-20 12:11 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-11-20 0:00 [PATCH 1/7] datastruct: Fix wrong line number SeongJae Park
2018-11-20 0:00 ` [PATCH 2/7] datastruct: Update an outdated footnote SeongJae Park
2018-11-20 0:00 ` [PATCH 3/7] count: Use '\lnref' consistently SeongJae Park
2018-11-20 0:00 ` [PATCH 4/7] toolsoftrade: Fix a typo for function name SeongJae Park
2018-11-20 0:00 ` [PATCH 5/7] toolsoftrade: Use '\co' consistently for volatile keyword SeongJae Park
2018-11-20 0:00 ` [PATCH 6/7] formal/axiomatic: Fix a typo: s/Figure/Listing SeongJae Park
2018-11-20 0:00 ` [PATCH 7/7] formal/axiomatic: Add missed parentheses for 'WRITE_ONCE()' SeongJae Park
2018-11-20 1:45 ` [PATCH 1/7] datastruct: Fix wrong line number Paul E. McKenney
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox