* Re: [PATCH] count: Include atomic_nehalem.pdf instead of atomic_nehalem.png
2018-12-05 11:56 ` Akira Yokosawa
@ 2018-12-05 15:00 ` Akira Yokosawa
2018-12-05 16:35 ` Paul E. McKenney
1 sibling, 0 replies; 4+ messages in thread
From: Akira Yokosawa @ 2018-12-05 15:00 UTC (permalink / raw)
To: Paul E. McKenney; +Cc: perfbook, Akira Yokosawa
On 2018/12/05 20:56, Akira Yokosawa wrote:
> On 2018/12/05 20:00, Akira Yokosawa wrote:
>> From 213fcdaabb6daa14c1c6cfc6ff780d023478d59f Mon Sep 17 00:00:00 2001
>> From: Akira Yokosawa <akiyks@gmail.com>
>> Date: Wed, 5 Dec 2018 19:48:32 +0900
>> Subject: [PATCH] count: Include atomic_nehalem.pdf instead of atomic_nehalem.png
>>
>> Without any suffix specified, \includegraphics{} prefers .png to .pdf
>> by default.
>>
>> Fixes: 04e270767c34 ("count: Restore 'fig:count:Atomic Increment Scalability on Nehalem'")
>> Signed-off-by: Akira Yokosawa <akiyks@gmail.com>
>> ---
>> Hi Paul,
>>
>> This is a "minor fix". Obviously, I missed to check the restored figure
>> before submitting the previous patch set. ;-)
>
> Looks like this depends on TeX Live version. .png was included on
> Ubuntu Trusty's TeX Live 2013/Debian.
>
> On Ubuntu Bionic (TeX Live 2017/Debian), .pdf is included both with and
The difference comes from the version of grfext, [2010/08/19 v1.1] and
[2016/05/16 v1.2].
In v1.1, the preference list is defined as:
[.png,.pdf,.jpg,.mps,.jpeg,.jbig2,.jb2,.PNG,.PDF,.JPG,.JPEG,.JBIG2,.JB2,.eps]
In v1.2, it is defined as:
[.pdf,.png,.jpg,.mps,.jpeg,.jbig2,.jb2,.PDF,.PNG,.JPG,.JPEG,.JBIG2,.JB2,.eps]
This means .png has a higher preference on Ubuntu Xenial, too.
JFYI.
Thanks, Akira
> without this fix.
>
> Thanks, Akira
>
>>
>> Thanks, Akira
>> --
>> count/count.tex | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/count/count.tex b/count/count.tex
>> index 6fd54b5..bdbc4cd 100644
>> --- a/count/count.tex
>> +++ b/count/count.tex
>> @@ -248,7 +248,7 @@ accuracies far greater than 50\,\% are almost always necessary.
>>
>> \begin{figure}[tb]
>> \centering
>> -\resizebox{2.5in}{!}{\includegraphics{CodeSamples/count/atomic_nehalem}}
>> +\resizebox{2.5in}{!}{\includegraphics{CodeSamples/count/atomic_nehalem.pdf}}
>> \caption{Atomic Increment Scalability on Nehalem}
>> \label{fig:count:Atomic Increment Scalability on Nehalem}
>> \end{figure}
>>
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] count: Include atomic_nehalem.pdf instead of atomic_nehalem.png
2018-12-05 11:56 ` Akira Yokosawa
2018-12-05 15:00 ` Akira Yokosawa
@ 2018-12-05 16:35 ` Paul E. McKenney
1 sibling, 0 replies; 4+ messages in thread
From: Paul E. McKenney @ 2018-12-05 16:35 UTC (permalink / raw)
To: Akira Yokosawa; +Cc: perfbook
On Wed, Dec 05, 2018 at 08:56:16PM +0900, Akira Yokosawa wrote:
> On 2018/12/05 20:00, Akira Yokosawa wrote:
> > From 213fcdaabb6daa14c1c6cfc6ff780d023478d59f Mon Sep 17 00:00:00 2001
> > From: Akira Yokosawa <akiyks@gmail.com>
> > Date: Wed, 5 Dec 2018 19:48:32 +0900
> > Subject: [PATCH] count: Include atomic_nehalem.pdf instead of atomic_nehalem.png
> >
> > Without any suffix specified, \includegraphics{} prefers .png to .pdf
> > by default.
> >
> > Fixes: 04e270767c34 ("count: Restore 'fig:count:Atomic Increment Scalability on Nehalem'")
> > Signed-off-by: Akira Yokosawa <akiyks@gmail.com>
> > ---
> > Hi Paul,
> >
> > This is a "minor fix". Obviously, I missed to check the restored figure
> > before submitting the previous patch set. ;-)
>
> Looks like this depends on TeX Live version. .png was included on
> Ubuntu Trusty's TeX Live 2013/Debian.
>
> On Ubuntu Bionic (TeX Live 2017/Debian), .pdf is included both with and
> without this fix.
Queued and pushed, thank you!!!
And I must have been blind or something... It shows up in my setup,
but miniaturized. Fixed now, so all is well! ;-)
Thanx, Paul
> Thanks, Akira
>
> >
> > Thanks, Akira
> > --
> > count/count.tex | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/count/count.tex b/count/count.tex
> > index 6fd54b5..bdbc4cd 100644
> > --- a/count/count.tex
> > +++ b/count/count.tex
> > @@ -248,7 +248,7 @@ accuracies far greater than 50\,\% are almost always necessary.
> >
> > \begin{figure}[tb]
> > \centering
> > -\resizebox{2.5in}{!}{\includegraphics{CodeSamples/count/atomic_nehalem}}
> > +\resizebox{2.5in}{!}{\includegraphics{CodeSamples/count/atomic_nehalem.pdf}}
> > \caption{Atomic Increment Scalability on Nehalem}
> > \label{fig:count:Atomic Increment Scalability on Nehalem}
> > \end{figure}
> >
>
^ permalink raw reply [flat|nested] 4+ messages in thread