Discussions of the Parallel Programming book
 help / color / mirror / Atom feed
* [PATCH 1/2] memorder: Fix typos
@ 2019-01-05 19:19 SeongJae Park
  2019-01-05 19:19 ` [PATCH 2/2] debugging: Leave double dashes in description headings SeongJae Park
  2019-01-05 23:28 ` [PATCH 1/2] memorder: Fix typos Paul E. McKenney
  0 siblings, 2 replies; 3+ messages in thread
From: SeongJae Park @ 2019-01-05 19:19 UTC (permalink / raw)
  To: paulmck; +Cc: perfbook, SeongJae Park

Signed-off-by: SeongJae Park <sj38.park@gmail.com>
---
 memorder/memorder.tex | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/memorder/memorder.tex b/memorder/memorder.tex
index cb4d037..56786fa 100644
--- a/memorder/memorder.tex
+++ b/memorder/memorder.tex
@@ -541,13 +541,13 @@ Blank cells indicate that no ordering is supplied.
 The ``Store'' row also covers the store portion of an atomic RMW operation.
 In addition, the ``Load'' row covers the load
 component of a successful value-returning \co{_relaxed()} RMW atomic
-operation, although the combined ``\co{_relaxed()} RMW Operations''
+operation, although the combined ``\co{_relaxed()} RMW operation''
 line provides a convenient combined reference in the value-returning case.
 A CPU executing unsuccessful value-returning atomic RMW operations must
 invalidate the corresponding variable from all other CPUs' caches.
 Therefore, oddly enough, unsuccessful value-returning atomic RMW
 operations have many of the properties of a store, which means that the
-``\co{_relaxed()} RMW Operations'' line also applies to unsuccessful
+``\co{_relaxed()} RMW operation'' line also applies to unsuccessful
 value-returning atomic RMW operations.
 
 The \co{*_acquire} row covers \co{smp_load_acquire()},
-- 
2.10.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH 2/2] debugging: Leave double dashes in description headings
  2019-01-05 19:19 [PATCH 1/2] memorder: Fix typos SeongJae Park
@ 2019-01-05 19:19 ` SeongJae Park
  2019-01-05 23:28 ` [PATCH 1/2] memorder: Fix typos Paul E. McKenney
  1 sibling, 0 replies; 3+ messages in thread
From: SeongJae Park @ 2019-01-05 19:19 UTC (permalink / raw)
  To: paulmck; +Cc: perfbook, SeongJae Park

A description in debugging chapter is using '\tco' identifier for
command options which start with '--'.  However, '--' inside '\tco'
identifier is converted to a n-dash so that readers could misunderstood.
To avoid such confusion, this commit avoids the conversion via an ugly
walkaround.

Signed-off-by: SeongJae Park <sj38.park@gmail.com>
---
 debugging/debugging.tex | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/debugging/debugging.tex b/debugging/debugging.tex
index 67e575c..5b2ce27 100644
--- a/debugging/debugging.tex
+++ b/debugging/debugging.tex
@@ -2287,16 +2287,16 @@ and output consists of one line for each input line, with fields as follows:
 This script takes three optional arguments as follows:
 
 \begin{description}
-\item	[\tco{--divisor}\nf{:}] Number of segments to divide the list into,
-	for example, a divisor of four means that the first quarter
-	of the data elements will be assumed to be good.
+\item	[\tco{-}\tco{-divisor}\nf{:}] Number of segments to divide the list
+	into, for example, a divisor of four means that the first quarter of
+	the data elements will be assumed to be good.
 	This defaults to three.
-\item	[\tco{--relerr}\nf{:}] Relative measurement error.  The script assumes
-	that values that differ by less than this error are for all
+\item	[\tco{-}\tco{-relerr}\nf{:}] Relative measurement error.  The script
+	assumes that values that differ by less than this error are for all
 	intents and purposes equal.
 	This defaults to 0.01, which is equivalent to 1\,\%.
-\item	[\tco{--trendbreak}\nf{:}] Ratio of inter-element spacing constituting
-	a break in the trend of the data.
+\item	[\tco{-}\tco{-trendbreak}\nf{:}] Ratio of inter-element spacing
+	constituting a break in the trend of the data.
 	For example, if the average spacing in the data accepted so far
 	is 1.5, then if the trend-break ratio is 2.0, then if the next
 	data value differs from the last one by more than 3.0, this
-- 
2.10.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/2] memorder: Fix typos
  2019-01-05 19:19 [PATCH 1/2] memorder: Fix typos SeongJae Park
  2019-01-05 19:19 ` [PATCH 2/2] debugging: Leave double dashes in description headings SeongJae Park
@ 2019-01-05 23:28 ` Paul E. McKenney
  1 sibling, 0 replies; 3+ messages in thread
From: Paul E. McKenney @ 2019-01-05 23:28 UTC (permalink / raw)
  To: SeongJae Park; +Cc: perfbook

On Sun, Jan 06, 2019 at 04:19:56AM +0900, SeongJae Park wrote:
> Signed-off-by: SeongJae Park <sj38.park@gmail.com>

Good catches, applied and pushed both, thank you!

							Thanx, Paul

> ---
>  memorder/memorder.tex | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/memorder/memorder.tex b/memorder/memorder.tex
> index cb4d037..56786fa 100644
> --- a/memorder/memorder.tex
> +++ b/memorder/memorder.tex
> @@ -541,13 +541,13 @@ Blank cells indicate that no ordering is supplied.
>  The ``Store'' row also covers the store portion of an atomic RMW operation.
>  In addition, the ``Load'' row covers the load
>  component of a successful value-returning \co{_relaxed()} RMW atomic
> -operation, although the combined ``\co{_relaxed()} RMW Operations''
> +operation, although the combined ``\co{_relaxed()} RMW operation''
>  line provides a convenient combined reference in the value-returning case.
>  A CPU executing unsuccessful value-returning atomic RMW operations must
>  invalidate the corresponding variable from all other CPUs' caches.
>  Therefore, oddly enough, unsuccessful value-returning atomic RMW
>  operations have many of the properties of a store, which means that the
> -``\co{_relaxed()} RMW Operations'' line also applies to unsuccessful
> +``\co{_relaxed()} RMW operation'' line also applies to unsuccessful
>  value-returning atomic RMW operations.
>  
>  The \co{*_acquire} row covers \co{smp_load_acquire()},
> -- 
> 2.10.0
> 


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-01-05 23:27 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-01-05 19:19 [PATCH 1/2] memorder: Fix typos SeongJae Park
2019-01-05 19:19 ` [PATCH 2/2] debugging: Leave double dashes in description headings SeongJae Park
2019-01-05 23:28 ` [PATCH 1/2] memorder: Fix typos Paul E. McKenney

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox