* [PATCH 0/2] appendix/questions: Trivial fixup
@ 2023-12-17 17:41 SeongJae Park
2023-12-17 17:41 ` [PATCH 1/2] appendix/questions/after: Use \qco{} for quoting code SeongJae Park
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: SeongJae Park @ 2023-12-17 17:41 UTC (permalink / raw)
To: paulmck; +Cc: perfbook, SeongJae Park
This patchset contains trivial fixups for appendix/questions/, which
found while doing Korean translation[1].
[1] https://github.com/sjp38/perfbook-ko_KR
SeongJae Park (2):
appendix/questions/after: Use \qco{} for quoting code
appendix/questions/after: Use \co{}
appendix/questions/after.tex | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
--
2.17.1
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH 1/2] appendix/questions/after: Use \qco{} for quoting code 2023-12-17 17:41 [PATCH 0/2] appendix/questions: Trivial fixup SeongJae Park @ 2023-12-17 17:41 ` SeongJae Park 2023-12-17 17:41 ` [PATCH 2/2] appendix/questions/after: Use \co{} SeongJae Park 2023-12-17 20:50 ` [PATCH 0/2] appendix/questions: Trivial fixup Paul E. McKenney 2 siblings, 0 replies; 4+ messages in thread From: SeongJae Park @ 2023-12-17 17:41 UTC (permalink / raw) To: paulmck; +Cc: perfbook, SeongJae Park after.tex is using ``...'' for quoting some variables of a code snippet. Use \qco{} instead. Signed-off-by: SeongJae Park <sj38.park@gmail.com> --- appendix/questions/after.tex | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/appendix/questions/after.tex b/appendix/questions/after.tex index c165eb0e..d6b0dfdf 100644 --- a/appendix/questions/after.tex +++ b/appendix/questions/after.tex @@ -13,15 +13,15 @@ An important non-intuitive issue is that code can be delayed at any point for any amount of time. Consider a producing and a consuming thread that communicate using -a global struct with a timestamp ``t'' and integer fields ``a'', ``b'', -and ``c''. +a global struct with a timestamp \qco{t} and integer fields \qco{a}, \qco{b}, +and \qco{c}. The producer loops recording the current time (in seconds since 1970 in decimal), -then updating the values of ``a'', ``b'', and ``c'', +then updating the values of \qco{a}, \qco{b}, and \qco{c}, as shown in \cref{lst:app:questions:After Producer Function}. The consumer code loops, also recording the current time, but also -copying the producer's timestamp along with the fields ``a'', -``b'', and ``c'', as shown in +copying the producer's timestamp along with the fields \qco{a}, +\qco{b}, and \qco{c}, as shown in \cref{lst:app:questions:After Consumer Function}. At the end of the run, the consumer outputs a list of anomalous recordings, e.g., where time has appeared to go backwards. -- 2.17.1 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/2] appendix/questions/after: Use \co{} 2023-12-17 17:41 [PATCH 0/2] appendix/questions: Trivial fixup SeongJae Park 2023-12-17 17:41 ` [PATCH 1/2] appendix/questions/after: Use \qco{} for quoting code SeongJae Park @ 2023-12-17 17:41 ` SeongJae Park 2023-12-17 20:50 ` [PATCH 0/2] appendix/questions: Trivial fixup Paul E. McKenney 2 siblings, 0 replies; 4+ messages in thread From: SeongJae Park @ 2023-12-17 17:41 UTC (permalink / raw) To: paulmck; +Cc: perfbook, SeongJae Park Some code snippets in after.tex are not enclosed with \co{}. Enclose those. Signed-off-by: SeongJae Park <sj38.park@gmail.com> --- appendix/questions/after.tex | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/appendix/questions/after.tex b/appendix/questions/after.tex index d6b0dfdf..768888ed 100644 --- a/appendix/questions/after.tex +++ b/appendix/questions/after.tex @@ -45,7 +45,7 @@ e.g., where time has appeared to go backwards. Here are errors you might have found: \begin{enumerate} - \item Missing barrier() or volatile on tight loops. + \item Missing \co{barrier()} or \co{volatile} on tight loops. \item Missing memory barriers on update side. \item Lack of synchronization between producer and consumer. \end{enumerate} -- 2.17.1 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 0/2] appendix/questions: Trivial fixup 2023-12-17 17:41 [PATCH 0/2] appendix/questions: Trivial fixup SeongJae Park 2023-12-17 17:41 ` [PATCH 1/2] appendix/questions/after: Use \qco{} for quoting code SeongJae Park 2023-12-17 17:41 ` [PATCH 2/2] appendix/questions/after: Use \co{} SeongJae Park @ 2023-12-17 20:50 ` Paul E. McKenney 2 siblings, 0 replies; 4+ messages in thread From: Paul E. McKenney @ 2023-12-17 20:50 UTC (permalink / raw) To: SeongJae Park; +Cc: perfbook On Sun, Dec 17, 2023 at 09:41:15AM -0800, SeongJae Park wrote: > This patchset contains trivial fixups for appendix/questions/, which > found while doing Korean translation[1]. > > [1] https://github.com/sjp38/perfbook-ko_KR > > SeongJae Park (2): > appendix/questions/after: Use \qco{} for quoting code > appendix/questions/after: Use \co{} > > appendix/questions/after.tex | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) Queued, and thank you! Thanx, Paul ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-12-17 20:50 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-12-17 17:41 [PATCH 0/2] appendix/questions: Trivial fixup SeongJae Park
2023-12-17 17:41 ` [PATCH 1/2] appendix/questions/after: Use \qco{} for quoting code SeongJae Park
2023-12-17 17:41 ` [PATCH 2/2] appendix/questions/after: Use \co{} SeongJae Park
2023-12-17 20:50 ` [PATCH 0/2] appendix/questions: Trivial fixup Paul E. McKenney
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox