Re: [PATCH 2/2] platform/x86: fujitsu: clamp charge_control_end_threshold values to 50

[Hans de Goede <hansg@kernel.org>]

Hi,

On 9-Jun-25 12:21 PM, Jelle van der Waa wrote:
> Follow the sysfs ABI documentation that drivers should round written
> values to the nearest supported value instead of returning an error.
> 
> Tested on a Fujitsu Lifebook U7720.
> 
> Signed-off-by: Jelle van der Waa <jvanderwaa@redhat.com>

Thanks, patch looks good to me:

Reviewed-by: Hans de Goede <hansg@kernel.org>

Regards,

Hans




> ---
>  drivers/platform/x86/fujitsu-laptop.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/platform/x86/fujitsu-laptop.c b/drivers/platform/x86/fujitsu-laptop.c
> index c8aeb28a783c..f6a4a02e8d44 100644
> --- a/drivers/platform/x86/fujitsu-laptop.c
> +++ b/drivers/platform/x86/fujitsu-laptop.c
> @@ -187,9 +187,12 @@ static ssize_t charge_control_end_threshold_store(struct device *dev,
>  	if (ret)
>  		return ret;
>  
> -	if (value < 50 || value > 100)
> +	if (value > 100)
>  		return -EINVAL;
>  
> +	if (value < 50)
> +		value = 50;
> +
>  	cc_end_value = value * 0x100 + 0x20;
>  	s006_cc_return = call_fext_func(fext, FUNC_S006_METHOD,
>  					CHARGE_CONTROL_RW, cc_end_value, 0x0);