Re: [PATCH 1/2] platform/x86: fujitsu: use unsigned int for kstrtounit

["Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>]

On Mon, 9 Jun 2025, Jelle van der Waa wrote:

> The charge control threshold value ranges from 0-100.
> 
> Signed-off-by: Jelle van der Waa <jvanderwaa@redhat.com>
> ---
>  drivers/platform/x86/fujitsu-laptop.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/platform/x86/fujitsu-laptop.c b/drivers/platform/x86/fujitsu-laptop.c
> index 162809140f68..c8aeb28a783c 100644
> --- a/drivers/platform/x86/fujitsu-laptop.c
> +++ b/drivers/platform/x86/fujitsu-laptop.c
> @@ -180,7 +180,8 @@ static ssize_t charge_control_end_threshold_store(struct device *dev,
>  				const char *buf, size_t count)
>  {
>  	int cc_end_value, s006_cc_return;
> -	int value, ret;
> +	int ret;
> +	unsigned int value;

Thanks.

I've applied this series to the review-ilpo-next branch but I changed 
these variables to the reverse xmas-tree order while applying. In general, 
if there's no good reason to do otherwise, reverse xmas tree order is 
preferred for local variables.

>  
>  	ret = kstrtouint(buf, 10, &value);
>  	if (ret)
> 

-- 
 i.