[PATCH] platform: arm64: EC_ACER_ASPIRE1 should depend on ARCH_QCOM

[PATCH] platform: arm64: EC_ACER_ASPIRE1 should depend on ARCH_QCOM

[Geert Uytterhoeven]

The Acer Aspire 1 Embedded Controller is only present on the Qualcomm
Snapdragon-based Acer Aspire 1 laptop.  Hence add a dependency on
ARCH_QCOM, to prevent asking the user about this driver when configuring
a kernel without Qualcomm SoC support.

Fixes: 2b3efb7c515111ea ("platform: arm64: Add Acer Aspire 1 embedded controller driver")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 drivers/platform/arm64/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/platform/arm64/Kconfig b/drivers/platform/arm64/Kconfig
index 8c103b3150d1d0a6..058a4baa216a83b8 100644
--- a/drivers/platform/arm64/Kconfig
+++ b/drivers/platform/arm64/Kconfig
@@ -18,6 +18,7 @@ if ARM64_PLATFORM_DEVICES
 
 config EC_ACER_ASPIRE1
 	tristate "Acer Aspire 1 Embedded Controller driver"
+	depends on ARCH_QCOM || COMPILE_TEST
 	depends on I2C
 	depends on DRM
 	depends on POWER_SUPPLY
-- 
2.34.1

Re: [PATCH] platform: arm64: EC_ACER_ASPIRE1 should depend on ARCH_QCOM

[Hans de Goede]

Hi Geert,

On 7/11/24 4:30 PM, Geert Uytterhoeven wrote:
> The Acer Aspire 1 Embedded Controller is only present on the Qualcomm
> Snapdragon-based Acer Aspire 1 laptop.  Hence add a dependency on
> ARCH_QCOM, to prevent asking the user about this driver when configuring
> a kernel without Qualcomm SoC support.
> 
> Fixes: 2b3efb7c515111ea ("platform: arm64: Add Acer Aspire 1 embedded controller driver")

Thanks, patch looks good to me:

Reviewed-by: Hans de Goede <hdegoede@redhat.com>

Not sure if this warrants a fixes tag though, anyways I'll leave that up
to Ilpo when he applies this.

Regards,

Hans


> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
>  drivers/platform/arm64/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/platform/arm64/Kconfig b/drivers/platform/arm64/Kconfig
> index 8c103b3150d1d0a6..058a4baa216a83b8 100644
> --- a/drivers/platform/arm64/Kconfig
> +++ b/drivers/platform/arm64/Kconfig
> @@ -18,6 +18,7 @@ if ARM64_PLATFORM_DEVICES
>  
>  config EC_ACER_ASPIRE1
>  	tristate "Acer Aspire 1 Embedded Controller driver"
> +	depends on ARCH_QCOM || COMPILE_TEST
>  	depends on I2C
>  	depends on DRM
>  	depends on POWER_SUPPLY

Re: [PATCH] platform: arm64: EC_ACER_ASPIRE1 should depend on ARCH_QCOM

[Nikita Travkin]

Geert Uytterhoeven писал(а) 11.07.2024 19:30:
> The Acer Aspire 1 Embedded Controller is only present on the Qualcomm
> Snapdragon-based Acer Aspire 1 laptop.  Hence add a dependency on
> ARCH_QCOM, to prevent asking the user about this driver when configuring
> a kernel without Qualcomm SoC support.
> 

Oh yeah, you're right. Thanks for fixing this!

Acked-by: Nikita Travkin <nikita@trvn.ru>

We should probably do the same for the C630 driver as well...

> Fixes: 2b3efb7c515111ea ("platform: arm64: Add Acer Aspire 1 embedded controller driver")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
>  drivers/platform/arm64/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/platform/arm64/Kconfig b/drivers/platform/arm64/Kconfig
> index 8c103b3150d1d0a6..058a4baa216a83b8 100644
> --- a/drivers/platform/arm64/Kconfig
> +++ b/drivers/platform/arm64/Kconfig
> @@ -18,6 +18,7 @@ if ARM64_PLATFORM_DEVICES
>  
>  config EC_ACER_ASPIRE1
>  	tristate "Acer Aspire 1 Embedded Controller driver"
> +	depends on ARCH_QCOM || COMPILE_TEST
>  	depends on I2C
>  	depends on DRM
>  	depends on POWER_SUPPLY

Re: [PATCH] platform: arm64: EC_ACER_ASPIRE1 should depend on ARCH_QCOM

[Ilpo Järvinen]

[-- Attachment #1: Type: text/plain, Size: 1345 bytes --]

On Thu, 11 Jul 2024, Nikita Travkin wrote:

> Geert Uytterhoeven писал(а) 11.07.2024 19:30:
> > The Acer Aspire 1 Embedded Controller is only present on the Qualcomm
> > Snapdragon-based Acer Aspire 1 laptop.  Hence add a dependency on
> > ARCH_QCOM, to prevent asking the user about this driver when configuring
> > a kernel without Qualcomm SoC support.
> > 
> 
> Oh yeah, you're right. Thanks for fixing this!
> 
> Acked-by: Nikita Travkin <nikita@trvn.ru>
> 
> We should probably do the same for the C630 driver as well...

Yes, Geert sent another patch for that already.

-- 
 i.

> > Fixes: 2b3efb7c515111ea ("platform: arm64: Add Acer Aspire 1 embedded controller driver")
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > ---
> >  drivers/platform/arm64/Kconfig | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/platform/arm64/Kconfig b/drivers/platform/arm64/Kconfig
> > index 8c103b3150d1d0a6..058a4baa216a83b8 100644
> > --- a/drivers/platform/arm64/Kconfig
> > +++ b/drivers/platform/arm64/Kconfig
> > @@ -18,6 +18,7 @@ if ARM64_PLATFORM_DEVICES
> >  
> >  config EC_ACER_ASPIRE1
> >  	tristate "Acer Aspire 1 Embedded Controller driver"
> > +	depends on ARCH_QCOM || COMPILE_TEST
> >  	depends on I2C
> >  	depends on DRM
> >  	depends on POWER_SUPPLY
> 

Re: [PATCH] platform: arm64: EC_ACER_ASPIRE1 should depend on ARCH_QCOM

[Ilpo Järvinen]

On Thu, 11 Jul 2024 16:30:36 +0200, Geert Uytterhoeven wrote:

> The Acer Aspire 1 Embedded Controller is only present on the Qualcomm
> Snapdragon-based Acer Aspire 1 laptop.  Hence add a dependency on
> ARCH_QCOM, to prevent asking the user about this driver when configuring
> a kernel without Qualcomm SoC support.
> 
> 


Thank you for your contribution, it has been applied to my local
review-ilpo branch. Note it will show up in the public
platform-drivers-x86/review-ilpo branch only once I've pushed my
local branch there, which might take a while.

The list of commits applied:
[1/1] platform: arm64: EC_ACER_ASPIRE1 should depend on ARCH_QCOM
      commit: 03b927565057dae39da3e4b46e5ab65274b5dcdc

--
 i.

[PATCH] platform: arm64: EC_LENOVO_YOGA_C630 should depend on ARCH_QCOM

[Geert Uytterhoeven]

The Lenovo Yoga C630 Embedded Controller is only present on the Qualcomm
Snapdragon-based Lenovo Yoga C630 laptop.  Hence add a dependency on
ARCH_QCOM, to prevent asking the user about this driver when configuring
a kernel without Qualcomm SoC support.

Fixes: 5e5f2f92cccc29f3 ("platform: arm64: add Lenovo Yoga C630 WOS EC driver")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 drivers/platform/arm64/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/platform/arm64/Kconfig b/drivers/platform/arm64/Kconfig
index 058a4baa216a83b8..f7539e5419cf1616 100644
--- a/drivers/platform/arm64/Kconfig
+++ b/drivers/platform/arm64/Kconfig
@@ -35,6 +35,7 @@ config EC_ACER_ASPIRE1
 
 config EC_LENOVO_YOGA_C630
 	tristate "Lenovo Yoga C630 Embedded Controller driver"
+	depends on ARCH_QCOM || COMPILE_TEST
 	depends on I2C
 	select AUXILIARY_BUS
 	help
-- 
2.34.1

Re: [PATCH] platform: arm64: EC_LENOVO_YOGA_C630 should depend on ARCH_QCOM

[Hans de Goede]

Hi Geert,

On 7/11/24 4:32 PM, Geert Uytterhoeven wrote:
> The Lenovo Yoga C630 Embedded Controller is only present on the Qualcomm
> Snapdragon-based Lenovo Yoga C630 laptop.  Hence add a dependency on
> ARCH_QCOM, to prevent asking the user about this driver when configuring
> a kernel without Qualcomm SoC support.
> 
> Fixes: 5e5f2f92cccc29f3 ("platform: arm64: add Lenovo Yoga C630 WOS EC driver")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

Thanks, patch looks good to me:

Reviewed-by: Hans de Goede <hdegoede@redhat.com>

Not sure if this warrants a fixes tag though, anyways I'll leave that up
to Ilpo when he applies this.

Regards,

Hans





> ---
>  drivers/platform/arm64/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/platform/arm64/Kconfig b/drivers/platform/arm64/Kconfig
> index 058a4baa216a83b8..f7539e5419cf1616 100644
> --- a/drivers/platform/arm64/Kconfig
> +++ b/drivers/platform/arm64/Kconfig
> @@ -35,6 +35,7 @@ config EC_ACER_ASPIRE1
>  
>  config EC_LENOVO_YOGA_C630
>  	tristate "Lenovo Yoga C630 Embedded Controller driver"
> +	depends on ARCH_QCOM || COMPILE_TEST
>  	depends on I2C
>  	select AUXILIARY_BUS
>  	help

Re: [PATCH] platform: arm64: EC_LENOVO_YOGA_C630 should depend on ARCH_QCOM

[Ilpo Järvinen]

On Thu, 11 Jul 2024 16:32:35 +0200, Geert Uytterhoeven wrote:

> The Lenovo Yoga C630 Embedded Controller is only present on the Qualcomm
> Snapdragon-based Lenovo Yoga C630 laptop.  Hence add a dependency on
> ARCH_QCOM, to prevent asking the user about this driver when configuring
> a kernel without Qualcomm SoC support.
> 
> 


Thank you for your contribution, it has been applied to my local
review-ilpo branch. Note it will show up in the public
platform-drivers-x86/review-ilpo branch only once I've pushed my
local branch there, which might take a while.

The list of commits applied:
[1/1] platform: arm64: EC_LENOVO_YOGA_C630 should depend on ARCH_QCOM
      commit: 1e02e317470b1c68d5971e51e8c62967ec1bc828

--
 i.

Re: [PATCH] platform: arm64: EC_LENOVO_YOGA_C630 should depend on ARCH_QCOM

[Dmitry Baryshkov]

On Thu, 11 Jul 2024 at 17:32, Geert Uytterhoeven
<geert+renesas@glider.be> wrote:
>
> The Lenovo Yoga C630 Embedded Controller is only present on the Qualcomm
> Snapdragon-based Lenovo Yoga C630 laptop.  Hence add a dependency on
> ARCH_QCOM, to prevent asking the user about this driver when configuring
> a kernel without Qualcomm SoC support.
>
> Fixes: 5e5f2f92cccc29f3 ("platform: arm64: add Lenovo Yoga C630 WOS EC driver")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
>  drivers/platform/arm64/Kconfig | 1 +
>  1 file changed, 1 insertion(+)

Could you please add the same condition to the Acer Aspire 1 entry?

>
> diff --git a/drivers/platform/arm64/Kconfig b/drivers/platform/arm64/Kconfig
> index 058a4baa216a83b8..f7539e5419cf1616 100644
> --- a/drivers/platform/arm64/Kconfig
> +++ b/drivers/platform/arm64/Kconfig
> @@ -35,6 +35,7 @@ config EC_ACER_ASPIRE1
>
>  config EC_LENOVO_YOGA_C630
>         tristate "Lenovo Yoga C630 Embedded Controller driver"
> +       depends on ARCH_QCOM || COMPILE_TEST
>         depends on I2C
>         select AUXILIARY_BUS
>         help
> --
> 2.34.1
>


-- 
With best wishes
Dmitry

Re: [PATCH] platform: arm64: EC_LENOVO_YOGA_C630 should depend on ARCH_QCOM

[Geert Uytterhoeven]

Hi Dmitry,

On Fri, Jul 12, 2024 at 12:24 PM Dmitry Baryshkov
<dmitry.baryshkov@linaro.org> wrote:
> On Thu, 11 Jul 2024 at 17:32, Geert Uytterhoeven
> <geert+renesas@glider.be> wrote:
> >
> > The Lenovo Yoga C630 Embedded Controller is only present on the Qualcomm
> > Snapdragon-based Lenovo Yoga C630 laptop.  Hence add a dependency on
> > ARCH_QCOM, to prevent asking the user about this driver when configuring
> > a kernel without Qualcomm SoC support.
> >
> > Fixes: 5e5f2f92cccc29f3 ("platform: arm64: add Lenovo Yoga C630 WOS EC driver")
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > ---
> >  drivers/platform/arm64/Kconfig | 1 +
> >  1 file changed, 1 insertion(+)
>
> Could you please add the same condition to the Acer Aspire 1 entry?

https://lore.kernel.org/all/f5f38709c01d369ed9e375ceb2a9a12986457a1a.1720707932.git.geert+renesas@glider.be/

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds