From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: Suma Hegde <suma.hegde@amd.com>
Cc: platform-driver-x86@vger.kernel.org,
Hans de Goede <hdegoede@redhat.com>,
Naveen Krishna Chatradhi <nchatrad@amd.com>
Subject: Re: [PATCH v5 10/11] platform/x86/amd/hsmp: Change devm_kzalloc() to devm_kcalloc()
Date: Mon, 29 Jan 2024 14:44:30 +0200 (EET) [thread overview]
Message-ID: <0c930967-ce51-edf9-c8c4-5e00d8ff7047@linux.intel.com> (raw)
In-Reply-To: <8b896046-2058-805d-1998-7ae6d51edd01@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 901 bytes --]
On Thu, 25 Jan 2024, Ilpo Järvinen wrote:
> On Sat, 6 Jan 2024, Suma Hegde wrote:
>
> > Use the standard array allocation variant of devm memory allocation
> > APIs.
> >
> > Signed-off-by: Suma Hegde <suma.hegde@amd.com>
> > Signed-off-by: Naveen Krishna Chatradhi <nchatrad@amd.com>
>
> I decided to apply all but this patch 10/11 into review-ilpo. I fixed the
> parenthesis issue I mentioned in one of the patches while applying.
>
> Please check the comment I made against this patch and respin this one.
>
> I also noticed while applying one other extra parenthesis case in patch 5
> but since it was not added, I didn't go to tweak it now myself, but just
> you know.
Hi Suma,
There are number of issues and warnings due to these patches including
one build failure due to lack of ACPI in the config (I think), can you
please take a look at them.
--
i.
next prev parent reply other threads:[~2024-01-29 12:44 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-06 2:25 [PATCH v5 01/11] platform/x86/amd/hsmp: Move hsmp_test to probe Suma Hegde
2024-01-06 2:25 ` [PATCH v5 02/11] platform/x86/amd/hsmp: Cache pci_dev in struct hsmp_socket Suma Hegde
2024-01-06 2:25 ` [PATCH v5 03/11] platform/x86/amd/hsmp: Create static func to handle platdev Suma Hegde
2024-01-06 2:25 ` [PATCH v5 04/11] platform/x86/amd/hsmp: Define a struct to hold mailbox regs Suma Hegde
2024-01-06 2:25 ` [PATCH v5 05/11] platform/x86/amd/hsmp: Move dev from platdev to hsmp_socket Suma Hegde
2024-01-06 2:25 ` [PATCH v5 06/11] platform/x86/amd/hsmp: Restructure sysfs group creation Suma Hegde
2024-01-24 12:34 ` Ilpo Järvinen
2024-01-06 2:25 ` [PATCH v5 07/11] platform/x86/amd/hsmp: Add support for ACPI based probing Suma Hegde
2024-01-24 13:02 ` Ilpo Järvinen
2024-01-06 2:25 ` [PATCH v5 08/11] platform/x86/amd/hsmp: Non-ACPI support for AMD F1A_M00~0Fh Suma Hegde
2024-01-06 2:25 ` [PATCH v5 09/11] platform/x86/amd/hsmp: Check num_sockets against MAX_AMD_SOCKETS Suma Hegde
2024-01-06 2:25 ` [PATCH v5 10/11] platform/x86/amd/hsmp: Change devm_kzalloc() to devm_kcalloc() Suma Hegde
2024-01-24 12:29 ` Ilpo Järvinen
2024-01-25 12:33 ` Ilpo Järvinen
2024-01-29 12:44 ` Ilpo Järvinen [this message]
2024-01-29 13:24 ` Hegde, Suma
2024-01-31 10:32 ` Ilpo Järvinen
2024-02-06 6:38 ` Hegde, Suma
2024-02-06 9:04 ` Ilpo Järvinen
2024-02-06 9:46 ` Hegde, Suma
2024-01-06 2:25 ` [PATCH v5 11/11] platform/x86/amd/hsmp: Remove extra parenthesis and add a space Suma Hegde
2024-01-24 12:25 ` Ilpo Järvinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0c930967-ce51-edf9-c8c4-5e00d8ff7047@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=hdegoede@redhat.com \
--cc=nchatrad@amd.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=suma.hegde@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox