X86 platform drivers
 help / color / mirror / Atom feed
From: Suma Hegde <suma.hegde@amd.com>
To: <platform-driver-x86@vger.kernel.org>
Cc: <ilpo.jarvinen@linux.intel.com>, <hdegoede@redhat.com>,
	Suma Hegde <suma.hegde@amd.com>,
	Naveen Krishna Chatradhi <nchatrad@amd.com>
Subject: [PATCH v5 10/11] platform/x86/amd/hsmp: Change devm_kzalloc() to devm_kcalloc()
Date: Sat, 6 Jan 2024 02:25:31 +0000	[thread overview]
Message-ID: <20240106022532.1746932-10-suma.hegde@amd.com> (raw)
In-Reply-To: <20240106022532.1746932-1-suma.hegde@amd.com>

Use the standard array allocation variant of devm memory allocation
APIs.

Signed-off-by: Suma Hegde <suma.hegde@amd.com>
Signed-off-by: Naveen Krishna Chatradhi <nchatrad@amd.com>
---
Changes since v4:
1. Change sizeof(struct bin_attribute *) to sizeof(*hsmp_bin_attrs)
2. Change sizeof(struct attribute_group *) to sizeof(*hsmp_attr_grps)
3. Split some of the changes to 11th patch in this v5 series

Changes since v3:
New patch, based on Ilpos review comments and additional cosmetic changes.
 drivers/platform/x86/amd/hsmp.c | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)

diff --git a/drivers/platform/x86/amd/hsmp.c b/drivers/platform/x86/amd/hsmp.c
index 99bebb0ca5a9..ccf7cd8f98f6 100644
--- a/drivers/platform/x86/amd/hsmp.c
+++ b/drivers/platform/x86/amd/hsmp.c
@@ -657,8 +657,9 @@ static int hsmp_create_attr_list(struct attribute_group *attr_grp,
 	struct bin_attribute **hsmp_bin_attrs;
 
 	/* Null terminated list of attributes */
-	hsmp_bin_attrs = devm_kzalloc(dev, sizeof(struct bin_attribute *) *
-				      (NUM_HSMP_ATTRS + 1), GFP_KERNEL);
+	hsmp_bin_attrs = devm_kcalloc(dev, NUM_HSMP_ATTRS + 1,
+				      sizeof(*hsmp_bin_attrs),
+				      GFP_KERNEL);
 	if (!hsmp_bin_attrs)
 		return -ENOMEM;
 
@@ -673,8 +674,9 @@ static int hsmp_create_non_acpi_sysfs_if(struct device *dev)
 	struct attribute_group *attr_grp;
 	u16 i;
 
-	hsmp_attr_grps = devm_kzalloc(dev, sizeof(struct attribute_group *) *
-				      (plat_dev.num_sockets + 1), GFP_KERNEL);
+	hsmp_attr_grps = devm_kcalloc(dev, plat_dev.num_sockets + 1,
+				      sizeof(*hsmp_attr_grps),
+				      GFP_KERNEL);
 	if (!hsmp_attr_grps)
 		return -ENOMEM;
 
@@ -804,8 +806,8 @@ static int hsmp_pltdrv_probe(struct platform_device *pdev)
 	 * on each probe.
 	 */
 	if (!plat_dev.is_probed) {
-		plat_dev.sock = devm_kzalloc(&pdev->dev,
-					     (plat_dev.num_sockets * sizeof(struct hsmp_socket)),
+		plat_dev.sock = devm_kcalloc(&pdev->dev, plat_dev.num_sockets,
+					     sizeof(struct hsmp_socket),
 					     GFP_KERNEL);
 		if (!plat_dev.sock)
 			return -ENOMEM;
-- 
2.25.1


  parent reply	other threads:[~2024-01-06  2:26 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-06  2:25 [PATCH v5 01/11] platform/x86/amd/hsmp: Move hsmp_test to probe Suma Hegde
2024-01-06  2:25 ` [PATCH v5 02/11] platform/x86/amd/hsmp: Cache pci_dev in struct hsmp_socket Suma Hegde
2024-01-06  2:25 ` [PATCH v5 03/11] platform/x86/amd/hsmp: Create static func to handle platdev Suma Hegde
2024-01-06  2:25 ` [PATCH v5 04/11] platform/x86/amd/hsmp: Define a struct to hold mailbox regs Suma Hegde
2024-01-06  2:25 ` [PATCH v5 05/11] platform/x86/amd/hsmp: Move dev from platdev to hsmp_socket Suma Hegde
2024-01-06  2:25 ` [PATCH v5 06/11] platform/x86/amd/hsmp: Restructure sysfs group creation Suma Hegde
2024-01-24 12:34   ` Ilpo Järvinen
2024-01-06  2:25 ` [PATCH v5 07/11] platform/x86/amd/hsmp: Add support for ACPI based probing Suma Hegde
2024-01-24 13:02   ` Ilpo Järvinen
2024-01-06  2:25 ` [PATCH v5 08/11] platform/x86/amd/hsmp: Non-ACPI support for AMD F1A_M00~0Fh Suma Hegde
2024-01-06  2:25 ` [PATCH v5 09/11] platform/x86/amd/hsmp: Check num_sockets against MAX_AMD_SOCKETS Suma Hegde
2024-01-06  2:25 ` Suma Hegde [this message]
2024-01-24 12:29   ` [PATCH v5 10/11] platform/x86/amd/hsmp: Change devm_kzalloc() to devm_kcalloc() Ilpo Järvinen
2024-01-25 12:33   ` Ilpo Järvinen
2024-01-29 12:44     ` Ilpo Järvinen
2024-01-29 13:24       ` Hegde, Suma
2024-01-31 10:32         ` Ilpo Järvinen
2024-02-06  6:38           ` Hegde, Suma
2024-02-06  9:04             ` Ilpo Järvinen
2024-02-06  9:46               ` Hegde, Suma
2024-01-06  2:25 ` [PATCH v5 11/11] platform/x86/amd/hsmp: Remove extra parenthesis and add a space Suma Hegde
2024-01-24 12:25   ` Ilpo Järvinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240106022532.1746932-10-suma.hegde@amd.com \
    --to=suma.hegde@amd.com \
    --cc=hdegoede@redhat.com \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=nchatrad@amd.com \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox