* [PATCH] asus-laptop: return proper error for store_ledd if write_acpi_int fail
@ 2010-07-08 5:55 Axel Lin
2010-07-08 7:50 ` Corentin Chary
0 siblings, 1 reply; 2+ messages in thread
From: Axel Lin @ 2010-07-08 5:55 UTC (permalink / raw)
To: linux-kernel
Cc: Corentin Chary, Matthew Garrett, Alan Jenkins, acpi4asus-user,
platform-driver-x86
In current implementation, store_ledd() does not return error if write_acpi_int
fail.
This patch fixes it by return -ENODEV if write_acpi_int fail.
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
drivers/platform/x86/asus-laptop.c | 7 ++++---
1 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/platform/x86/asus-laptop.c b/drivers/platform/x86/asus-laptop.c
index 93487eb..975751d 100644
--- a/drivers/platform/x86/asus-laptop.c
+++ b/drivers/platform/x86/asus-laptop.c
@@ -796,10 +796,11 @@ static ssize_t store_ledd(struct device *dev, struct device_attribute *attr,
rv = parse_arg(buf, count, &value);
if (rv > 0) {
- if (write_acpi_int(asus->handle, METHOD_LEDD, value))
+ if (write_acpi_int(asus->handle, METHOD_LEDD, value)) {
pr_warning("LED display write failed\n");
- else
- asus->ledd_status = (u32) value;
+ return -ENODEV;
+ }
+ asus->ledd_status = (u32) value;
}
return rv;
}
--
1.5.4.3
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] asus-laptop: return proper error for store_ledd if write_acpi_int fail
2010-07-08 5:55 [PATCH] asus-laptop: return proper error for store_ledd if write_acpi_int fail Axel Lin
@ 2010-07-08 7:50 ` Corentin Chary
0 siblings, 0 replies; 2+ messages in thread
From: Corentin Chary @ 2010-07-08 7:50 UTC (permalink / raw)
To: Axel Lin
Cc: linux-kernel, Matthew Garrett, Alan Jenkins, acpi4asus-user,
platform-driver-x86
On Thu, Jul 8, 2010 at 7:55 AM, Axel Lin <axel.lin@gmail.com> wrote:
> In current implementation, store_ledd() does not return error if write_acpi_int
> fail.
> This patch fixes it by return -ENODEV if write_acpi_int fail.
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> ---
> drivers/platform/x86/asus-laptop.c | 7 ++++---
> 1 files changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/platform/x86/asus-laptop.c b/drivers/platform/x86/asus-laptop.c
> index 93487eb..975751d 100644
> --- a/drivers/platform/x86/asus-laptop.c
> +++ b/drivers/platform/x86/asus-laptop.c
> @@ -796,10 +796,11 @@ static ssize_t store_ledd(struct device *dev, struct device_attribute *attr,
>
> rv = parse_arg(buf, count, &value);
> if (rv > 0) {
> - if (write_acpi_int(asus->handle, METHOD_LEDD, value))
> + if (write_acpi_int(asus->handle, METHOD_LEDD, value)) {
> pr_warning("LED display write failed\n");
> - else
> - asus->ledd_status = (u32) value;
> + return -ENODEV;
> + }
> + asus->ledd_status = (u32) value;
> }
> return rv;
> }
> --
> 1.5.4.3
>
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
Thanks !
Acked-by: Corentin Chary <corentincj@iksaif.net>
--
Corentin Chary
http://xf.iksaif.net
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-07-08 7:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-07-08 5:55 [PATCH] asus-laptop: return proper error for store_ledd if write_acpi_int fail Axel Lin
2010-07-08 7:50 ` Corentin Chary
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox