From: Ben Hutchings <ben@decadent.org.uk>
To: Jesper Juhl <jj@chaosbits.net>
Cc: platform-driver-x86@vger.kernel.org
Subject: Re: drivers/platform/x86/amilo-rfkill.c::amilo_rfkill_probe() avoid NULL deref
Date: Tue, 22 May 2012 03:47:35 +0100 [thread overview]
Message-ID: <1337654855.11796.8.camel@deadeye> (raw)
[-- Attachment #1: Type: text/plain, Size: 512 bytes --]
I don't understand this change:
commit 41603e9783a24c8c7cce548c0819bdc9e46a585b
Author: Jesper Juhl <jj@chaosbits.net>
Date: Fri Mar 23 01:08:34 2012 +0100
drivers/platform/x86/amilo-rfkill.c::amilo_rfkill_probe() avoid NULL deref
amilo_rfkill_init() checks that dmi_first_match() does not return NULL,
before registering the platform driver. So why would it return NULL
when called by amilo_rfkill_probe()?
Ben.
--
Ben Hutchings
You can't have everything. Where would you put it?
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
next reply other threads:[~2012-05-22 2:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-22 2:47 Ben Hutchings [this message]
2012-06-11 20:36 ` drivers/platform/x86/amilo-rfkill.c::amilo_rfkill_probe() avoid NULL deref Jesper Juhl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1337654855.11796.8.camel@deadeye \
--to=ben@decadent.org.uk \
--cc=jj@chaosbits.net \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox