Re: drivers/platform/x86/amilo-rfkill.c::amilo_rfkill_probe() avoid NULL deref

Re: drivers/platform/x86/amilo-rfkill.c::amilo_rfkill_probe() avoid NULL deref

[Ben Hutchings]

[-- Attachment #1: Type: text/plain, Size: 512 bytes --]

I don't understand this change:

commit 41603e9783a24c8c7cce548c0819bdc9e46a585b
Author: Jesper Juhl <jj@chaosbits.net>
Date:   Fri Mar 23 01:08:34 2012 +0100

    drivers/platform/x86/amilo-rfkill.c::amilo_rfkill_probe() avoid NULL deref

amilo_rfkill_init() checks that dmi_first_match() does not return NULL,
before registering the platform driver.  So why would it return NULL
when called by amilo_rfkill_probe()?

Ben.

-- 
Ben Hutchings
You can't have everything.  Where would you put it?

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]

Re: drivers/platform/x86/amilo-rfkill.c::amilo_rfkill_probe() avoid NULL deref

[Jesper Juhl]

On Tue, 22 May 2012, Ben Hutchings wrote:

> I don't understand this change:
> 
> commit 41603e9783a24c8c7cce548c0819bdc9e46a585b
> Author: Jesper Juhl <jj@chaosbits.net>
> Date:   Fri Mar 23 01:08:34 2012 +0100
> 
>     drivers/platform/x86/amilo-rfkill.c::amilo_rfkill_probe() avoid NULL deref
> 
> amilo_rfkill_init() checks that dmi_first_match() does not return NULL,
> before registering the platform driver.  So why would it return NULL
> when called by amilo_rfkill_probe()?
> 
To be completely honest - I don't (currently) know.
When I did the patch I was convinced that it made sense and that I could 
prove that - now I can't.  So I must either have been drunk or delusional 
at the time...

Seriously; I really don't know. I remember crafting the patch after 
reading some coverity reports and reading the source and thinking "this 
makes sense"... Now, when I read it again, it does not..

-- 
Jesper Juhl <jj@chaosbits.net>       http://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails only, please.