From: joeyli <jlee@suse.com>
To: Marek Vasut <marex@denx.de>
Cc: platform-driver-x86@vger.kernel.org,
Matthew Garrett <mjg59@srcf.ucam.org>,
Fengguang Wu <wfg@linux.intel.com>
Subject: Re: [PATCH 1/2] ACER: Fix up sparse warning
Date: Fri, 06 Jul 2012 18:22:31 +0800 [thread overview]
Message-ID: <1341570151.4823.372.camel@linux-s257.site> (raw)
In-Reply-To: <1341444610-15067-1-git-send-email-marex@denx.de>
於 四,2012-07-05 於 01:30 +0200,Marek Vasut 提到:
> drivers/platform/x86/acer-wmi.c:1836:18: sparse: Using plain integer as NULL pointer
>
> drivers/platform/x86/acer-wmi.c:1836:
> 1833
> 1834 BUG_ON(!name || !ah);
> 1835
> > 1836 handle = 0;
> 1837 status = acpi_get_devices(prop, acer_wmi_get_handle_cb,
> 1838 (void *)name, &handle);
> 1839
>
> Reported-by: Fengguang Wu <wfg@linux.intel.com>
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Matthew Garrett <mjg59@srcf.ucam.org>
> Cc: Fengguang Wu <wfg@linux.intel.com>
> Cc: joeyli <jlee@suse.com>
Acked-by: joeyli <jlee@suse.com>
Thanks
Joey Lee
> ---
> drivers/platform/x86/acer-wmi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c
> index 175809d..ae969fd 100644
> --- a/drivers/platform/x86/acer-wmi.c
> +++ b/drivers/platform/x86/acer-wmi.c
> @@ -1833,7 +1833,7 @@ static int __init acer_wmi_get_handle(const char *name, const char *prop,
>
> BUG_ON(!name || !ah);
>
> - handle = 0;
> + handle = NULL;
> status = acpi_get_devices(prop, acer_wmi_get_handle_cb,
> (void *)name, &handle);
>
prev parent reply other threads:[~2012-07-06 10:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-04 23:30 [PATCH 1/2] ACER: Fix up sparse warning Marek Vasut
2012-07-04 23:30 ` [PATCH 2/2] ACER: Fix Smatch double-free issue Marek Vasut
2012-07-06 10:22 ` joeyli
2012-07-06 10:22 ` joeyli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1341570151.4823.372.camel@linux-s257.site \
--to=jlee@suse.com \
--cc=marex@denx.de \
--cc=mjg59@srcf.ucam.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=wfg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox