X86 platform drivers
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: platform-driver-x86@vger.kernel.org
Cc: Marek Vasut <marex@denx.de>,
	Matthew Garrett <mjg59@srcf.ucam.org>,
	Fengguang Wu <wfg@linux.intel.com>, joeyli <jlee@suse.com>,
	Dan Carpenter <dan.carpenter@oracle.com>
Subject: [PATCH 2/2] ACER: Fix Smatch double-free issue
Date: Thu,  5 Jul 2012 01:30:10 +0200	[thread overview]
Message-ID: <1341444610-15067-2-git-send-email-marex@denx.de> (raw)
In-Reply-To: <1341444610-15067-1-git-send-email-marex@denx.de>

The patch 6ae3a0876185: "ACER: Add support for accelerometer sensor"
from Jun 1, 2012, leads to the following Smatch warning:
drivers/platform/x86/acer-wmi.c:1886 acer_wmi_accel_destroy()
         error: don't call input_free_device() after input_unregister_device()

drivers/platform/x86/acer-wmi.c
  1883  static void acer_wmi_accel_destroy(void)
  1884  {
  1885          input_unregister_device(acer_wmi_accel_dev);
  1886          input_free_device(acer_wmi_accel_dev);
  1887  }

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Matthew Garrett <mjg59@srcf.ucam.org>
Cc: Fengguang Wu <wfg@linux.intel.com>
Cc: joeyli <jlee@suse.com>
Cc: Dan Carpenter <dan.carpenter@oracle.com>
---
 drivers/platform/x86/acer-wmi.c |    1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c
index ae969fd..f4ed2af 100644
--- a/drivers/platform/x86/acer-wmi.c
+++ b/drivers/platform/x86/acer-wmi.c
@@ -1883,7 +1883,6 @@ err_free_dev:
 static void acer_wmi_accel_destroy(void)
 {
 	input_unregister_device(acer_wmi_accel_dev);
-	input_free_device(acer_wmi_accel_dev);
 }
 
 static int __init acer_wmi_input_setup(void)
-- 
1.7.10

  reply	other threads:[~2012-07-04 23:30 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-04 23:30 [PATCH 1/2] ACER: Fix up sparse warning Marek Vasut
2012-07-04 23:30 ` Marek Vasut [this message]
2012-07-06 10:22   ` [PATCH 2/2] ACER: Fix Smatch double-free issue joeyli
2012-07-06 10:22 ` [PATCH 1/2] ACER: Fix up sparse warning joeyli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1341444610-15067-2-git-send-email-marex@denx.de \
    --to=marex@denx.de \
    --cc=dan.carpenter@oracle.com \
    --cc=jlee@suse.com \
    --cc=mjg59@srcf.ucam.org \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=wfg@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox