X86 platform drivers
 help / color / mirror / Atom feed
* [PATCH] sony-laptop: fully enable SNY controlled modems
@ 2012-10-14 21:42 Mattia Dongili
  0 siblings, 0 replies; only message in thread
From: Mattia Dongili @ 2012-10-14 21:42 UTC (permalink / raw)
  To: Matthew Garrett; +Cc: platform-driver-x86, Mattia Dongili, Illya Klymov

The call to handlers 0x124 and 0x135 (rfkill control) seems to take a
bitmask to control various states of the device. For our rfkill we need
a fully on/off. SVZ1311Z9R/X's LTE modem needs more bits up.

Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=47751
Cc: Illya Klymov <xanf@xanf.me>
Signed-off-by: Mattia Dongili <malattia@linux.it>
---

Hi Matthew,
See bugzilla above for how "7" is better than "3". I have checked a handful of
Vaio DSDTs I have here and it looks like this new value will not harm other
models. In fact it works fine on the above SVZ, a VGN-G and a VPC-X I could
test with.

Could you see if it can be included in 3.7?

Thanks!
---
 drivers/platform/x86/sony-laptop.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/platform/x86/sony-laptop.c b/drivers/platform/x86/sony-laptop.c
index badd646..42125df 100644
--- a/drivers/platform/x86/sony-laptop.c
+++ b/drivers/platform/x86/sony-laptop.c
@@ -1726,7 +1726,7 @@ static int sony_nc_rfkill_set(void *data, bool blocked)
 	int argument = sony_rfkill_address[(long) data] + 0x100;
 
 	if (!blocked)
-		argument |= 0x030000;
+		argument |= 0x070000;
 
 	return sony_call_snc_handle(sony_rfkill_handle, argument, &result);
 }
-- 
1.7.10.4

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2012-10-14 21:53 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-14 21:42 [PATCH] sony-laptop: fully enable SNY controlled modems Mattia Dongili

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox