Re: [PATCH V4 RESEND] Support Thinkpad X1 Carbon 2nd gen's adaptive keyboard

Re: [PATCH V4 RESEND] Support Thinkpad X1 Carbon 2nd gen's adaptive keyboard

[Shuduo Sang]

[-- Attachment #1.1: Type: text/plain, Size: 935 bytes --]

On Mon, Mar 31, 2014 at 11:12 PM, Pavel Machek <pavel-+ZI9xUNit7I@public.gmane.org> wrote:

> On Mon 2014-03-31 23:00:36, Shuduo Sang wrote:
> > On Mon, Mar 31, 2014 at 10:49 PM, Pavel Machek <pavel-+ZI9xUNit7I@public.gmane.org> wrote:
> >
> > > Hi!
> > >
> > > > Resend patch V4. Support Thinkpad X1 Carbon 2nd generation's adaptive
> > > > keyboard.
> > > >
> > > > Hi Henrique, could you please have a chance to review it?
> > >
> > > As far as I can tell... thinkpad just has small display above its
> function
> > > keys (right?).
> > >
> > > Would it be possible to support it as a display? (/dev/fb1)?
> > >
> >
> > Not possible so far.
>
> Can you elaborate?
>
> Is the problem that hw only supports few fixed images for that display?
>

No such interface can do that.



>
> Pavel
> --
> (english) http://www.livejournal.com/~pavelmachek
> (cesky, pictures)
> http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
>

[-- Attachment #1.2: Type: text/html, Size: 1958 bytes --]

[-- Attachment #2: Type: text/plain, Size: 79 bytes --]

------------------------------------------------------------------------------

[-- Attachment #3: Type: text/plain, Size: 201 bytes --]

_______________________________________________
ibm-acpi-devel mailing list
ibm-acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel

Re: [PATCH V4 RESEND] Support Thinkpad X1 Carbon 2nd gen's adaptive keyboard

[Henrique de Moraes Holschuh]

On Tue, Mar 11, 2014, at 8:01, Shuduo Sang wrote:
> Resend patch V4. Support Thinkpad X1 Carbon 2nd generation's adaptive
> keyboard.
> 
> Hi Henrique, could you please have a chance to review it?

I am unable to do a full review right now, but we can always adjust
minor details of the feature with later patches and the previous reviews
did help clean up the feature.

However: as far as I am concerned, this is an experimental feature until
it matures for a while.  I'd rather we plug this somehow to the
thinkpad-acpi input map, for example.

Acked-by: Henrique de Moraes Holschuh <hmh@hmh.eng.br>

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh

Re: [PATCH V4 RESEND] Support Thinkpad X1 Carbon 2nd gen's adaptive keyboard

[Shuduo Sang]

[-- Attachment #1.1: Type: text/plain, Size: 1460 bytes --]

On Tue, Apr 1, 2014 at 1:49 AM, Henrique de Moraes Holschuh
<hmh-N3TV7GIv+o9fyO9Q7EP/yw@public.gmane.org>wrote:

> On Tue, Mar 11, 2014, at 8:01, Shuduo Sang wrote:
> > Resend patch V4. Support Thinkpad X1 Carbon 2nd generation's adaptive
> > keyboard.
> >
> > Hi Henrique, could you please have a chance to review it?
>
> I am unable to do a full review right now, but we can always adjust
> minor details of the feature with later patches and the previous reviews
> did help clean up the feature.
>
> However: as far as I am concerned, this is an experimental feature until
> it matures for a while.  I'd rather we plug this somehow to the
> thinkpad-acpi input map, for example.
>
>
Yes, I tried to use input map but worry old logic need change many since
the new event number
is far to old. The functionality is verified well and get official
recognised by Lenovo.


> Acked-by: Henrique de Moraes Holschuh <hmh-N3TV7GIv+o9fyO9Q7EP/yw@public.gmane.org>
>

There are two more patches for X1 carbon adaptive keyboard need review.

[PATCH] save and restore adaptive keyboard mode for suspend and, resume
[PATCH] support thinkpad HKEY interface version 0x200

They are verified by me and other X1 carbon users.

Thanks Henrique.



>
> --
>   "One disk to rule them all, One disk to find them. One disk to bring
>   them all and in the darkness grind them. In the Land of Redmond
>   where the shadows lie." -- The Silicon Valley Tarot
>   Henrique Holschuh
>

[-- Attachment #1.2: Type: text/html, Size: 2748 bytes --]

[-- Attachment #2: Type: text/plain, Size: 79 bytes --]

------------------------------------------------------------------------------

[-- Attachment #3: Type: text/plain, Size: 201 bytes --]

_______________________________________________
ibm-acpi-devel mailing list
ibm-acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel