From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Darren Hart <dvhart@infradead.org>
Cc: platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH 5/5] intel_scu_ipc: move ipclock to struct intel_scu_ipc_dev
Date: Mon, 12 Oct 2015 11:02:32 +0300 [thread overview]
Message-ID: <1444636952.8361.556.camel@linux.intel.com> (raw)
In-Reply-To: <20151011044349.GE2958@malice.jf.intel.com>
On Sat, 2015-10-10 at 21:43 -0700, Darren Hart wrote:
> On Fri, Oct 09, 2015 at 06:21:37PM +0300, Andy Shevchenko wrote:
> > On Fri, 2015-10-09 at 17:11 +0300, Andy Shevchenko wrote:
> > > No need to use global variable for a mutex. Move it to be a
> > > member of
> > > SCU IPC
> > > device structure.
> >
> > This one is wrong, sorry.
> >
> > >
> > > While here, protect dev member assignment in ->remove() since
> > > user
> > > may
> > > potentially call unbind from sysfs even if driver is built-in.
> >
> > This part is still right.
>
> OK.
>
> With my minor comment to 1/5 and this change, care to send a v2?
Will do later this week.
Also I will update message of the patch 4 as you suggested.
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
next prev parent reply other threads:[~2015-10-12 8:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-09 14:11 [PATCH 1/5] intel_scu_ipc: fix error path by turning to devm_* / pcim_* Andy Shevchenko
2015-10-09 14:11 ` [PATCH 2/5] intel_scu_ipc: propagate struct intel_scu_ipc_dev Andy Shevchenko
2015-10-09 14:11 ` [PATCH 3/5] intel_scu_ipc: convert to use struct device * Andy Shevchenko
2015-10-09 14:11 ` [PATCH 4/5] intel_scu_ipc: switch to use module_pci_driver() macro Andy Shevchenko
2015-10-11 4:39 ` Darren Hart
2015-10-09 14:11 ` [PATCH 5/5] intel_scu_ipc: move ipclock to struct intel_scu_ipc_dev Andy Shevchenko
2015-10-09 15:21 ` Andy Shevchenko
2015-10-11 4:43 ` Darren Hart
2015-10-12 8:02 ` Andy Shevchenko [this message]
2015-10-11 4:21 ` [PATCH 1/5] intel_scu_ipc: fix error path by turning to devm_* / pcim_* Darren Hart
2015-10-12 8:00 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1444636952.8361.556.camel@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=dvhart@infradead.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox