From: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
To: "Hans de Goede" <hdegoede@redhat.com>,
"Darren Hart" <dvhart@infradead.org>,
"Andy Shevchenko" <andy@infradead.org>,
"Pali Rohár" <pali.rohar@gmail.com>,
"Jacek Anaszewski" <jacek.anaszewski@gmail.com>,
"Pavel Machek" <pavel@ucw.cz>
Cc: platform-driver-x86@vger.kernel.org, linux-leds@vger.kernel.org
Subject: Re: [PATCH v8 3/7] platform/x86/thinkpad: Call led_classdev_notify_brightness_hw_changed on kbd brightness change
Date: Thu, 09 Feb 2017 16:08:25 -0200 [thread overview]
Message-ID: <1486663705.1046615.875913456.7B8ADABA@webmail.messagingengine.com> (raw)
In-Reply-To: <20170209154417.19040-4-hdegoede@redhat.com>
On Thu, Feb 9, 2017, at 13:44, Hans de Goede wrote:
> Make thinkpad_acpi call led_classdev_notify_brightness_hw_changed on the
> kbd_led led_classdev registered by thinkpad_acpi when the kbd backlight
> brightness is changed through the hotkey.
>
> This will allow userspace to monitor (poll) for brightness changes on
> these LEDs caused by the hotkey.
It will *often* do so, you assume the thinkpad firmware is far more well
behaved than it really is :-(
It is model/bios-revision specific. Fortunately, it should works on
most models, and there really isn't a better way of doing this (other
than adding the event to the NVRAM poll set of some very old models,
which is also not worth doing unless you can actually test it).
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Acked-by: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
--
Henrique Holschuh
next prev parent reply other threads:[~2017-02-09 18:08 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-09 15:44 [PATCH v8 0/7] platform/x86: Notify userspace about hotkeys changing kbd-backlight brightness Hans de Goede
2017-02-09 15:44 ` [PATCH v8 1/7] platform/x86/thinkpad_acpi: Stop setting led_classdev brightness directly Hans de Goede
2017-02-09 18:09 ` Henrique de Moraes Holschuh
2017-03-01 11:27 ` Pali Rohár
2017-03-01 11:57 ` Hans de Goede
2017-03-01 12:00 ` Pali Rohár
2017-03-01 12:04 ` Hans de Goede
2017-03-01 14:24 ` Marco Trevisan (Treviño)
2017-02-09 15:44 ` [PATCH v8 2/7] platform/x86/thinkpad_acpi: Use brightness_set_blocking callback for LEDs Hans de Goede
2017-02-09 18:00 ` Henrique de Moraes Holschuh
2017-02-09 15:44 ` [PATCH v8 3/7] platform/x86/thinkpad: Call led_classdev_notify_brightness_hw_changed on kbd brightness change Hans de Goede
2017-02-09 18:08 ` Henrique de Moraes Holschuh [this message]
2017-02-13 22:52 ` Andy Shevchenko
2017-02-14 9:25 ` Hans de Goede
2017-02-14 9:33 ` Andy Shevchenko
2017-02-17 3:45 ` Darren Hart
2017-02-14 9:36 ` Pali Rohár
2017-02-09 15:44 ` [PATCH v8 4/7] platform/x86/dell-*: Add a generic dell-laptop notifier chain Hans de Goede
2017-02-21 14:18 ` Pali Rohár
2017-02-09 15:44 ` [PATCH v8 5/7] platform/x86/dell-laptop: Refactor kbd_led_triggers_store() Hans de Goede
2017-02-21 14:02 ` Pali Rohár
2017-02-09 15:44 ` [PATCH v8 6/7] platform/x86/dell-laptop: Protect kbd_state against races Hans de Goede
2017-02-21 14:06 ` Pali Rohár
2017-02-21 14:18 ` Hans de Goede
2017-02-21 14:25 ` Pali Rohár
2017-02-21 14:42 ` Hans de Goede
2017-02-21 14:53 ` Pali Rohár
2017-02-09 15:44 ` [PATCH v8 7/7] platform/x86/dell-*: Call led_classdev_notify_brightness_hw_changed on kbd brightness change Hans de Goede
2017-02-21 14:11 ` Pali Rohár
2017-02-21 14:40 ` Hans de Goede
2017-02-21 14:50 ` Pali Rohár
2017-02-21 14:56 ` Hans de Goede
2017-02-21 15:13 ` Pali Rohár
2017-02-21 16:14 ` Hans de Goede
2017-02-21 17:08 ` Pali Rohár
2017-02-22 8:36 ` Hans de Goede
2017-02-22 8:49 ` Pali Rohár
2017-02-22 10:24 ` Hans de Goede
2017-02-22 12:01 ` Pali Rohár
2017-02-22 12:20 ` Hans de Goede
2017-03-01 11:15 ` Pali Rohár
2017-03-01 12:02 ` Hans de Goede
2017-03-01 12:55 ` Pali Rohár
2017-03-01 13:58 ` Hans de Goede
2017-03-03 12:00 ` Pali Rohár
2017-03-06 13:39 ` Hans de Goede
2017-03-16 10:11 ` Hans de Goede
2017-02-21 20:47 ` Jacek Anaszewski
2017-02-09 20:21 ` [PATCH v8 0/7] platform/x86: Notify userspace about hotkeys changing kbd-backlight brightness Jacek Anaszewski
2017-02-11 20:08 ` Pavel Machek
2017-03-01 23:10 ` Andy Shevchenko
2017-03-02 14:12 ` Hans de Goede
2017-03-02 14:22 ` Pali Rohár
2017-03-02 14:30 ` Hans de Goede
2017-03-02 14:34 ` Pali Rohár
2017-03-02 15:27 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1486663705.1046615.875913456.7B8ADABA@webmail.messagingengine.com \
--to=hmh@hmh.eng.br \
--cc=andy@infradead.org \
--cc=dvhart@infradead.org \
--cc=hdegoede@redhat.com \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-leds@vger.kernel.org \
--cc=pali.rohar@gmail.com \
--cc=pavel@ucw.cz \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox