* [PATCH] drivers:platform/x86:Use ARRAY_SIZE() for the size calculation of the array.
@ 2017-09-13 8:02 Allen Pais
2017-09-13 8:42 ` Chakravarty, Souvik K
0 siblings, 1 reply; 3+ messages in thread
From: Allen Pais @ 2017-09-13 8:02 UTC (permalink / raw)
To: linux-kernel; +Cc: souvik.k.chakravarty, platform-driver-x86, Allen Pais
Signed-off-by: Allen Pais <allen.lkml@gmail.com>
---
drivers/platform/x86/intel_telemetry_debugfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/platform/x86/intel_telemetry_debugfs.c b/drivers/platform/x86/intel_telemetry_debugfs.c
index d4fc42b..3ccc7ac 100644
--- a/drivers/platform/x86/intel_telemetry_debugfs.c
+++ b/drivers/platform/x86/intel_telemetry_debugfs.c
@@ -76,7 +76,7 @@
#define TELEM_IOSS_DX_D0IX_EVTS 25
#define TELEM_IOSS_PG_EVTS 30
-#define TELEM_EVT_LEN(x) (sizeof(x)/sizeof((x)[0]))
+#define TELEM_EVT_LEN(x) (ARRAY_SIZE(x))
#define TELEM_DEBUGFS_CPU(model, data) \
{ X86_VENDOR_INTEL, 6, model, X86_FEATURE_ANY, (unsigned long)&data}
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [PATCH] drivers:platform/x86:Use ARRAY_SIZE() for the size calculation of the array.
2017-09-13 8:02 [PATCH] drivers:platform/x86:Use ARRAY_SIZE() for the size calculation of the array Allen Pais
@ 2017-09-13 8:42 ` Chakravarty, Souvik K
2017-09-13 8:51 ` Allen
0 siblings, 1 reply; 3+ messages in thread
From: Chakravarty, Souvik K @ 2017-09-13 8:42 UTC (permalink / raw)
To: Allen Pais, linux-kernel@vger.kernel.org
Cc: platform-driver-x86@vger.kernel.org
Hi Allen,
> -----Original Message-----
> From: platform-driver-x86-owner@vger.kernel.org [mailto:platform-driver-
> x86-owner@vger.kernel.org] On Behalf Of Allen Pais
> Sent: Wednesday, September 13, 2017 1:33 PM
> To: linux-kernel@vger.kernel.org
> Cc: Chakravarty, Souvik K <souvik.k.chakravarty@intel.com>; platform-
> driver-x86@vger.kernel.org; Allen Pais <allen.lkml@gmail.com>
> Subject: [PATCH] drivers:platform/x86:Use ARRAY_SIZE() for the size
> calculation of the array.
>
> Signed-off-by: Allen Pais <allen.lkml@gmail.com>
> ---
> drivers/platform/x86/intel_telemetry_debugfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/intel_telemetry_debugfs.c
> b/drivers/platform/x86/intel_telemetry_debugfs.c
> index d4fc42b..3ccc7ac 100644
> --- a/drivers/platform/x86/intel_telemetry_debugfs.c
> +++ b/drivers/platform/x86/intel_telemetry_debugfs.c
> @@ -76,7 +76,7 @@
> #define TELEM_IOSS_DX_D0IX_EVTS 25
> #define TELEM_IOSS_PG_EVTS 30
>
> -#define TELEM_EVT_LEN(x) (sizeof(x)/sizeof((x)[0]))
> +#define TELEM_EVT_LEN(x) (ARRAY_SIZE(x))
The outer parenthesis seems redundant to me.
>
> #define TELEM_DEBUGFS_CPU(model, data) \
> { X86_VENDOR_INTEL, 6, model, X86_FEATURE_ANY, (unsigned
> long)&data}
> --
> 2.7.4
BR,
Souvik
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drivers:platform/x86:Use ARRAY_SIZE() for the size calculation of the array.
2017-09-13 8:42 ` Chakravarty, Souvik K
@ 2017-09-13 8:51 ` Allen
0 siblings, 0 replies; 3+ messages in thread
From: Allen @ 2017-09-13 8:51 UTC (permalink / raw)
To: Chakravarty, Souvik K
Cc: linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org
>> #define TELEM_IOSS_PG_EVTS 30
>>
>> -#define TELEM_EVT_LEN(x) (sizeof(x)/sizeof((x)[0]))
>> +#define TELEM_EVT_LEN(x) (ARRAY_SIZE(x))
> The outer parenthesis seems redundant to me.
>
Will send out a v2. Thanks.
- Allen
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-09-13 8:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-13 8:02 [PATCH] drivers:platform/x86:Use ARRAY_SIZE() for the size calculation of the array Allen Pais
2017-09-13 8:42 ` Chakravarty, Souvik K
2017-09-13 8:51 ` Allen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox