ThinkPad Yoga 370 thinkpad_acpi: unknown/reserved multi-mode value

ThinkPad Yoga 370 thinkpad_acpi: unknown/reserved multi-mode value

[Henrique de Moraes Holschuh]

(changed subject and split email thread on purpose).

On Wed, 25 Apr 2018, Jordan Glover wrote:
> thinkpad_acpi: Unknown/reserved multi mode value 0x0000 for type 4,
> please report this to ibm-acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
> 
> After reboot this message is gone. Previously it was printed on every boot, that's
> why I thought it's gone completely. There aren't any messages about unhandled
> keys anymore.

Well, the first problem report (and the patches I sent to this ML) do
not address this specific error message at all, thus it is no wonder it
can still show up.

FWIW, the error "unknown/reserved multi mode value" is about a real
problem, and not related to "unhandled events" at all.  What we'd have
to do is to track down the root cause for this one.

But let's do that in a separate thread, shall we?  It is an unrelated
issue to the ones in this thread, after all...

-- 
  Henrique Holschuh

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot

Re: ThinkPad Yoga 370 thinkpad_acpi: unknown/reserved multi-mode value

[Jordan Glover via ibm-acpi-devel]

On April 25, 2018 1:29 PM, Henrique de Moraes Holschuh <hmh-N3TV7GIv+o9fyO9Q7EP/yw@public.gmane.org> wrote:

> (changed subject and split email thread on purpose).
> 
> On Wed, 25 Apr 2018, Jordan Glover wrote:
> 
> > thinkpad_acpi: Unknown/reserved multi mode value 0x0000 for type 4,
> > 
> > please report this to ibm-acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
> > 
> > After reboot this message is gone. Previously it was printed on every boot, that's
> > 
> > why I thought it's gone completely. There aren't any messages about unhandled
> > 
> > keys anymore.
> 
> Well, the first problem report (and the patches I sent to this ML) do
> 
> not address this specific error message at all, thus it is no wonder it
> 
> can still show up.
> 
> FWIW, the error "unknown/reserved multi mode value" is about a real
> 
> problem, and not related to "unhandled events" at all. What we'd have
> 
> to do is to track down the root cause for this one.
> 
> But let's do that in a separate thread, shall we? It is an unrelated
> 
> issue to the ones in this thread, after all...
> 
> 
> 
> Henrique Holschuh

Ok, thx for clarification. Can you give me a hint how to track down this issue?
What info I could provide? Currently I'm not seeing anything useful in logs
beside that one message.

Jordan



------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot

Re: ThinkPad Yoga 370 thinkpad_acpi: unknown/reserved multi-mode value

[Benjamin Berg]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Hi,

On Wed, 2018-04-25 at 08:29 -0300, Henrique de Moraes Holschuh wrote:
> FWIW, the error "unknown/reserved multi mode value" is about a real
> problem, and not related to "unhandled events" at all.  What we'd have
> to do is to track down the root cause for this one.

AFAICT, the value 0 for multi-mode type 4 is specified to be reserved.
If this happens at boot time, then maybe it really tells us that the
current state is not known at the time similar to what appears to be
the case for other modes.

Sounds like the best solution is to just assume that a value of 0x0
always means the state is unknown and assume we are in laptop mode.

Simply adding TP_ACPI_MULTI_MODE_UNKNOWN to the lists of valid modes
should fix the warning.

Benjamin
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEED2NO4vMS33W8E4AFq6ZWhpmFY3AFAlrgcvwACgkQq6ZWhpmF
Y3Bitw//ZiR3S6z5FxP2zrJPFYowCBj96qf63/Fj12dlZoUs4dROqKZzUraf6c23
q5dETfzWaCYM3pNDOpQBs+uAkd6sSf8HfuVgiRUg3tF/mKvfF3eHrvxxVmBQ0Zch
Ul8rsuzG3I23Jpsj4MH/rogTQvIPU8ZoBO0q+pXcGEqSmMmdy4/saNRJtltfhZ6C
WVRs3f754X74OSndkXYO/t01M9woeAQwsjmhlHL07IP0uzEj0tZlspix4I4AePbK
2yAAo6k7RaSshqWldjXpqG1nrF4vstYomY78+ble8tKp+zjgn3TTIZL7MbNvlQU3
6wpQhMRSzgPRqHHprg4fa+8nHPE2ObnyGvNeUj0pc8hbMBlBc4FGe7Vgt4VwaExr
JWVDuTFp0Ae/F7VkmqAxOMOSxDjljm9d3C4jAAzHiuw3nyK+9ZVizEQhC5QB5MjZ
vt5qNdC/efGc5zUpwHGPSfMYt1iLgxXLzV/l2KZzE4B7G/PG2jTjlz23QUv6QkWz
JFCNsqJ/6ziSCOPTsSjNVy5mO6S09LxqHrDWXS75UfZ7FmNlhdQr0e/LF/vmUIsY
6oWQlRxB5oiJeKUrOou+iL3dyzGUJsGvGExiU/TlB/hgW+1Zu7yh7eE1/0ZSt3xX
6TBiKOaLYfPnDYx7UgQ2EZKs5tpA7L9jgfSl1TE1rB0P6FEOIZE=
=YoiH
-----END PGP SIGNATURE-----


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot

Re: ThinkPad Yoga 370 thinkpad_acpi: unknown/reserved multi-mode value

[Jordan Glover via ibm-acpi-devel]

On April 25, 2018 2:22 PM, Benjamin Berg <bberg@redhat.com> wrote:

> Hi,
> 
> On Wed, 2018-04-25 at 08:29 -0300, Henrique de Moraes Holschuh wrote:
> 
> > FWIW, the error "unknown/reserved multi mode value" is about a real
> > 
> > problem, and not related to "unhandled events" at all. What we'd have
> > 
> > to do is to track down the root cause for this one.
> 
> AFAICT, the value 0 for multi-mode type 4 is specified to be reserved.
> 
> If this happens at boot time, then maybe it really tells us that the
> 
> current state is not known at the time similar to what appears to be
> 
> the case for other modes.
> 
> Sounds like the best solution is to just assume that a value of 0x0
> 
> always means the state is unknown and assume we are in laptop mode.
> 
> Simply adding TP_ACPI_MULTI_MODE_UNKNOWN to the lists of valid modes
> 
> should fix the warning.
> 
> Benjamin

For the reference, below are all thinkpad_acpi messages I get during cold boot:

thinkpad_acpi: ThinkPad ACPI Extras v0.26
thinkpad_acpi: http://ibm-acpi.sf.net/
thinkpad_acpi: ThinkPad BIOS R0HET47W (1.27 ), EC unknown
thinkpad_acpi: Lenovo ThinkPad Yoga 370, model 20JJS0HD00
thinkpad_acpi: radio switch found; radios are enabled
thinkpad_acpi: Unknown/reserved multi mode value 0x0000 for type 4, please report this to ibm-acpi-devel@lists.sourceforge.net
thinkpad_acpi: Tablet mode switch found (type: GMMS), currently in laptop mode
thinkpad_acpi: This ThinkPad has standard ACPI backlight brightness control, supported by the ACPI video driver
thinkpad_acpi: Disabling thinkpad-acpi brightness events by default...
thinkpad_acpi: Standard ACPI backlight interface available, not loading native one
thinkpad_acpi: battery 1 registered (start 75, stop 100)
input: ThinkPad Extra Buttons as /devices/platform/thinkpad_acpi/input/input13

After reboot it stays the same except :
thinkpad_acpi: Unknown/reserved multi mode value 0x0000 for type 4, please report this to ibm-acpi-devel@lists.sourceforge.net
which is missing then.

​Jordan

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
ibm-acpi-devel mailing list
ibm-acpi-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel

Re: ThinkPad Yoga 370 thinkpad_acpi: unknown/reserved multi-mode value

[Benjamin Berg]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Hi,

On Wed, 2018-04-25 at 08:28 -0400, Jordan Glover wrote:
> After reboot it stays the same except :
> thinkpad_acpi: Unknown/reserved multi mode value 0x0000 for type 4,
> please report this to ibm-acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
> which is missing then.

That sounds reasonable. It just means that we are not able to resolve
the multi mode state right away after a cold boot. That does leave the
question whether we should be doing anything else so that the state is
resolved correctly.

A quick test could be to do a cold boot with the laptop folded into
tablet mode. I believe dmesg will be identical, but you should see
(e.g. using evemu-describe on "ThinkPad Extra Buttons") that
SW_TABLET_MODE has toggled to 1 rather than still having a state of 0
for laptop mode.

Benjamin
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEED2NO4vMS33W8E4AFq6ZWhpmFY3AFAlrgfdgACgkQq6ZWhpmF
Y3C6nw//cUDToH0S/hr31xsgxK2A8a0mdE5qWBp4oCVfknLMuWKttyWF8BPgstAP
0hrmA0sGXZSLne4NZaSuCbuLGP5HuFEBvJqKuYJS3dR4W1rNnoTYMguz/NZFcDxx
ByK3fH3YKfZerNQrnfHOhjF3u1D293qFJmkWDHg2MghrMfWl/4472aFrlWGhbLiI
TAOfmXL/RY1zJlt7q4gziLRvqQoV/KV7Ks6vfmw58Z0BMct+/4+cJenFaX5r0y83
1K0HgIkEf8UT3Xr/DptASPu7b++Ik49tF7NSg67qOY949Y0Qagcyfyfcf1G+NEpp
qWDAs5cbToD+W8zz5W5dh85V7qutOJDOjFhXyaCDg/oLxIc01I5siuNn4vWK85cQ
dEL1imuS+lREZaIpksQhAYU91C3pwEt1onAMN1PAp7QbXNgU9tm216rl/rKQd0Nf
NX7zusK6HcsxnHiwxR+aXlmCy3XivxjbLfQVp8hOsWwx9tBIO/n5r9S+9Dryq8RX
5YU1jEMeoGZhaDHisKgZ2eHxFO+ZhC0w26DpV6kTTmu6K2lEXfiAMtJC5S/MHvVa
LB6gvG0OJPXrqpWQOxTXLdBkadI0XqMNgsalt/kvUzq4fQm5nyqbNvltJp51danp
Z6+7eInGqkwg4Y9dYYYdwLbstGMs1iJETHB6caIuaMDns6zCdAU=
=SId3
-----END PGP SIGNATURE-----


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot

Re: ThinkPad Yoga 370 thinkpad_acpi: unknown/reserved multi-mode value

[Jordan Glover via ibm-acpi-devel]

On April 25, 2018 3:08 PM, Benjamin Berg <bberg@redhat.com> wrote:

> Hi,
> 
> On Wed, 2018-04-25 at 08:28 -0400, Jordan Glover wrote:
> 
> > After reboot it stays the same except :
> > 
> > thinkpad_acpi: Unknown/reserved multi mode value 0x0000 for type 4,
> > 
> > please report this to ibm-acpi-devel@lists.sourceforge.net
> > 
> > which is missing then.
> 
> That sounds reasonable. It just means that we are not able to resolve
> 
> the multi mode state right away after a cold boot. That does leave the
> 
> question whether we should be doing anything else so that the state is
> 
> resolved correctly.
> 
> A quick test could be to do a cold boot with the laptop folded into
> 
> tablet mode. I believe dmesg will be identical, but you should see
> 
> (e.g. using evemu-describe on "ThinkPad Extra Buttons") that
> 
> SW_TABLET_MODE has toggled to 1 rather than still having a state of 0
> 
> for laptop mode.
> 
> Benjamin

I have to admit that I can't handle booting and checking this in tablet mode
(without keyboard) so I won't confirm it, sorry.

​Jordan

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
ibm-acpi-devel mailing list
ibm-acpi-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel

Re: ThinkPad Yoga 370 thinkpad_acpi: unknown/reserved multi-mode value

[Henrique de Moraes Holschuh]

On Thu, 26 Apr 2018, Jordan Glover via ibm-acpi-devel wrote:
> I have to admit that I can't handle booting and checking this in tablet mode
> (without keyboard) so I won't confirm it, sorry.

FWIW, any USB keyboard should allow you to do this easily if there is at
least one USB port still exposed while in tablet mode...

That said, thanks for the help you gave us thus far!

-- 
  Henrique Holschuh

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot